Wireshark-commits: [Wireshark-commits] master 73ac697: [skinny]: Fix tvb struct size guard value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Feb 2017 05:40:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=73ac6974c4db73846c37d811a02d17c1436eab47
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

73ac697 by Diederik de Groot (dkgroot@xxxxxxxx):

    [skinny]: Fix tvb struct size guard value
    
    The struct size guard value was used incorrectly, causing message with short
    content to be only partially dissected.
    
    Minor:
    - Renamed OffHookWithCgpn to OffHookWithCalingPartyNumber
    - Added SetHookFlashDetect Message
    - Removed some of the debug logging when parse_xml2skinny_dissector.py:debug=0
    
    Change-Id: If4f20d2412f8775fac3d0a2979200e8369cea6f2
    Reviewed-on: https://code.wireshark.org/review/20186
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a4d7793   Qt: Avoid flicker in filter expressions toolbar
    adds  73ac697   [skinny]: Fix tvb struct size guard value


Summary of changes:
 epan/dissectors/packet-skinny.c     |  328 ++++++++++++++++++-----------------
 tools/SkinnyProtocolOptimized.xml   |    3 +-
 tools/parse_xml2skinny_dissector.py |   74 ++++----
 3 files changed, 203 insertions(+), 202 deletions(-)