Wireshark-commits: [Wireshark-commits] master-2.2 b88bb55: Qt: Warn the user about DBAR 1.8 on Wind
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Feb 2017 07:36:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b88bb55779df2b720ed00bd58a82ed1e2e274977
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

b88bb55 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Warn the user about DBAR 1.8 on Windows.
    
    At startup, dig through the registry looking for shell extensions. If
    any of them match known Dell Backup and Recovery DLL names and the DLL
    version matches 1.8.*.*, show the user a warning dialog.
    
    This is a bit extreme but I'm not sure what else to do. Dell is a popular
    computer manufacturer and bug reports keep trickling in.
    
    Change-Id: I6d1bd6c56850279356570154d231b07facb30cff
    Bug: 12036
    Ping-bug: 12701
    Ping-bug: 13414
    Reviewed-on: https://code.wireshark.org/review/16861
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit a5a8fce06ecb5aff1dfcf101bb2b5455bd776569)
    Reviewed-on: https://code.wireshark.org/review/20150
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c3d895f   Qt: Disable pane menu items if not used in layout
    adds  b88bb55   Qt: Warn the user about DBAR 1.8 on Windows.


Summary of changes:
 CMakeLists.txt                  |    1 +
 cmake/modules/UseWinLibs.cmake  |    1 +
 ui/qt/wireshark_application.cpp |  128 +++++++++++++++++++++++++++++++++++++++
 ui/qt/wireshark_application.h   |    4 ++
 4 files changed, 134 insertions(+)