Wireshark-commits: [Wireshark-commits] master 23d3a30: ssl-utils: refactor DigitallySigned
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Feb 2017 05:05:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23d3a3021655f3d70bf5e26aa4d5cdf471cf1688
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

23d3a30 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: refactor DigitallySigned
    
    Refactor DigitallySigned dissection to return the length and make it
    accept a version integer instead of Session pointer. Hopefully this
    makes it easier to use the routine for SCT dissection in X.509 certs.
    
    While at it, convert it to use ssl_add_vector.
    
    Change-Id: I64afecc65ff597fda50d208d8f96ca0b97bfcbde
    Reviewed-on: https://code.wireshark.org/review/20111
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9a22102   [skinny]: Added conversation and request_response handling
    adds  23d3a30   ssl-utils: refactor DigitallySigned


Summary of changes:
 epan/dissectors/packet-dtls.c      |    4 +-
 epan/dissectors/packet-ssl-utils.c |   99 ++++++++++++++++++------------------
 epan/dissectors/packet-ssl-utils.h |    9 ++--
 epan/dissectors/packet-ssl.c       |    4 +-
 4 files changed, 58 insertions(+), 58 deletions(-)