Wireshark · Wireshark-commits: [Wireshark-commits] master 5dde07c: GSM A / NAS-EPS: detect missing mandatory information elements

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5dde07c8fdb2e17c4d4142427fe29f7db66c1965
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5dde07c by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    GSM A / NAS-EPS: detect missing mandatory information elements
    
    Current code is not able to detect missing mandatory information elements
    because the macro will return once the end of the payload is reached.
    Remove this check from all mandatory IE macros, and put it at the beginning
    of optional IE ones. It should allow to detect any missing mandatory IE
    while still stopping message dissection in case optional IEs are not
    present.
    
    Change-Id: Ie820740e25c1d03ee3462fa4a913c3a7870fcc2d
    Reviewed-on: https://code.wireshark.org/review/19816
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  2755942   Bluetooth 5.0, HCI command/event PHY update dissection
    adds  5dde07c   GSM A / NAS-EPS: detect missing mandatory information elements


Summary of changes:
 epan/dissectors/packet-gsm_a_common.h |   20 +++++-----------
 epan/dissectors/packet-gsm_a_dtap.c   |   10 --------
 epan/dissectors/packet-gsm_a_rr.c     |    2 --
 epan/dissectors/packet-nas_eps.c      |   42 ++-------------------------------
 4 files changed, 8 insertions(+), 66 deletions(-)