Wireshark-commits: [Wireshark-commits] master fe06aad: sharkd: fix warning C4090: 'function' : diff
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Feb 2017 02:40:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fe06aad460d7525cc6196019b18bf9972e078231
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fe06aad by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    sharkd: fix warning C4090: 'function' : different 'const' qualifiers
    
    According to https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx
    the lpCommandLine argument must not be const as is may cause an access violation.
    
    Change-Id: Iedd77663cd21ca8df542595890fbc7023f2c9c2b
    Reviewed-on: https://code.wireshark.org/review/19922
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  7c69ae9   dfilter-macro: add cleanup routine.
    adds  fe06aad   sharkd: fix warning C4090: 'function' : different 'const' qualifiers


Summary of changes:
 .editorconfig   |   11 +++++++++++
 sharkd_daemon.c |    6 ++++--
 2 files changed, 15 insertions(+), 2 deletions(-)