Wireshark-commits: [Wireshark-commits] master-2.0 4439e69: Return correct filter for get_hostlist_f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 Feb 2017 00:20:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4439e69914392c2cdbc219c27e5f9ee884038e8f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4439e69 by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    Return correct filter for get_hostlist_filter()
    
    It was returning (ip.src == ... && <protocol>.port == ...).
    
    Now, I think correctly returns (ip.addr == ... && <protocol>.port == ...)
    
    Change-Id: I242e13c0c79c2222e2b27fc2f9ee348b89d21ec1
    Reviewed-on: https://code.wireshark.org/review/20281
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 59b672e5907d272ea5bd5ef571b03e004d07705a)
    Reviewed-on: https://code.wireshark.org/review/20305
    

Actions performed:

    from  971aaca   wslua: fix documentation of Struct.fromhex
    adds  4439e69   Return correct filter for get_hostlist_filter()


Summary of changes:
 epan/dissectors/packet-sctp.c |   17 +++++++++++++++--
 epan/dissectors/packet-tcp.c  |   16 +++++++++++++++-
 epan/dissectors/packet-udp.c  |   17 ++++++++++++++++-
 3 files changed, 46 insertions(+), 4 deletions(-)