Wireshark · Wireshark-commits: [Wireshark-commits] master-2.2 462ca74: mswsp: Numerous bugfixes

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=462ca740e4b3de807d1bc9bdb1cdc1bd88ae8831
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

462ca74 by Noel Power (noel.power@xxxxxxxx):

    mswsp: Numerous bugfixes
    
    1. Fix display of CTableColumn.StatusUsed & CTableColumn.LengthUsed
    Both StatusUsed and LenghtUsed members were displayed as 2 byte length
    values instead of single byte values.
    
    2. Fix minor spelling mistake
    
    3. display correct address(s) for array of address values
    
    4. Use correct minimum CTableColumn size
    
    This is followup patch for patch already provided for bug 13299.
    The previous minimum value neglated to take into account the
    CFullPropSpec structure (which is on the wire) but is represtented
    as a string in the internal CTableColumn structure. Note: this doesn't
    make any difference to the effectiveness of the previous patch but should
    avoid confusion if someone later actually investigates the correct minimum
    size.
    
    5. Fix CPMCREATEQUERY message parsing
    
    Following a query and subsequent clarification from dochelp@xxxxxxxxxxxxx
    the MS-WSP specification document was found to be incorrect.
    
    CPMCreateQueryIn
          |
          ---> CSortSet
    
    should instead eventually point to CSortSet via the following msg structure
    
    CPMCreateQueryIn
          |
          ---> CInGroupSortAggregSets
               |
                ---> CInGroupSortAggregSet
                     |
                     ---> CSortSet
    
    Change-Id: I7da6c7db817113f5542f25f078626030ad30d737
    Signed-off-by: Noel Power <noel.power@xxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/20031
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit b18245a60c5dc3532d144699dd00f36d84c4e176)
    Reviewed-on: https://code.wireshark.org/review/20044
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  6df3ddc   Add wtap_init to dftest.
    adds  462ca74   mswsp: Numerous bugfixes


Summary of changes:
 epan/dissectors/packet-mswsp.c |   31 +++++++++++--------------------
 1 file changed, 11 insertions(+), 20 deletions(-)