Wireshark-commits: [Wireshark-commits] master 87b7242: radius: fix memleaks of value_string
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 Feb 2017 19:05:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87b7242e69845db13daf570101903521e17cfd50
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

87b7242 by Peter Wu (peter@xxxxxxxxxxxxx):

    radius: fix memleaks of value_string
    
    The value_string was taken from the GArray and added to
    radius_attr_info_t, but these were not properly freed.
    
    Change-Id: I8de2b84760887c41229a57881ff46cedcef1d22f
    Reviewed-on: https://code.wireshark.org/review/20311
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  77d309c   radius: fix final memleak due to malformed dictionary
    adds  87b7242   radius: fix memleaks of value_string


Summary of changes:
 epan/dissectors/packet-radius.c |   10 +++++++++-
 epan/radius_dict.l              |   22 ++++++++++------------
 2 files changed, 19 insertions(+), 13 deletions(-)