Wireshark-commits: [Wireshark-commits] master 012a179: Fix a double free.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 21 Feb 2017 19:04:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=012a179785abada629fa324652755c6acb51be74
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

012a179 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Fix a double free.
    
    In create_persconffile_profile, pf_dir_path_copy needs to be allocated
    separately since the subsequent call to get_dirname is destructive. Add
    back a call to g_strdup. This should hopefully fix a crash in the Win32
    buildbot.
    
    Change-Id: I591b5845032c9b8a5324bf6ac60fc43d1e92ac2e
    Reviewed-on: https://code.wireshark.org/review/20231
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f04e770   [GSM A BSSMAP] Correct a cause value according to TS 48.008 V13.2.0
    adds  012a179   Fix a double free.


Summary of changes:
 wsutil/filesystem.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)