Wireshark-commits: [Wireshark-commits] master f958dd5: TLS13: support Early Data and accept CLIENT_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Feb 2017 18:39:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f958dd5acecda5a9f38500687718dce3ece26ed4
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f958dd5 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS13: support Early Data and accept CLIENT_EARLY_TRAFFIC_SECRET
    
    Update "early_data" extension to draft 18 (context field is gone).
    Add support for "client_early_traffic_secret" to the keylog.
    Support decryption of 0-RTT data (required handling cipher in Client
    Hello and handling of "end_of_early_data" alert).
    
    Tested with tls13-18-picotls-earlydata.pcap, early data decrypts
    correctly. (The server data is messed up, but that is possibly the
    result of broken NewSessionTicket handling which throws a dissector
    exception and thus breaks the record sequence number.)
    
    Ping-Bug: 12779
    Change-Id: I9e6aeeb08111d5d977f2c0ab855f14d6d86ca87d
    Reviewed-on: https://code.wireshark.org/review/19989
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  6d08a0e   [H248 Annex C] hf variable imported from packet-sdp,c is uint16 not int
    adds  f958dd5   TLS13: support Early Data and accept CLIENT_EARLY_TRAFFIC_SECRET


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   86 ++++++++++++++++++------------------
 epan/dissectors/packet-ssl-utils.h |   10 ++---
 epan/dissectors/packet-ssl.c       |   48 +++++++++++++++-----
 3 files changed, 83 insertions(+), 61 deletions(-)