Wireshark-commits: [Wireshark-commits] master b28b073: editcap: handle too short frames in frame co
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Feb 2017 22:32:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b28b07379fe966f0a89ead9fe2fa30ac05e19e9c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b28b073 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    editcap: handle too short frames in frame comparison
    
    With option -I one can ignore the first number of bytes from the frame
    while doing duplicate frame removal. This doesn't handle shorter frames
    correctly. Add safeguards for this, and update the help text.
    
    Bug: 13378
    Change-Id: Ia6b65d0797f4069f0b89fa134114d88d80988211
    Reviewed-on: https://code.wireshark.org/review/20004
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  edf5ae3   proto: destroy list on cleanup.
    adds  b28b073   editcap: handle too short frames in frame comparison


Summary of changes:
 doc/editcap.pod |    7 ++++---
 editcap.c       |   23 +++++++++++++++++------
 2 files changed, 21 insertions(+), 9 deletions(-)