Wireshark-commits: [Wireshark-commits] master-2.2 f693761: SNMP: duplicate dynamic members of snmp_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Feb 2017 16:53:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f693761baa1de16cceff9a1fe29dbad865300477
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

f693761 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    SNMP: duplicate dynamic members of snmp_ue_assoc_t structure in localize_ue()
    
    Otherwise you can end up freeing twice the same memory blocks
    (from localized_ues and unlocalized_ues lists)
    
    Bug: 13420
    Change-Id: I7e6f1f8d740b0e5ffca851f3f5b1928a7686c069
    Reviewed-on: https://code.wireshark.org/review/20190
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 1089211c0b0aca7d95b4f54ca0e61d070555e896)
    Conflicts:
    	epan/dissectors/packet-snmp.c
    Reviewed-on: https://code.wireshark.org/review/20198
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fdc7845   [Automatic update for 2017-02-19]
    adds  f693761   SNMP: duplicate dynamic members of snmp_ue_assoc_t structure in localize_ue()


Summary of changes:
 epan/dissectors/asn1/snmp/packet-snmp-template.c |    5 +++++
 epan/dissectors/packet-snmp.c                    |   11 ++++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)