Wireshark · Wireshark-commits: [Wireshark-commits] master 3f0e6d5: ssl-utils: add vector length validation for Client Hello

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f0e6d51ba4af8a84ad94a8a45bfc98fcba9efc5
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3f0e6d5 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: add vector length validation for Client Hello
    
    Use ssl_add_vector to process DTLS Cookie, cipher_suites,
    compression_methods, client_hello_extension_list. Removed some checks
    (like cipher_suite_length > 0) since (per specification) these must be
    non-empty (if this is not the case, then at worst an empty tree is
    visible).
    
    Change-Id: I7ab2ef12e210d5878769478c7dfba33a799fb567
    Reviewed-on: https://code.wireshark.org/review/19993
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  0e74fbb   Make sure pid_t is defined.
    adds  3f0e6d5   ssl-utils: add vector length validation for Client Hello


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |  135 +++++++++++++++++-------------------
 epan/dissectors/packet-ssl-utils.h |    9 +--
 epan/dissectors/packet-ssl.c       |    2 +-
 3 files changed, 66 insertions(+), 80 deletions(-)