Wireshark-commits: [Wireshark-commits] master 513eed68: text2pcap: check return values of functions
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Feb 2017 00:52:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=513eed6871198d025a45ad70aaa50721857c2095
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

513eed68 by Dario Lombardo (lomato@xxxxxxxxx):

    text2pcap: check return values of functions and use a single exit point.
    
    This is going to check every function for success and following patches
    will free allocated memory in clean_exit.
    
    Change-Id: I7ba7a53eae8a37a4c25e56369af20e575c3489fb
    Reviewed-on: https://code.wireshark.org/review/20225
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a08177b   HTTP: do not call g_path_get_basename with a NULL pointer
    adds  513eed68  text2pcap: check return values of functions and use a single exit point.


Summary of changes:
 text2pcap-scanner.l |   21 ++++---
 text2pcap.c         |  166 +++++++++++++++++++++++++++++----------------------
 text2pcap.h         |    2 +-
 3 files changed, 109 insertions(+), 80 deletions(-)