Wireshark-commits: [Wireshark-commits] master fb3a7ca: [skinny] Fix ConnectionStatRes and DialedNum
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Feb 2017 16:14:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb3a7caa1746e4e33b21a90cce5921ded621a0b9
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fb3a7ca by Diederik de Groot (dkgroot@xxxxxxxx):

    [skinny] Fix ConnectionStatRes and DialedNumber Messages protocol version >20
    
    - ConnectionStatisticsResponse Comes in three different forms
    - DialedNumber Message has variable length
    
    Minor:
    - Pass ipv4or6 connection address back to calling function (using this later on in seperate commit)
    - Correct spelling mistakes
    - Remove duplicates from DeviceType[]
    
    Change-Id: Ib1619b163c12b6a4c6c86972186d828be3fd94e2
    Reviewed-on: https://code.wireshark.org/review/20056
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6550b10   [Automatic update for 2017-02-12]
    adds  fb3a7ca   [skinny] Fix ConnectionStatRes and DialedNumber Messages protocol version >20


Summary of changes:
 epan/dissectors/packet-skinny.c     |  244 ++++++++++++++++---------------
 epan/dissectors/packet-skinny.c.in  |   56 +++-----
 epan/dissectors/packet-skinny.h     |   36 +++--
 epan/dissectors/packet-skinny.h.in  |   40 ++++--
 tools/SkinnyProtocolOptimized.xml   |  272 +++++++++++++++++++----------------
 tools/parse_xml2skinny_dissector.py |   21 ++-
 6 files changed, 341 insertions(+), 328 deletions(-)