| June 01, 2015 |
|---|
| 03:30 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis |
buildbot-no-reply |
|
| 07:35 |
[Wireshark-commits] master 2be0042: Websocket: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 07:45 |
[Wireshark-commits] master 11b3d64: Eliminate proto_tree_add_text from packet-sip.c |
Wireshark code review |
|
| 09:03 |
[Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test |
buildbot-no-reply |
|
| 09:03 |
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test |
buildbot-no-reply |
|
| 15:59 |
[Wireshark-commits] master fb5e9e4: Convert AFS dissector to use ptvcursor API. |
Wireshark code review |
|
| 16:06 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 16:07 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 17:53 |
[Wireshark-commits] master 0f7c74a: AFS: Fix Mac OS X buildbot (-Wshadow) |
Wireshark code review |
|
| 18:50 |
[Wireshark-commits] master f1a6ba1: gtk: Don't handle deprecation warnings as errors |
Wireshark code review |
|
| June 02, 2015 |
|---|
| 11:27 |
[Wireshark-commits] master-1.12 9fa6881: Clean up handling of BDC coded numbers a bit. |
Wireshark code review |
|
| 11:27 |
[Wireshark-commits] master d751205: ISAKMP: do not try to defragment IKEv1 packets |
Wireshark code review |
|
| 11:38 |
[Wireshark-commits] master 0808f4c: MSVC 2015RC does not like the #defines using OFFSETOF replace them by absoulute numbers. |
Wireshark code review |
|
| 13:28 |
[Wireshark-commits] master 4ed7cc7: Revert "MSVC 2015RC does not like the #defines using OFFSETOF replace them by absoulute numbers." |
Wireshark code review |
|
| 13:51 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 19:06 |
[Wireshark-commits] master 32177ce: [RTPproxy] Set column name to RTPProxy-ng |
Wireshark code review |
|
| June 03, 2015 |
|---|
| 02:27 |
[Wireshark-commits] master ec3f923: Add the Display Filter Expression dialog. |
Wireshark code review |
|
| 08:00 |
[Wireshark-commits] master 2adeb99: Fix OSX CMake warnings |
Wireshark code review |
|
| 09:10 |
[Wireshark-commits] master bef4da8: ISAKMP: Don't complain about zero-length config attributes in request messages - this is expected |
Wireshark code review |
|
| 10:44 |
[Wireshark-commits] master 360a7ec: G_STRUCT_OFFSET gives warnings turned errors with MSVC2015, use offsetof if defined or define it ourselfs as done in other places in our code base. |
Wireshark code review |
|
| 11:46 |
[Wireshark-commits] master 53f3d7c: openSAFETY: Fix false-positive |
Wireshark code review |
|
| 13:32 |
[Wireshark-commits] master 4490d5e: Netscaler: Fix issue where packets were lost when selected packets were exported |
Wireshark code review |
|
| 13:52 |
[Wireshark-commits] master ee51661: IS-IS (LSP) Add Shared Risk Link Group (SRLG) clv (138) |
Wireshark code review |
|
| 16:53 |
[Wireshark-commits] master 6148cd3: Update mobile network codes of South Korean mobile networks. |
Wireshark code review |
|
| 17:15 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 19:02 |
[Wireshark-commits] master dbcd2a2: Use the GPOINTER_TO UINT macro rather than trying to do the casts manually. This makes MSVC 2015 happy. |
Wireshark code review |
|
| June 04, 2015 |
|---|
| 05:50 |
[Wireshark-commits] master e309d9e: MIME Multipart: fix display of the last IMF field |
Wireshark code review |
|
| 05:51 |
[Wireshark-commits] master-1.12 f683fc7: MIME Multipart: fix display of the last IMF field |
Wireshark code review |
|
| 06:17 |
[Wireshark-commits] master 524ed1d: WCCP: Fix up storing and decoding of IP addresses. |
Wireshark code review |
|
| 06:24 |
[Wireshark-commits] master 8ccf65b: Eliminate proto_tree_add_text from a few dissectors. |
Wireshark code review |
|
| 06:26 |
[Wireshark-commits] master 3059601: [RTPproxy] Simplify positive reply parsing and minor cleanups |
Wireshark code review |
|
| 06:29 |
[Wireshark-commits] master d67c163: Dissection support for pmproxy |
Wireshark code review |
|
| 06:40 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 07:21 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 09:09 |
[Wireshark-commits] master 83b6af0: ISAKMP: fix build about unused variable |
Wireshark code review |
|
| 09:19 |
[Wireshark-commits] master 1ab7a46: rtp/pm proxy: fix implicit conversion shortens 64-bit value into a 32-bit value |
Wireshark code review |
|
| 11:01 |
[Wireshark-commits] master 97255b3: P1: fix request for implicit conversion from 'gpointer' to 'struct p1_address_ctx_t *' not permitted in C++ [-Wc++-compat] |
Wireshark code review |
|
| 12:15 |
[Wireshark-commits] master 539418c: Profinet: Add Fiber Optic Diagnosis Info. |
Wireshark code review |
|
| 13:32 |
[Wireshark-commits] master 8d78077: [MSVC2015] TRy to fix Warnings turned errors. |
Wireshark code review |
|
| 13:39 |
[Wireshark-commits] master 505d303: packet-pmproxy.c:94: warning: implicit conversion shortens 64-bit value into a 32-bit value |
Wireshark code review |
|
| 15:10 |
[Wireshark-commits] master fde38c0: [MSVC 2015] Try to fix warinings turned errors. |
Wireshark code review |
|
| 15:49 |
[Wireshark-commits] master 5f9a52d: SSL: Add support for private key password when decrypting SSL traffic from tshark with -o ssl.keys_list. |
Wireshark code review |
|
| 16:40 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 16:52 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 21:06 |
[Wireshark-commits] master c62546a: Ensure that run_and_catch_crashes has UNIX/POSIX line endings |
Wireshark code review |
|
| 21:34 |
[Wireshark-commits] master 8da4d22: Fix decryption test suite on Windows |
Wireshark code review |
|
| 22:35 |
[Wireshark-commits] master dd26d59: DVB-CI: minor cleanup |
Wireshark code review |
|
| 22:35 |
[Wireshark-commits] master d3c0b50: ZVT: start dissecting the tlv container |
Wireshark code review |
|
| June 05, 2015 |
|---|
| 00:34 |
[Wireshark-commits] master-1.12 92483af: WCCP: Fix up storing and decoding of IP addresses. |
Wireshark code review |
|
| 05:28 |
[Wireshark-commits] master 509eb46: Add dissector for the Aeron protocol. |
Wireshark code review |
|
| 05:35 |
[Wireshark-commits] master 5061da3: iSCSI: handle repetition of InitiatorTaskTag fore request / response tracking |
Wireshark code review |
|
| 07:22 |
[Wireshark-commits] master-1.12 d3117c0: iSCSI: handle repetition of InitiatorTaskTag fore request / response tracking |
Wireshark code review |
|
| 10:33 |
[Wireshark-commits] master be8a7c3: BGP: Add EVPN draft-rabadan-l2vpn-evpn-prefix-advertisement support |
Wireshark code review |
|
| 11:28 |
[Wireshark-commits] master a36f6c5: BGP: MP (UN)REACH NLRI SAFI is 1 octet long |
Wireshark code review |
|
| 18:31 |
[Wireshark-commits] master 198ef94: Don't include cfile.h. |
Wireshark code review |
|
| 19:19 |
[Wireshark-commits] master c2b713c: Qt: Add the capture and display filter dialog. |
Wireshark code review |
|
| 21:14 |
[Wireshark-commits] master 244f2fb: GTK: fix a crash when switching a column to custom through 'Edit Column Details' |
Wireshark code review |
|
| 21:14 |
[Wireshark-commits] master-1.12 ee2465e: GTK: fix a crash when switching a column to custom through 'Edit Column Details' |
Wireshark code review |
|
| 21:15 |
[Wireshark-commits] master-1.10 1386e6a: GTK: fix a crash when switching a column to custom through 'Edit Column Details' |
Wireshark code review |
|
| 21:15 |
[Wireshark-commits] master 1ec868e: Fix a few issues reported by PVS-Studio |
Wireshark code review |
|
| 21:15 |
[Wireshark-commits] master ab6108c: Qt: clear Go To Packet text box when opening it |
Wireshark code review |
|
| 21:39 |
[Wireshark-commits] master 1736a1b: Clean up stats_tree_presentation. |
Wireshark code review |
|
| June 06, 2015 |
|---|
| 01:40 |
[Wireshark-commits] master a365fb8: Print unsigned long values with %lu, not %ld. |
Wireshark code review |
|
| 09:45 |
[Wireshark-commits] master c365dff: TCP: Add (generated) field with first letter of TCP Flags |
Wireshark code review |
|
| 09:47 |
[Wireshark-commits] master 8d46c41: Aruba ERM: Fix FCS for Type 3 |
Wireshark code review |
|
| 09:47 |
[Wireshark-commits] master 7e2e8ef: Aruba ERM: Fix FCS for Type 1 (PEEK) |
Wireshark code review |
|
| 09:48 |
[Wireshark-commits] master ac51c09: Aruba ERM: Use decode AS for decode Aruba ERM Type.. |
Wireshark code review |
|
| 09:48 |
[Wireshark-commits] master 04f0847: IEEE 802.11: Add a option for disable FCS check |
Wireshark code review |
|
| 11:52 |
[Wireshark-commits] master b5b3a6b: ISAKMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 14:04 |
[Wireshark-commits] master 9d3e8f9: BER: fix There are identical sub-expressions 'tvb_reported_length_remaining(tvb, offset)' to the left and to the right of the '==' operator found by PVS Studio (V501) |
Wireshark code review |
|
| 14:04 |
[Wireshark-commits] master 6c2de57: DCC: fix There are identical sub-expressions 'tvb_get_guint8(tvb, offset + 4)' to the left and to the right of the '|' operator found by PVS Studio (V501) |
Wireshark code review |
|
| 14:05 |
[Wireshark-commits] master 31f5e79: DCERPC: There are identical sub-expressions 'tvb_reported_length(tvb)' to the left and to the right of the '==' operator found by PVS Studio (V501) |
Wireshark code review |
|
| 14:06 |
[Wireshark-commits] master 3cc1178: SCSI: There are identical sub-expressions 'tvb_reported_length_remaining(tvb, offset)' to the left and to the right of the '!=' operator found by PVS Studio (V501) |
Wireshark code review |
|
| 14:07 |
[Wireshark-commits] master 027b0cb: SMB2: There are identical sub-expressions to the left and to the right of the '&&' operator: si && si->saved && si->saved found by PVS Studio (V501) |
Wireshark code review |
|
| 14:22 |
[Wireshark-commits] master ac9f248: SKYPE: fix The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence found by PVS Studio (V517). |
Wireshark code review |
|
| 15:06 |
[Wireshark-commits] master be701f6: ISAKMP: fix dissection when building with libgcrypt |
Wireshark code review |
|
| 17:11 |
[Wireshark-commits] master da8c79d: ui/follow: fix The 'find_addr[UDP_STREAM]' variable is assigned values twice successively. Perhaps this is a mistake. Found by PVS Studio (V519) |
Wireshark code review |
|
| 17:49 |
[Wireshark-commits] master 6b65437: ZVT: match requests and responses |
Wireshark code review |
|
| 18:03 |
[Wireshark-commits] master cd2e901: ZVT: call zvt_set_addresses() for each apdu |
Wireshark code review |
|
| 19:20 |
[Wireshark-commits] master b950c08: Use %zu, not %zd, to print a size_t value (%zd would be for ssize_t). |
Wireshark code review |
|
| 19:29 |
[Wireshark-commits] master 8d7e0fc: Don't initialize a variable if the first thing we do is set it. |
Wireshark code review |
|
| June 07, 2015 |
|---|
| 06:38 |
[Wireshark-commits] master ad0b29c: nfs: Git rid of deprecated tvb_length, tvb_length_remaining |
Wireshark code review |
|
| 10:42 |
[Wireshark-commits] master e9c9473: NFS: do not use reported remaining length as the backing length |
Wireshark code review |
|
| 13:07 |
[Wireshark-commits] master 99d56fb: airpdcap: fix V512 warning reported by PVS-Studio |
Wireshark code review |
|
| 14:34 |
[Wireshark-commits] master 6e58ae3: dwarf.c: fix V629 warning reported by PVS-Studio |
Wireshark code review |
|
| 14:35 |
[Wireshark-commits] master 83351a9: iax2_analysis.c: fix V610 warning reported by PVS-Studio |
Wireshark code review |
|
| 14:35 |
[Wireshark-commits] master cefe9d3: ECP: fix V562 warning reported by PVS-Studio |
Wireshark code review |
|
| 15:08 |
[Wireshark-commits] master 7fc302e: [Automatic update for 2015-06-07] |
Wireshark code review |
|
| 15:12 |
[Wireshark-commits] master-1.12 faf280a: [Automatic update for 2015-06-07] |
Wireshark code review |
|
| 15:16 |
[Wireshark-commits] master-1.10 d8174e9: [Automatic update for 2015-06-07] |
Wireshark code review |
|
| 16:04 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 18:59 |
[Wireshark-commits] master d48fe0d: GSM Um: fix V695 warning found by PVS-Studio |
Wireshark code review |
|
| 18:59 |
[Wireshark-commits] master 093aebf: H248: fix V712 warning reported by PVS-Studio |
Wireshark code review |
|
| 19:00 |
[Wireshark-commits] master ae027ec: NDPS: fix V535 warnings reported by PVS-Studio |
Wireshark code review |
|
| 19:00 |
[Wireshark-commits] master c100e1c: PER: fix V593 warning reported by PVS-Studio |
Wireshark code review |
|
| 19:12 |
[Wireshark-commits] master acbc418: NCP: fix V519 warnings reported by PVS-Studio |
Wireshark code review |
|
| 20:52 |
[Wireshark-commits] master 2d757b8: Restore image/expert_ok.png, it is used by GTK+ UI |
Wireshark code review |
|
| 21:58 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis |
buildbot-no-reply |
|
| June 08, 2015 |
|---|
| 01:10 |
[Wireshark-commits] master 5472e4d: Debugging printf. |
Wireshark code review |
|
| 04:21 |
[Wireshark-commits] master 2c56c6f: igmp: fix memleak |
Wireshark code review |
|
| 04:34 |
[Wireshark-commits] master 639fd7d: Eliminate proto_tree_add_text from some dissectors. |
Wireshark code review |
|
| 04:47 |
[Wireshark-commits] master f95db69: Add editor-modelines; Don't use tabwidth=4; Adjust whitespace. |
Wireshark code review |
|
| 04:51 |
[Wireshark-commits] master 0cec384: Register http.unknown_header as an FT_STRING (rather than FT_BYTES). |
Wireshark code review |
|
| 07:26 |
[Wireshark-commits] master a942df9: THRIFT: fix function name typo |
Wireshark code review |
|
| 07:28 |
[Wireshark-commits] master 71b6be7: PER: fix indent (use tabs) |
Wireshark code review |
|
| 07:29 |
[Wireshark-commits] master 5ce025c: Aruba ERM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 07:31 |
[Wireshark-commits] master da1766e: NFSv4: Fix for Bug 10483 |
Wireshark code review |
|
| 08:13 |
[Wireshark-commits] master 032ad5a: Update how we search for Lua with pkg-config. |
Wireshark code review |
|
| 08:13 |
[Wireshark-commits] master fa64878: [GTPv2] Throttling Delay unit values are not the same as the timer values, make a separate Value_string. |
Wireshark code review |
|
| 10:05 |
[Wireshark-commits] master 9223567: BGP: fix an infinite loop when finding an invalid length in EVPN NLRI Route Type 5 option |
Wireshark code review |
|
| 11:13 |
[Wireshark-commits] master 049fc49: Fix MSCV 2015RC Warning in_cksum.c(92): warning C4311: 'type cast': pointer truncation from 'const guint16 *' to 'unsigned long'. |
Wireshark code review |
|
| 11:14 |
[Wireshark-commits] master 7948378: GTPv2: fix indent (use 4 spaces) |
Wireshark code review |
|
| 11:15 |
[Wireshark-commits] master 951ddf7: rpc: Support IB transport |
Wireshark code review |
|
| 13:01 |
[Wireshark-commits] master 09e3505: Profinet: OEM Device ID is added |
Wireshark code review |
|
| 13:05 |
[Wireshark-commits] master 69dac89: tcp: simplify tcp.flags.str, fix off-by-one |
Wireshark code review |
|
| 13:35 |
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test |
buildbot-no-reply |
|
| 13:35 |
[Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test |
buildbot-no-reply |
|
| 16:05 |
[Wireshark-commits] master 845a832: Print "and greater" instead of a ten digit number. |
Wireshark code review |
|
| 17:34 |
[Wireshark-commits] master a36ec5a: AMQP: fix The 'format_name' variable is assigned to itself found by PVS Studio (V570) |
Wireshark code review |
|
| 17:51 |
[Wireshark-commits] master b30d7b1: PMPROXY: check that pointer is not NULL before doing a strlen |
Wireshark code review |
|
| 18:32 |
[Wireshark-commits] master 0f36b1c: aeron: fix infinite loop |
Wireshark code review |
|
| 19:33 |
[Wireshark-commits] master 2533889: Revert "NFSv4: Fix for Bug 10483" |
Wireshark code review |
|
| 19:51 |
[Wireshark-commits] master 2d863b9: Add TapParameterDialog. |
Wireshark code review |
|
| 20:38 |
[Wireshark-commits] master f6f690c: LBMC: fix Truncation of constant value -16. The value range of unsigned char type: [0, 255] found by PVS Studio (V569) |
Wireshark code review |
|
| 21:07 |
[Wireshark-commits] master a750581: SMB: fix a V595 warning reported by PVS-Studio |
Wireshark code review |
|
| 21:20 |
[Wireshark-commits] master 0a78e0b: tap-macltestat.c: fix some V523 warnings reported by PVS-Studio |
Wireshark code review |
|
| June 09, 2015 |
|---|
| 04:00 |
[Wireshark-commits] master e28339e: tshark: add ability to display streams in EBCDIC |
Wireshark code review |
|
| 04:10 |
[Wireshark-commits] master 41ac67c: Fix insertion of subnets read from the subnets file: append to the *end* of the list. |
Wireshark code review |
|
| 04:18 |
[Wireshark-commits] master e187b53: Don't try to clean up uninitialized Lua and crash |
Wireshark code review |
|
| 11:40 |
[Wireshark-commits] master 9cb09a2: [MSVC 2015] Change the check to look for MSVC 2010 or newer rather than adding MSVC 2015 |
Wireshark code review |
|
| 13:12 |
[Wireshark-commits] master 97dfbf5: Add PortAudio to Windows CMake build |
Wireshark code review |
|
| 13:18 |
[Wireshark-commits] master c4fbede: Remove the executable bit from epan/addr_resolv.c |
Wireshark code review |
|
| 14:13 |
[Wireshark-commits] master 4e60e8f: [MSVC 2015] Use intptr_t for "pointer stored as int" to make MSVC happy. |
Wireshark code review |
|
| 14:44 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 20:21 |
[Wireshark-commits] master 0d471c3: GTK: fix a V610 warning reported by PVS-Studio |
Wireshark code review |
|
| 20:21 |
[Wireshark-commits] master cc1849b: Qt: fix a V595 warning reported by PVS-Studio |
Wireshark code review |
|
| 23:38 |
[Wireshark-commits] master 3944e55: Clean up --with-qt handling. |
Wireshark code review |
|
| June 10, 2015 |
|---|
| 00:31 |
[Wireshark-commits] master 2e76bb4: Use pid_t on UN*X, and HANDLE on Windows, for the process ID. |
Wireshark code review |
|
| 00:32 |
[Wireshark-commits] master f023aa1: Get rid of extra blank line at the end. |
Wireshark code review |
|
| 00:51 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC |
buildbot-no-reply |
|
| 00:54 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 00:55 |
[Wireshark-commits] master af9f074: One more ws_process_id change. |
Wireshark code review |
|
| 01:01 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 01:09 |
[Wireshark-commits] master 55267bd: Make sure we include <windows.h> to get HANDLE declared. |
Wireshark code review |
|
| 01:56 |
[Wireshark-commits] master a10a41f: Rename wsutil/process.h to wsutil/processes.h to avoid collisions. |
Wireshark code review |
|
| 03:10 |
[Wireshark-commits] master 62c3bc3: Squelch some type-clash warnings on Windows. |
Wireshark code review |
|
| 04:20 |
[Wireshark-commits] master f389fb5: It's INVALID_HANDLE_VALUE, not INVALID_HANDLE. |
Wireshark code review |
|
| 05:36 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 06:00 |
[Wireshark-commits] master fd82fd4: NFSv4: A zero attribute mask is acceptable in dissect_nfs4_fattrs() if 'type' = FATTR4_BITMAP_ONLY |
Wireshark code review |
|
| 06:08 |
[Wireshark-commits] master 6f675b5: tshark: fix computation of iostat table width when specifying an interval |
Wireshark code review |
|
| 07:47 |
[Wireshark-commits] master-1.12 8dea924: tshark: fix computation of iostat table width when specifying an interval |
Wireshark code review |
|
| 08:01 |
[Wireshark-commits] master 3f64384: [MSVC 2015] Use intptr_t to make MSVC happy. |
Wireshark code review |
|
| 12:22 |
[Wireshark-commits] master 8e5d60b: openSAFETY: Fix smaller bugs in detection and tap |
Wireshark code review |
|
| 12:45 |
[Wireshark-commits] master 963db3a: epl: Add config option for dupl. cmd layer |
Wireshark code review |
|
| 14:52 |
[Wireshark-commits] master 547059d: Provide port names for TCP ports so they can be used in filter expressions. |
Wireshark code review |
|
| 20:02 |
[Wireshark-commits] master 1e58cf4: Provide port names for UDP ports so they can be used in filter expressions. |
Wireshark code review |
|
| 20:23 |
[Wireshark-commits] master e66e37b: ZVT: use the transaction info to set source and destination address |
Wireshark code review |
|
| 21:48 |
[Wireshark-commits] master dcf69bb: BER: fix call to proto_tree_add_bytes_format() |
Wireshark code review |
|
| 23:51 |
[Wireshark-commits] master-1.12 f52abd7: Fix insertion of subnets read from the subnets file: append to the *end* of the list. |
Wireshark code review |
|
| June 11, 2015 |
|---|
| 02:15 |
[Wireshark-commits] master 4c3677e: Replace tabs in files with editor modeline "expandtab" |
Wireshark code review |
|
| 04:04 |
[Wireshark-commits] master 7907b82: .mailmap: Update .mailmap for fix some name / duplicate entry |
Wireshark code review |
|
| 13:33 |
[Wireshark-commits] master aa8a171: Search for the Lua (version < 5.3) package first: it's the most common case. |
Wireshark code review |
|
| 17:22 |
[Wireshark-commits] master f0c0081: Mark items unused or rarely-used as appropriate. |
Wireshark code review |
|
| 17:35 |
[Wireshark-commits] master 74421b3: AMQP 1.0: 'char' should be 4-bytes UTF32 |
Wireshark code review |
|
| 17:35 |
[Wireshark-commits] master-1.12 abb0f11: AMQP 1.0: 'char' should be 4-bytes UTF32 |
Wireshark code review |
|
| 17:37 |
[Wireshark-commits] master 7a927d6: AMQP 1.0: float/double should be in network byte order |
Wireshark code review |
|
| 17:37 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 17:41 |
[Wireshark-commits] master-1.12 1f28519: AMQP 1.0: float/double should be in network byte order |
Wireshark code review |
|
| June 12, 2015 |
|---|
| 04:33 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis |
buildbot-no-reply |
|
| 04:48 |
[Wireshark-commits] master 6fe0751: Asterix dissector can now dissect ASTERIX Category 004. |
Wireshark code review |
|
| 06:12 |
[Wireshark-commits] master db686d8: Add RPCoRDMA dissector |
Wireshark code review |
|
| 08:30 |
[Wireshark-commits] master 91ed2b0: Squelch PortAudio warnings on Windows x64 cmake build |
Wireshark code review |
|
| 08:47 |
[Wireshark-commits] master 9813013: androiddump: Fix Bluetooth External Parser |
Wireshark code review |
|
| 08:47 |
[Wireshark-commits] master 0fb5807: androiddump: Fix socket resource leak |
Wireshark code review |
|
| 08:48 |
[Wireshark-commits] master 1d0d82a: Bluetooth: Device name is UTF-8, not ASCII |
Wireshark code review |
|
| 08:49 |
[Wireshark-commits] master a220761: Bluetooth: SDP: Fix alone DID attributes |
Wireshark code review |
|
| 08:49 |
[Wireshark-commits] master 3966e51: Qt/Bluetooth/ATT: Fix behaviour when capture file is closed |
Wireshark code review |
|
| 08:50 |
[Wireshark-commits] master de3997e: Qt/Bluetooth/ATT: Add SaveAsImage option for table |
Wireshark code review |
|
| 09:44 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 10:04 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 13:16 |
[Wireshark-commits] master 70fa77f: AMQP 1.0: Don't treat decimal[32|64|128] as packet errors |
Wireshark code review |
|
| 13:19 |
[Wireshark-commits] master a7f2b7f: AMQP 1.0: Fix dissection of UUID datatypes |
Wireshark code review |
|
| 13:42 |
[Wireshark-commits] master-1.12 89dd0f0: AMQP 1.0: Don't treat decimal[32|64|128] as packet errors |
Wireshark code review |
|
| 13:42 |
[Wireshark-commits] master-1.12 00888cd: AMQP 1.0: Fix dissection of UUID datatypes |
Wireshark code review |
|
| 20:36 |
[Wireshark-commits] master 905506f: Cleanup and hardening for the Aeron dissector. |
Wireshark code review |
|
| 20:36 |
[Wireshark-commits] master a57398d: Fix some CMake compiler tests for Win64 |
Wireshark code review |
|
| June 13, 2015 |
|---|
| 16:15 |
[Wireshark-commits] master 8e746bd: MPLS: always display payload when no 'Decode As' preference is set |
Wireshark code review |
|
| June 14, 2015 |
|---|
| 13:23 |
[Wireshark-commits] master eaf702b: ber: fix undefined shift |
Wireshark code review |
|
| 15:34 |
[Wireshark-commits] master 5432151: [Automatic update for 2015-06-14] |
Wireshark code review |
|
| 15:40 |
[Wireshark-commits] master-1.12 c818461: [Automatic update for 2015-06-14] |
Wireshark code review |
|
| 18:06 |
[Wireshark-commits] master d42e0f7: Qt: Enable Drag and Drop in the main window. |
Wireshark code review |
|
| 18:19 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 18:30 |
[Wireshark-commits] master f661b3c: Include QUrl. |
Wireshark code review |
|
| 18:43 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC |
buildbot-no-reply |
|
| 18:54 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 21:08 |
[Wireshark-commits] master ea7896a: ZVT: check the minimum apdu length |
Wireshark code review |
|
| 21:08 |
[Wireshark-commits] master 0e72157: ZVT: add the transaction struct as an argument to the payload functions |
Wireshark code review |
|
| 21:31 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 21:45 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 21:51 |
[Wireshark-commits] master 6625cf5: Clean up the ATM dissection a bit. |
Wireshark code review |
|
| June 15, 2015 |
|---|
| 02:02 |
[Wireshark-commits] master 9fb6ec6: Qt: Add the ability to show preferences by module name. |
Wireshark code review |
|
| 05:40 |
[Wireshark-commits] master 7102a06: Qt/Bluetooth: Add Devices dialogue |
Wireshark code review |
|
| 10:55 |
[Wireshark-commits] master c11a912: icmp, wimax: Fix undefined shift |
Wireshark code review |
|
| 11:00 |
[Wireshark-commits] master 960d310: openflow_v4: oxm_length includes experimenter |
Wireshark code review |
|
| 12:09 |
[Wireshark-commits] master 1131398: PCP: fix dissection of R bit |
Wireshark code review |
|
| 12:10 |
[Wireshark-commits] master-1.12 107a626: PCP: fix dissection of R bit |
Wireshark code review |
|
| 12:33 |
[Wireshark-commits] master 75ddc45: Profinet: Combined Object Container is added. |
Wireshark code review |
|
| 14:34 |
[Wireshark-commits] master aeb6419: Separate Windows CMake compiler definitions and flags |
Wireshark code review |
|
| 14:36 |
[Wireshark-commits] master cedaa0d: Support for MPL (https://tools.ietf.org/html/draft-ietf-roll-trickle-mcast-12) |
Wireshark code review |
|
| 19:56 |
[Wireshark-commits] master 5a4f44a: TFS: Mutualize Response/Request TFS |
Wireshark code review |
|
| 19:57 |
[Wireshark-commits] master c1ebd20: GTP: put T-PDU Data item under GTP tree |
Wireshark code review |
|
| 20:11 |
[Wireshark-commits] master 86285d5: [vsip] Fix 2 minor bugs; Do some minor cleanup |
Wireshark code review |
|
| 20:30 |
[Wireshark-commits] master 678c5d5: Fix the CMake windows installer to pickup the locally built zlib1.dll |
Wireshark code review |
|
| 21:03 |
[Wireshark-commits] master 560180b: Move some structures used only in pcap-common.c there. |
Wireshark code review |
|
| 21:10 |
[Wireshark-commits] master 34124c8: Define XXX_phdr structures in the order in which they appear in the union. |
Wireshark code review |
|
| 23:53 |
[Wireshark-commits] master 60ab495: Accept drop events immediately. |
Wireshark code review |
|
| June 16, 2015 |
|---|
| 03:24 |
[Wireshark-commits] master 68e6502: Clean up handling of metadata in Bluetooth dissectors. |
Wireshark code review |
|
| 03:25 |
[Wireshark-commits] master 3d176c9: Clean up whitespace. |
Wireshark code review |
|
| 03:33 |
[Wireshark-commits] master 8baf88b: Don't assume we get passed a null data pointer for JSON files. |
Wireshark code review |
|
| 03:38 |
[Wireshark-commits] master 2a3fa14: wtap_encap dissectors don't get passed a media type name as data. |
Wireshark code review |
|
| 03:46 |
[Wireshark-commits] master ece4b01: Add the wireless toolbar. |
Wireshark code review |
|
| 04:09 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 04:20 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 04:28 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC |
buildbot-no-reply |
|
| 05:07 |
[Wireshark-commits] master dd8b7ca: Check for NL and AIRPCAP defines. |
Wireshark code review |
|
| 06:01 |
[Wireshark-commits] master 15593da: packet-nfs: switch on layout type for getdeviceinfo |
Wireshark code review |
|
| 06:03 |
[Wireshark-commits] master 3de93e7: packet-nfs: flexfile layoutget support |
Wireshark code review |
|
| 06:06 |
[Wireshark-commits] master e439bf6: packet-nfs: flexfile getdeviceinfo support |
Wireshark code review |
|
| 06:09 |
[Wireshark-commits] master 9c1f6dd: packet-nfs: flexfile getdeviceinfo needs to decode rsize/wsize |
Wireshark code review |
|
| 06:10 |
[Wireshark-commits] master 5f03f02: packet-nfs: update to draft 05 of flexfiles xdr |
Wireshark code review |
|
| 06:12 |
[Wireshark-commits] master 112f8e6: packet-nfs: flexfiles now uses string uid/gid |
Wireshark code review |
|
| 06:13 |
[Wireshark-commits] master 220aa51: packet-nfs: For flexfiles the versions is now an array |
Wireshark code review |
|
| 06:57 |
[Wireshark-commits] master a1859b7: Qt: Remove redundant actions from UI file |
Wireshark code review |
|
| 08:32 |
[Wireshark-commits] master c392db5: TLS Decryption is now possible with a user provided PMS and Client Random values |
Wireshark code review |
|
| 09:21 |
[Wireshark-commits] master a0b0f37: PKCS12: fix a duplicate OID |
Wireshark code review |
|
| 11:23 |
[Wireshark-commits] master 7525cac: [Qt] Delete generated file config.pri at "clean" |
Wireshark code review |
|
| 15:58 |
[Wireshark-commits] master 46a9afb: Disable AirPcap by default in Autotools. |
Wireshark code review |
|
| 17:52 |
[Wireshark-commits] master 200c15e: Pass the pseudo-header to wtap_encap dissectors via the "data" argument. |
Wireshark code review |
|
| 17:57 |
[Wireshark-commits] master-1.12 793457b: Prep for 1.12.6. |
Wireshark code review |
|
| 18:59 |
[Wireshark-commits] master 6c4ec4a: Qt: Make sure we have usable command line arguments. |
Wireshark code review |
|
| 19:04 |
[Wireshark-commits] master c3335fb: Don't include <wsutil/frequency-utils.h> if it's not needed. |
Wireshark code review |
|
| 19:21 |
[Wireshark-commits] master d5215c2: Save the wireless toolbar recent settings. |
Wireshark code review |
|
| June 17, 2015 |
|---|
| 01:25 |
[Wireshark-commits] master 26dacfc: Qt: Add protocol preferences menus. |
Wireshark code review |
|
| 03:53 |
[Wireshark-commits] master 053f792: Fix the Qt main window popup behavior. |
Wireshark code review |
|
| 06:29 |
[Wireshark-commits] master 271d8e8: Profinet: I&M5 Data is added. |
Wireshark code review |
|
| 15:20 |
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test |
buildbot-no-reply |
|
| 16:14 |
[Wireshark-commits] master-1.12 ee1fce6: Build 1.12.6. |
Wireshark code review |
|
| 16:16 |
[Wireshark-commits] [wireshark] annotated tag v1.12.6 created (now cb13684) |
Wireshark code review |
|
| 16:16 |
[Wireshark-commits] [wireshark] annotated tag wireshark-1.12.6 created (now e5a3c69) |
Wireshark code review |
|
| 17:37 |
[Wireshark-commits] master-1.12 6100782: 1.12.6 → 1.12.7. |
Wireshark code review |
|
| 18:43 |
[Wireshark-commits] master fb94a27: [ocfs2] trivial changes: unneeded initializer; indentation/whitespace |
Wireshark code review |
|
| 18:43 |
[Wireshark-commits] master dd15c51: [ath] minor cleanup |
Wireshark code review |
|
| 21:34 |
[Wireshark-commits] master d5f1ae7: Asterix dissector support for category 021 v2.3 |
Wireshark code review |
|
| 23:25 |
[Wireshark-commits] master 60f33b6: Qt: fix a crash when closing application under Windows |
Wireshark code review |
|
| 23:46 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| June 18, 2015 |
|---|
| 00:03 |
[Wireshark-commits] master 2dd030d: Update the release notes. |
Wireshark code review |
|
| 00:47 |
[Wireshark-commits] master 9c28594: Add a preferences editor frame. |
Wireshark code review |
|
| 00:47 |
[Wireshark-commits] master 1edfd4f: Add frequency_utils. |
Wireshark code review |
|
| 00:49 |
[Wireshark-commits] master d3c7d6e: [c15ch] Trivial: Remove unneeded #include |
Wireshark code review |
|
| 01:01 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 02:08 |
[Wireshark-commits] master ac96b2c: The STBC subfield of the radiotap MCS field is a count, not a flag. |
Wireshark code review |
|
| 02:15 |
[Wireshark-commits] master d83f86a: Get rid of some unused members of struct ieee_802_11_phdr. |
Wireshark code review |
|
| 03:23 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 04:03 |
[Wireshark-commits] master 0dffb17: Get rid of unnecessary stuff copied-and-pasted from the radiotap dissector. |
Wireshark code review |
|
| 04:25 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 05:49 |
[Wireshark-commits] master 247f596: BTLE: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 07:20 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis |
buildbot-no-reply |
|
| 09:49 |
[Wireshark-commits] master c6c9043: Add possibility to export Logcat Text PDUs |
Wireshark code review |
|
| 10:33 |
[Wireshark-commits] master 05554f8: Asterix: field array must be NULL terminated |
Wireshark code review |
|
| 11:01 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 13:32 |
[Wireshark-commits] master 2391fe5: [aeron] Remove unneeded initializers |
Wireshark code review |
|
| 14:40 |
[Wireshark-commits] master 8cbd144: Bluetooth: ensure to give bluetooth_data structure to dissect_eir_ad_data() |
Wireshark code review |
|
| 14:50 |
[Wireshark-commits] master d8529ba: Add ExtremeNetworks attribute 213 (and the source of the information) |
Wireshark code review |
|
| 17:04 |
[Wireshark-commits] master 03c02f3: Build 1.99.7. |
Wireshark code review |
|
| 17:06 |
[Wireshark-commits] [wireshark] annotated tag v1.99.7 created (now 3680a90) |
Wireshark code review |
|
| 17:06 |
[Wireshark-commits] [wireshark] annotated tag wireshark-1.99.7 created (now 81fa157) |
Wireshark code review |
|
| 20:04 |
[Wireshark-commits] master f00e6fb: 1.99.7 → 1.99.8 |
Wireshark code review |
|
| 20:05 |
[Wireshark-commits] [wireshark] annotated tag v1.99.8rc0 created (now 1ccc2f2) |
Wireshark code review |
|
| 20:13 |
[Wireshark-commits] master d9b36c4: Pass the 802.11 pseudo-header as an argument. |
Wireshark code review |
|
| 21:32 |
[Wireshark-commits] master 9e4b299: Qt: remove some compilation warnings |
Wireshark code review |
|
| June 19, 2015 |
|---|
| 13:21 |
[Wireshark-commits] master 7ec7e43: Bluetooth: Coverity fixes |
Wireshark code review |
|
| 13:31 |
[Wireshark-commits] master e43ff89: recent.c: accept an UTF-8 string in read_set_recent_pair_dynamic() function |
Wireshark code review |
|
| 13:33 |
[Wireshark-commits] master aa8fcb3: Improved dissection of some netlink attributes |
Wireshark code review |
|
| 13:35 |
[Wireshark-commits] master 4d3abcc: [thrift] fix a minor bug; Also: use col_clear() |
Wireshark code review |
|
| 19:32 |
[Wireshark-commits] master d47a686: [rtse] Convert tabs to spaces to match editor modelines |
Wireshark code review |
|
| 19:48 |
[Wireshark-commits] master a8ddf90: [rpcrdma] Do some minor bug-fixes and cleanup |
Wireshark code review |
|
| 19:54 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC |
buildbot-no-reply |
|
| June 20, 2015 |
|---|
| 13:46 |
[Wireshark-commits] master 4c898c3: qt_ui_utils: fix parameter 'glib_string' not found in the function declaration |
Wireshark code review |
|
| 13:59 |
[Wireshark-commits] master 5714ad5: ftypes: display BASE_HEX_DEC integers as hexadecimal |
Wireshark code review |
|
| 14:00 |
[Wireshark-commits] master-1.12 49bc1a9: print.c: display BASE_HEX_DEC integers as hexadecimal |
Wireshark code review |
|
| 22:24 |
[Wireshark-commits] master bffabc7: Support the "number of extension spatial streams" information. |
Wireshark code review |
|
| 22:42 |
[Wireshark-commits] master debb811: Use "Present"/"Absent" for presence bits. |
Wireshark code review |
|
| 23:01 |
[Wireshark-commits] master bc9e141: [mifare] minor cleanup |
Wireshark code review |
|
| 23:01 |
[Wireshark-commits] master 02537f8: [mifare] make the payload of the write command filterable |
Wireshark code review |
|
| 23:02 |
[Wireshark-commits] master 77ed038: (trivial) fix a spelling mistake in a comment |
Wireshark code review |
|
| 23:02 |
[Wireshark-commits] master 2895d58: Call the "802.11 radio information" dissector for radio headers. |
Wireshark code review |
|
| June 21, 2015 |
|---|
| 03:35 |
[Wireshark-commits] master 6de6f7f: Further refactor SRT stats. |
Wireshark code review |
|
| 03:47 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 04:49 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 05:43 |
[Wireshark-commits] master 334087b: srt_table: fix conversion shortens 64-bit value into a 32-bit value |
Wireshark code review |
|
| 11:47 |
[Wireshark-commits] master 649c484: editcap: trivial changes while looking into the -L option |
Wireshark code review |
|
| 12:00 |
[Wireshark-commits] master 7d70d3e: Remove now unneeded tap-srt.h |
Wireshark code review |
|
| 12:19 |
[Wireshark-commits] master 6c3f1f2: editcap: split usage output so won't wrap in cmd.exe window |
Wireshark code review |
|
| 15:09 |
[Wireshark-commits] master 56880d7: [Automatic update for 2015-06-21] |
Wireshark code review |
|
| 15:14 |
[Wireshark-commits] master-1.12 de26aed: [Automatic update for 2015-06-21] |
Wireshark code review |
|
| 16:26 |
[Wireshark-commits] master 27fc2b7: ERM (Aruba): Fix Assigned value is garbage or undefined found by Clang Analyzer |
Wireshark code review |
|
| 18:40 |
[Wireshark-commits] master a2e2c1f: Fix memory leak printing eui64s |
Wireshark code review |
|
| 22:39 |
[Wireshark-commits] master ebc8ec8: Remove deprecated tvb_length from a bunch of dissectors |
Wireshark code review |
|
| 22:43 |
[Wireshark-commits] master 31f5459: PKCS12: fix warning about unused parameter when don't build with LIBGCRYPT |
Wireshark code review |
|
| June 22, 2015 |
|---|
| 02:14 |
[Wireshark-commits] master 1223ba5: [bmp] minor cleanup |
Wireshark code review |
|
| 05:35 |
[Wireshark-commits] master d729d80: Convert "macro checks" to use expert info in line with dissectors with comparable checks. |
Wireshark code review |
|
| 05:42 |
[Wireshark-commits] master e8a238f: Eliminate proto_tree_add_text from some dissectors. |
Wireshark code review |
|
| 06:00 |
[Wireshark-commits] master eb2dffa: GSM MAP: Fix decoding of IPv6 addresses |
Wireshark code review |
|
| 06:49 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 07:14 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 07:50 |
[Wireshark-commits] master c52dc98: Fix typo caused assertion |
Wireshark code review |
|
| 13:50 |
[Wireshark-commits] master ce40ea3: service_response_time_table.h: fix parameter 'gui_data' not found in the function declaration [-Wdocumentation] |
Wireshark code review |
|
| 14:26 |
[Wireshark-commits] master cb7fd6f: [rfid-pn532] (benign) Use ENC_BIG_ENDIAN (not ENC_NA) for several 3-byte fields. |
Wireshark code review |
|
| 14:26 |
[Wireshark-commits] master c0f5b23: [pcep] (benign) Use ENC_BIG_ENDIAN (not ENC_NA) for certain multibyte fields. |
Wireshark code review |
|
| 14:53 |
[Wireshark-commits] master 8b230ea: Fix make distcheck buildbot |
Wireshark code review |
|
| 15:13 |
[Wireshark-commits] master 8f390d4: Refactor RTD stats. |
Wireshark code review |
|
| 15:40 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 15:53 |
[Wireshark-commits] master 02b4977: Add a strlen cast. |
Wireshark code review |
|
| 17:02 |
[Wireshark-commits] master 475a232: PKCS12: fix unused function 'dissect_AuthenticatedSafe_PDU' [-Wunused-function] |
Wireshark code review |
|
| 17:02 |
[Wireshark-commits] master c079420: PKCS12: Remove from ASN1 DIRTY list |
Wireshark code review |
|
| 17:02 |
[Wireshark-commits] master d23d53e: ws80211_utils.h: fix empty paragraph passed to '@param' command [-Wdocumentation] |
Wireshark code review |
|
| 17:48 |
[Wireshark-commits] master a94b443: NCP: fix comma at end of enumerator list [-Wpedantic] |
Wireshark code review |
|
| 18:41 |
[Wireshark-commits] master 45872b9: checkAPIs.pl: proto_tree_add_bytes_item takes an encoding parameter |
Wireshark code review |
|
| 20:43 |
[Wireshark-commits] master be6fb60: Remove a bunch of deprecated tvb_length calls |
Wireshark code review |
|
| 20:55 |
[Wireshark-commits] master 2e3629a: fix the interface list in the main welcome screen |
Wireshark code review |
|
| 20:56 |
[Wireshark-commits] master f99e20e: rtd_table.h: fix parameter 'srt/srt_array' not found in the function declaration [-Wdocumentation] |
Wireshark code review |
|
| 21:06 |
[Wireshark-commits] master df352c5: Use StockIcon to load toolbar icons. |
Wireshark code review |
|
| 21:40 |
[Wireshark-commits] master 11803d4: Remove more tvb_length |
Wireshark code review |
|
| 21:48 |
[Wireshark-commits] master 8abe108: ieee80211: fix memleak |
Wireshark code review |
|
| 22:05 |
[Wireshark-commits] master 8aa91b3: Provide PHY type and band information in the 802.11 pseudo-header. |
Wireshark code review |
|
| 22:44 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 22:44 |
[Wireshark-commits] master e34e6c6: Fix "Unescaped left brace in regex is deprecated" |
Wireshark code review |
|
| 22:45 |
[Wireshark-commits] master 7db3021: IEEE 802.11: add an expert info when tag length value is bigger than remaining payload |
Wireshark code review |
|
| 22:46 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 22:47 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 22:50 |
[Wireshark-commits] master 1504531: packet: write explicit type for destroy_heuristic_dissector_list |
Wireshark code review |
|
| 22:54 |
[Wireshark-commits] master 5ab4570: gtk, qt: Fix minor buffer underrun |
Wireshark code review |
|
| 23:07 |
[Wireshark-commits] master eaf62bb: Fix handling of XChannel radiotap field. |
Wireshark code review |
|
| 23:16 |
[Wireshark-commits] master 79c384d: Don't use the value of the Flags field if we didn't have it. |
Wireshark code review |
|
| 23:28 |
[Wireshark-commits] master a7f5e18: SIP: add support for draft-ietf-insipid-session-id |
Wireshark code review |
|
| 23:43 |
[Wireshark-commits] master a43682d: srt_table.h: fix parameter 'opt_arg/filter' not found in the function declaration [-Wdocumentation] |
Wireshark code review |
|
| June 23, 2015 |
|---|
| 00:06 |
[Wireshark-commits] master 67ab8a0: Remove more deprecated tvb_length |
Wireshark code review |
|
| 00:19 |
[Wireshark-commits] master 958cef5: Remove more deprecated tvb_length |
Wireshark code review |
|
| 00:50 |
[Wireshark-commits] master db72eb4: wmem_tree_new_autoreset() never returns NULL |
Wireshark code review |
|
| 03:36 |
[Wireshark-commits] master ce9c1df: coverity 1306905: integer overflowed argument |
Wireshark code review |
|
| 03:52 |
[Wireshark-commits] master 46e5fd8: CFM: fix CFM Type Test signal (TST) without CRC dissection |
Wireshark code review |
|
| 03:52 |
[Wireshark-commits] master-1.12 c7f3ea0: CFM: fix CFM Type Test signal (TST) without CRC dissection |
Wireshark code review |
|
| 03:54 |
[Wireshark-commits] master 6fd7e5b: Remove more deprecated tvb_length calls |
Wireshark code review |
|
| 04:52 |
[Wireshark-commits] master 61e127a: RANAP: call nsap properly when bindingID is included in transport address |
Wireshark code review |
|
| 04:57 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 04:59 |
[Wireshark-commits] master 167f9b7: IS-IS (LSP): Remove proto_tree_add_text call |
Wireshark code review |
|
| 05:46 |
[Wireshark-commits] master 42c324d: packet: fix memleak |
Wireshark code review |
|
| 05:46 |
[Wireshark-commits] master 0c71b13: prefs: fix memleak |
Wireshark code review |
|
| 06:06 |
[Wireshark-commits] master 1dc608a: Morph ProgressBar into CaptureProgressFrame. |
Wireshark code review |
|
| 06:54 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 07:00 |
[Wireshark-commits] master 74c5ab0: Treat channel flags fields as just collections of bits, not as type fields. |
Wireshark code review |
|
| 07:22 |
[Wireshark-commits] master 7cdd22f: Try to catch TShark crashing and get a stack trace. |
Wireshark code review |
|
| 13:09 |
[Wireshark-commits] master 6fe3f2c: Use RTD functionality for H.225 |
Wireshark code review |
|
| 13:42 |
[Wireshark-commits] master b59e28d: Regenerate *-tap-register.c when associated Makefile.common is updated |
Wireshark code review |
|
| 15:43 |
[Wireshark-commits] lts-1.12.1 f83b56a: Clean up handling of BDC coded numbers a bit. |
Wireshark code review |
|
| 15:44 |
[Wireshark-commits] lts-1.12.1 ce1ac2c: WCCP: Fix up storing and decoding of IP addresses. |
Wireshark code review |
|
| 17:16 |
[Wireshark-commits] master be67f53: Exit with the exit status of the command we ran. |
Wireshark code review |
|
| 17:36 |
[Wireshark-commits] master 3f6af3b: P1: fix 'dissect_p1_T_report_type' defined but not used [-Wunused-function] |
Wireshark code review |
|
| 17:37 |
[Wireshark-commits] master ed8ad06: P1: Remove from ASN1 DIRTY list |
Wireshark code review |
|
| 17:44 |
[Wireshark-commits] master 17ac383: [zvt] the TLV container starts with an overall length field |
Wireshark code review |
|
| 17:56 |
[Wireshark-commits] master eb321f8: Remove deprecated tvb_length from PIDL dissectors |
Wireshark code review |
|
| 17:59 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 18:02 |
[Wireshark-commits] master bc14725: [afp] improve the error handling for extended attributes |
Wireshark code review |
|
| 18:10 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 18:13 |
[Wireshark-commits] master 9723c7a: Remove more deprecated tvb_length calls |
Wireshark code review |
|
| 18:16 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 18:23 |
[Wireshark-commits] master d7b286c: Qt: Be less aggressive about reselecting packets. |
Wireshark code review |
|
| 18:26 |
[Wireshark-commits] master 8bc294c: Replace more deprecated tvb_length calls |
Wireshark code review |
|
| 18:27 |
[Wireshark-commits] master 0901e26: Qt: change default behavior of 'Decode As' window |
Wireshark code review |
|
| 18:30 |
[Wireshark-commits] master 65bac2d: Remove the P1 dissector from the dirty dissectors list. |
Wireshark code review |
|
| 20:12 |
[Wireshark-commits] master 89fbf02: [MSVC 2015] file_exists() fails on MSVC2105 as file_stat.st_ino gets reset to zero in the function call if the file does not exist. The general code seems to work with MSVC2015 so use that. |
Wireshark code review |
|
| 20:14 |
[Wireshark-commits] master b216d26: extend the RPL dissector with basic P2P RPL support |
Wireshark code review |
|
| 20:15 |
[Wireshark-commits] master d85a221: proto_tree_add_item_ret_(u)int: do the NULL check at the start |
Wireshark code review |
|
| 20:18 |
[Wireshark-commits] master 2b68a6f: tshark: fix memleak from version lookup |
Wireshark code review |
|
| 20:39 |
[Wireshark-commits] master 911b934: [Qt] if the capture is stopped before we received any packet... |
Wireshark code review |
|
| 20:39 |
[Wireshark-commits] master 633ba95: [Qt] switch screens only if we're acutally starting a capture |
Wireshark code review |
|
| 20:44 |
[Wireshark-commits] master 99ab5c9: netflow: cope with multiple duration types in one flow. |
Wireshark code review |
|
| 21:04 |
[Wireshark-commits] master e53337a: replace another bunch of deprecated tvb_length calls |
Wireshark code review |
|
| 21:14 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 21:31 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 21:32 |
[Wireshark-commits] master d4f6480: ISAKMP: fix Cisco fragmentation support. |
Wireshark code review |
|
| 22:18 |
[Wireshark-commits] master 0a9a255: Remove more deprecated tvb_length calls |
Wireshark code review |
|
| 22:48 |
[Wireshark-commits] master 93592e4: openwire: remove useless register_init_routine call |
Wireshark code review |
|
| June 24, 2015 |
|---|
| 00:13 |
[Wireshark-commits] master fa6ebae: Improved prefix display and comments for IID copying |
Wireshark code review |
|
| 00:19 |
[Wireshark-commits] master a8acb53: Pass the signal and noise dBm values to the 802.11 radio dissector. |
Wireshark code review |
|
| 00:22 |
[Wireshark-commits] master ad784bc: Put the frequency/channel and RSSI data into columns. |
Wireshark code review |
|
| 00:22 |
[Wireshark-commits] master f92fab4: Remove a bunch more deprecated tvb_length calls |
Wireshark code review |
|
| 00:25 |
[Wireshark-commits] master 893e1e5: Fill in the 802.11 pseudo-header and call the "802.11+radio" dissector. |
Wireshark code review |
|
| 00:31 |
[Wireshark-commits] master 9b5b7c1: Remove deprecated tvb_length calls |
Wireshark code review |
|
| 02:09 |
[Wireshark-commits] master 1425255: Handle downloading and installing CMake 3.x. |
Wireshark code review |
|
| 02:31 |
[Wireshark-commits] master ae92a83: Update build instructions for cmake near the end a bit |
Wireshark code review |
|
| 03:21 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 03:27 |
[Wireshark-commits] master d0faa9a: HTTP2: Update to libnghttp2 1.0.4 |
Wireshark code review |
|
| 04:30 |
[Wireshark-commits] master 69cdfe9: Remove another batch of deprecated tvb_length calls |
Wireshark code review |
|
| 05:10 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 15:31 |
[Wireshark-commits] master b7aacfd: libnghttp2: readd remove check for CONFIG.H |
Wireshark code review |
|
| 15:34 |
[Wireshark-commits] master 5dcd207: Check _MSC_VER is defined before we use it |
Wireshark code review |
|
| 17:10 |
[Wireshark-commits] master 17c59f5: Qt: Add Reload button on MainToolBar |
Wireshark code review |
|
| 17:13 |
[Wireshark-commits] master d406b28: Don't export libnghttp2 routines outside libwireshark. |
Wireshark code review |
|
| 17:17 |
[Wireshark-commits] master 86e562f: Qt: Add x-capture-file-reload@xxxxxx to Makefile.am |
Wireshark code review |
|
| 17:32 |
[Wireshark-commits] master 95ac390: Remove the last deprecated tvb_length calls |
Wireshark code review |
|
| 17:34 |
[Wireshark-commits] master-1.12 181e560: Aruba ERM: Fix FCS for Type 3 |
Wireshark code review |
|
| 17:34 |
[Wireshark-commits] master-1.12 7035c8d: Aruba ERM: Fix FCS for Type 1 (PEEK) |
Wireshark code review |
|
| 17:47 |
[Wireshark-commits] master 58b0354: Add a bunch of " I missed in my previous patch. |
Wireshark code review |
|
| 18:57 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 19:26 |
[Wireshark-commits] master 137c495: Run compress-pngs.sh. |
Wireshark code review |
|
| 19:48 |
[Wireshark-commits] master ec094b5: Initialize default stats before using them |
Wireshark code review |
|
| 21:24 |
[Wireshark-commits] master 1f0226c: dumpcap: fix files capture autostop condition |
Wireshark code review |
|
| 21:25 |
[Wireshark-commits] master-1.12 15578d4: dumpcap: fix files capture autostop condition |
Wireshark code review |
|
| 21:26 |
[Wireshark-commits] master cc614a9: qt: fix button state when cancelling save |
Wireshark code review |
|
| 21:42 |
[Wireshark-commits] master 0d28caf: qt: fix more button states |
Wireshark code review |
|
| 21:43 |
[Wireshark-commits] master 89cc85b: Disable "Refresh Interfaces" when capturing |
Wireshark code review |
|
| 22:21 |
[Wireshark-commits] master f75e52b: file.c: fix Fix Branch condition evaluates to a garbage value found by Clang Analyzer |
Wireshark code review |
|
| 22:33 |
[Wireshark-commits] master cf8eed9: Dissect 802.3 Jumbo frames while capturing. |
Wireshark code review |
|
| 23:14 |
[Wireshark-commits] master f5b09f2: print blank strings in -Tfields |
Wireshark code review |
|
| June 25, 2015 |
|---|
| 00:10 |
[Wireshark-commits] master cdc7d25: Add ability to export PDUs for heuristic dissectors also |
Wireshark code review |
|
| 01:02 |
[Wireshark-commits] master 585f944: acse: don't THROW() an exception from a dissector |
Wireshark code review |
|
| 01:46 |
[Wireshark-commits] master 6126a64: Fix proto_tree_add_bytes_item() when we fail to decode number from string |
Wireshark code review |
|
| 01:46 |
[Wireshark-commits] master-1.12 2728dfc: Fix proto_tree_add_bytes_item() when we fail to decode number from string |
Wireshark code review |
|
| 02:36 |
[Wireshark-commits] master d1a81df: NAS EPS: fix a missed capital letter |
Wireshark code review |
|
| 02:53 |
[Wireshark-commits] master 5aaaa55: Add basic Vagrant configuration |
Wireshark code review |
|
| 04:01 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 04:05 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 06:27 |
[Wireshark-commits] master ba5e0a3: Netflow: fix typo (wrong time units for duration) |
Wireshark code review |
|
| 07:40 |
[Wireshark-commits] master 0a28aa4: Revert commit cc8ed845ed53ed60fa776728f1d7f2659dd311a3 Author: Maarten Bezemer <maarten.bezemer@xxxxxxxxx> Date: Wed Nov 12 13:39:07 2014 +0100 |
Wireshark code review |
|
| 08:02 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 15:13 |
[Wireshark-commits] master 85d3989: Aruba (ERM): Add missing type 4 (PPI) to Decode AS |
Wireshark code review |
|
| 15:13 |
[Wireshark-commits] master c37b05d: ARUBA (ERM): Add type 5 |
Wireshark code review |
|
| 15:22 |
[Wireshark-commits] master 92c8c3a: TCP: Add expert info to indicate when there is TCP Fast Open SYN (with Cookie) |
Wireshark code review |
|
| 15:24 |
[Wireshark-commits] master 47abcfc: Vagrant setup fixes |
Wireshark code review |
|
| 15:32 |
[Wireshark-commits] master fe6ece9: afp: replace all calls to THROW() and do proper error handling |
Wireshark code review |
|
| 15:39 |
[Wireshark-commits] master 3f5d183: Stop using atof/strtod (fixes column sorting of float types) |
Wireshark code review |
|
| 15:41 |
[Wireshark-commits] master 7e62a03: fix the 'then' statement is equivalent to the 'else' statement found by PVS Studio (V523) |
Wireshark code review |
|
| 15:51 |
[Wireshark-commits] master 1810112: Add minimize and maximize buttons to the TCP stream dialogs. |
Wireshark code review |
|
| 15:55 |
[Wireshark-commits] master cb84022: Qt: fix crashes when Wireshark is closed while running a capture |
Wireshark code review |
|
| 16:07 |
[Wireshark-commits] master e963cbf: editcap: keep timestamp resolution when converting a nseclibpcap file to pcapng |
Wireshark code review |
|
| 16:13 |
[Wireshark-commits] master d4aa1a1: Qt: mark unused parameters as such |
Wireshark code review |
|
| 16:23 |
[Wireshark-commits] master acc5810: Plugin Interface: Add GUI callbacks |
Wireshark code review |
|
| 16:42 |
[Wireshark-commits] master 74e526f: Add proper "Decode As" mechanism for L2TPv3 subdissectors instead of preference. |
Wireshark code review |
|
| 16:44 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 16:59 |
[Wireshark-commits] master 6c698f3: diameter: fix a memory leak on startup |
Wireshark code review |
|
| 17:11 |
[Wireshark-commits] master 534d1d5: Qt: use <> for including the generated ui_*.h files |
Wireshark code review |
|
| 17:12 |
[Wireshark-commits] master 9dd21d9: Qt, cmake: put the build dir before the source dir in the include path |
Wireshark code review |
|
| 17:16 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 17:39 |
[Wireshark-commits] master e4f88dd: Fix a memory leak registering prefs |
Wireshark code review |
|
| 18:12 |
[Wireshark-commits] master 131f8f0: Remove g_hash_table_contains from plugin_if |
Wireshark code review |
|
| 18:14 |
[Wireshark-commits] master b679e2a: wmem: convert tree key to void* |
Wireshark code review |
|
| 18:25 |
[Wireshark-commits] master fcbf1d2: File: Add BTSNOOP File Format support |
Wireshark code review |
|
| 18:25 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 18:31 |
[Wireshark-commits] master-1.12 6c23012: editcap: keep timestamp resolution when converting a nseclibpcap file to pcapng |
Wireshark code review |
|
| 18:42 |
[Wireshark-commits] master 7f57175: Bugfix parsing filters out of SRT tables with parameters. |
Wireshark code review |
|
| 18:43 |
[Wireshark-commits] master 8b6c4c3: Limit the text displayed for the Filter label in the SRT dialog so it doesn't push the table off of dialog. |
Wireshark code review |
|
| 18:52 |
[Wireshark-commits] master cb0ee64: cmake/add_lemon_files: depend on lemon and lempar |
Wireshark code review |
|
| 18:56 |
[Wireshark-commits] master 78e71f6: Remove the other g_hash_table_contains |
Wireshark code review |
|
| 18:58 |
[Wireshark-commits] wireshark-win32-libs rev 465: / /trunk/bin/: 7za.exe /trunk/packages/: FindProc.zip c-ares-1.7.1-win32ws.zip gnutls-2.12.18-1.2-win32ws.zip |
gerald |
|
| 18:58 |
[Wireshark-commits] master 419f672: Replace Folder.CopyHere with 7-Zip. |
Wireshark code review |
|
| 19:03 |
[Wireshark-commits] master 8a89ebb: cigi: if the packet is not cigi, just return |
Wireshark code review |
|
| 19:09 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 19:16 |
[Wireshark-commits] master f1bc598: Clean up 802.11 radio information handling. |
Wireshark code review |
|
| 19:25 |
[Wireshark-commits] master b18fbf4: Squelch a 64-bit-to-32-bit-narrowing warning. |
Wireshark code review |
|
| 19:49 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 20:04 |
[Wireshark-commits] master f613b92: Tell vagrant that it's a dev environment |
Wireshark code review |
|
| 20:14 |
[Wireshark-commits] master b0584ae: bootp: replace THROW() by an expert info |
Wireshark code review |
|
| 20:23 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 20:28 |
[Wireshark-commits] master 5bc3861: mergecap: check input files time precision before exporting to pcapng format |
Wireshark code review |
|
| 20:30 |
[Wireshark-commits] master 4b1f364: Basic vagrant readme |
Wireshark code review |
|
| 20:43 |
[Wireshark-commits] master 26dd5d2: Squelch a compiler warning. |
Wireshark code review |
|
| 20:43 |
[Wireshark-commits] master-1.12 8be4301: mergecap: check input files time precision before exporting to pcapng format |
Wireshark code review |
|
| 21:02 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 21:21 |
[Wireshark-commits] master 5265bc3: Make sure the byte view maintains visibility. |
Wireshark code review |
|
| 21:31 |
[Wireshark-commits] master a124424: CredSSP: update template after the API change done in gcdc7d25 |
Wireshark code review |
|
| 21:33 |
[Wireshark-commits] master cf537c1: If we don't have both frequency and channel, try to calculate the other. |
Wireshark code review |
|
| 21:36 |
[Wireshark-commits] master e31aef0: Regenerate *-tap-register.c when associated Makefile.common is updated (*nix) |
Wireshark code review |
|
| 21:45 |
[Wireshark-commits] master b89a485: Add Makefile_common.common to wireshark-tap-register.c dependencies (windows) |
Wireshark code review |
|
| 22:00 |
[Wireshark-commits] master 6122b4b: Qt: when a capture file is closed, go back to the welcome screen only if we're not capturing to multiple files |
Wireshark code review |
|
| 22:02 |
[Wireshark-commits] master acbbce9: Fix Windows CMake PortableApps dependencies |
Wireshark code review |
|
| 22:26 |
[Wireshark-commits] master d81ba67: wmem: bubble up key type change another function |
Wireshark code review |
|
| June 26, 2015 |
|---|
| 00:02 |
[Wireshark-commits] master dd16c55: editcap: allow command-line option to set comments for given frame numbers |
Wireshark code review |
|
| 00:21 |
[Wireshark-commits] master 8ad9019: Commit d4aa1a1c24e984339806c4ddb000ea9f9b352659 added some Q_UNUSED statements to c++ files. The standard method to mark function parameters as unused in cpp is to just leave out the variable name. |
Wireshark code review |
|
| 00:23 |
[Wireshark-commits] master 227f0af: Make autotools install optional. Reformat build and install instructions at the end a bit. |
Wireshark code review |
|
| 02:41 |
[Wireshark-commits] master 40649e3: ctdb: exit instead of throwing an exception |
Wireshark code review |
|
| 06:51 |
[Wireshark-commits] master 4975c06: Disabling GTK by default in the official source was not intentional (but maybe it should be). |
Wireshark code review |
|
| 06:53 |
[Wireshark-commits] master 8f40e2c: tools: permit setting BIN_DIR in the environment |
Wireshark code review |
|
| 08:47 |
[Wireshark-commits] master fe679bf: openSAFETY: Fix various heuristic bugs |
Wireshark code review |
|
| 08:49 |
[Wireshark-commits] master a7a7c68: epl: Set Payload to remaining bytes |
Wireshark code review |
|
| 15:43 |
[Wireshark-commits] master caf06fe: PDU export: increase time precision to nano seconds |
Wireshark code review |
|
| 15:50 |
[Wireshark-commits] master 29aecdf: RRC: remove non ASCII characters from ASN.1 description |
Wireshark code review |
|
| 17:00 |
[Wireshark-commits] master 304f902: PTP: just return, don't throw an exception |
Wireshark code review |
|
| 17:41 |
[Wireshark-commits] master 2c9a9af: Replace pinfo->fd->flags.visited calls by PINFO_FD_VISITED(pinfo) in documentation |
Wireshark code review |
|
| 17:42 |
[Wireshark-commits] master 51d2eef: Added option in h245 preferences to print h245 messages content into Information column in typical fashion (append) instead of just in reversed order (prepand) |
Wireshark code review |
|
| 17:42 |
[Wireshark-commits] master-1.12 efe77f6: GSM MAP: Fix decoding of IPv6 addresses |
Wireshark code review |
|
| 18:29 |
[Wireshark-commits] master 78adf17: Fix handling of 11ac radio metadata. |
Wireshark code review |
|
| 18:35 |
[Wireshark-commits] master 66c7388: wmem: convert string trees to single-layer |
Wireshark code review |
|
| 18:37 |
[Wireshark-commits] master 0953c36: Qt: tweaks to Capture Interfaces dialog |
Wireshark code review |
|
| 18:40 |
[Wireshark-commits] master b855a9f: wmem: permit lookups in NULL trees (oops) |
Wireshark code review |
|
| 19:03 |
[Wireshark-commits] master 5e6be95: Use "Present"/"Absent" for VHT presence flags. |
Wireshark code review |
|
| 19:15 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 19:32 |
[Wireshark-commits] master 0f42ed0: Squelch a compiler warning. |
Wireshark code review |
|
| 20:13 |
[Wireshark-commits] master b2a6dff: Clean up switch statement whitespace. |
Wireshark code review |
|
| 21:17 |
[Wireshark-commits] master 4ee22e8: Update valgrind script for the UI |
Wireshark code review |
|
| 21:28 |
[Wireshark-commits] master 5c438e1: Those aren't booleans, they're counts of streams. |
Wireshark code review |
|
| 21:58 |
[Wireshark-commits] master d6e5379: RTP: create conversation when using heuristic dissector |
Wireshark code review |
|
| June 27, 2015 |
|---|
| 02:25 |
[Wireshark-commits] master b401fb0: Use the PHY type in the radio information to recognize HT packets. |
Wireshark code review |
|
| 02:47 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 03:09 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 04:49 |
[Wireshark-commits] master ac9f64a: Handle a "should not happen" case, to squelch compiler warnings. |
Wireshark code review |
|
| 05:47 |
[Wireshark-commits] master f196061: (trivial) daap: remove if(tree) and return; at the end of a function |
Wireshark code review |
|
| 07:42 |
[Wireshark-commits] master 26a1ccb: Handle the VHT flavor of the HT Control field. |
Wireshark code review |
|
| 14:32 |
[Wireshark-commits] master b24a45c: Avoid some Visual Studio Code Anaylzer warnings |
Wireshark code review |
|
| 14:35 |
[Wireshark-commits] master 13df6e9: bacapp: cleanup and remove some add_text |
Wireshark code review |
|
| 16:25 |
[Wireshark-commits] master 48f7ce7: checkAPIs.pl: check how ui class files are included |
Wireshark code review |
|
| 16:26 |
[Wireshark-commits] master 40f330f: Free a malloc'ed error message to not leak memory |
Wireshark code review |
|
| 22:20 |
[Wireshark-commits] master 74a5f50: ipsec: correct some format specifiers |
Wireshark code review |
|
| 22:30 |
[Wireshark-commits] master 80efc53: Quick and dirty overflow checking. |
Wireshark code review |
|
| June 28, 2015 |
|---|
| 08:02 |
[Wireshark-commits] master 95dbae4: ISAKMP: consistently use two-space indentation (as per modelines). Also added one missing break |
Wireshark code review |
|
| 10:54 |
[Wireshark-commits] master d4bdbb9: 1.5.17 seems to be a typo. Change it to the probably intended 1.6.17 |
Wireshark code review |
|
| 12:21 |
[Wireshark-commits] master e4dc332: Set 802.11.ac Partial AID field size |
Wireshark code review |
|
| 15:08 |
[Wireshark-commits] master b09891d: [Automatic update for 2015-06-28] |
Wireshark code review |
|
| 15:12 |
[Wireshark-commits] master-1.12 4373198: [Automatic update for 2015-06-28] |
Wireshark code review |
|
| 15:59 |
[Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 8.1 x86 |
buildbot-no-reply |
|
| 16:23 |
[Wireshark-commits] master 7d7f6be: We only have the short preamble flag if we have a Flags field. |
Wireshark code review |
|
| 16:35 |
[Wireshark-commits] master ad18161: The two bits of NESS are numbers, not Booleans. |
Wireshark code review |
|
| 16:52 |
[Wireshark-commits] master 2762995: If we don't know whether STBC is being used, we don't know NSTS. |
Wireshark code review |
|
| 17:29 |
[Wireshark-commits] master 8aaf42d: If we don't know whether STBC is being used, we don't know NSTS. |
Wireshark code review |
|
| 17:51 |
[Wireshark-commits] master-1.12 c62601f: If we don't know whether STBC is being used, we don't know NSTS. |
Wireshark code review |
|
| 17:52 |
[Wireshark-commits] master-1.10 c10155f: If we don't know whether STBC is being used, we don't know NSTS. |
Wireshark code review |
|
| 17:55 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 19:44 |
[Wireshark-commits] master b9145bc: "Short preamble" is 802.11[bg]-only, so put it in the PHY-specifc info. |
Wireshark code review |
|
| June 29, 2015 |
|---|
| 02:11 |
[Wireshark-commits] master da09a1b: Take all epan_column_info members that always get allocated to "number of columns" to share their own data structure. |
Wireshark code review |
|
| 02:42 |
[Wireshark-commits] master 1141033: editcap: add new option (-a) to help |
Wireshark code review |
|
| 09:36 |
[Wireshark-commits] master 149d0b7: tools/asn2wrs.py: handle windows-1252 encoding |
Wireshark code review |
|
| 09:43 |
[Wireshark-commits] master 59d56bf: gtk: Fix use-after-free on removing recent file |
Wireshark code review |
|
| 12:42 |
[Wireshark-commits] master 60ef92b: [GSM DTAP] Add Sequence number for Non call related SS messages. |
Wireshark code review |
|
| 14:05 |
[Wireshark-commits] master 23ad9b3: [FIP] Use value_string_ext for fip_desc_types. |
Wireshark code review |
|
| 14:05 |
[Wireshark-commits] master df62a1b: [GSM DTAP]: fix indent (use 4 spaces) |
Wireshark code review |
|
| 17:07 |
[Wireshark-commits] master 5ae8c92: Try to fix NSIS packaging dependencies. |
Wireshark code review |
|
| 17:22 |
[Wireshark-commits] master 0b0100b: Fixup the packet list navigation action behavior. |
Wireshark code review |
|
| 17:53 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 18:15 |
[Wireshark-commits] master a6f9cf5: Don't free col_item->col_data. |
Wireshark code review |
|
| 22:47 |
[Wireshark-commits] master b1ab36a: tools/asn2wrs.py: fix isdn-sup generation with Py3 |
Wireshark code review |
|
| 22:48 |
[Wireshark-commits] master 305d983: capchild: fix uninitialized data pointer on failure |
Wireshark code review |
|
| 22:56 |
[Wireshark-commits] master a36db75: plugins/mate: fix some memleaks |
Wireshark code review |
|
| 22:58 |
[Wireshark-commits] master 1e511d8: ssl: test for file type before reading key file |
Wireshark code review |
|
| June 30, 2015 |
|---|
| 02:35 |
[Wireshark-commits] master 63a78d4: Use ws_fstat64() to determine the size of an open file. |
Wireshark code review |
|
| 03:23 |
[Wireshark-commits] master 2325550: Fix setting widget visibility when changing the layout. |
Wireshark code review |
|
| 04:44 |
[Wireshark-commits] master 74338f5: Set the PHY value when providing our own metadata structure. |
Wireshark code review |
|
| 19:59 |
[Wireshark-commits] master 98a7b1e: Put quotes into xcopy command and note that it might need privileges. |
Wireshark code review |
|
| 20:57 |
[Wireshark-commits] master 986e347: Disable overlay scrolling |
Wireshark code review |
|
