Wireshark-commits: [Wireshark-commits] master 0dffb17: Get rid of unnecessary stuff copied-and-past
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Jun 2015 04:03:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0dffb170956c7638cd76d9c96a322d591e71b7a6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0dffb17 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of unnecessary stuff copied-and-pasted from the radiotap dissector.
    
    What the dissector calls "radiotap" isn't even remotely like radiotap.
    It took some flags from radiotap, but that's it.
    
    Make the names of the flags in question match what's in the libwiretap
    code.  Get rid of everything not in the libwiretap code, and get rid of
    all code that does anything if those flags are set or that puts them
    into the protocol tree.
    
    This means that we don't do anything with the FCS or the Atheros
    padding; just call the "802.11 with no FCS" dissector.
    
    Change-Id: I4d3646d5d6c409b772985d0b05a86d5ee903157a
    Reviewed-on: https://code.wireshark.org/review/8973
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d83f86a   Get rid of some unused members of struct ieee_802_11_phdr.
    adds  0dffb17   Get rid of unnecessary stuff copied-and-pasted from the radiotap dissector.


Summary of changes:
 epan/dissectors/packet-ixveriwave.c |  150 ++++++-----------------------------
 1 file changed, 26 insertions(+), 124 deletions(-)