Wireshark-commits: [Wireshark-commits] master-1.12 7035c8d: Aruba ERM: Fix FCS for Type 1 (PEEK)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Jun 2015 17:34:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7035c8d82a31d7bee6da38afd236095e2f2c818b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

7035c8d by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Aruba ERM: Fix FCS for Type 1 (PEEK)
    
    Type 1 is Peek type (using Peek dissector)
    Peek dissector is also update for Cisco AP, Pass info to peek dissector it is "Aruba PEEK" (with buggy FCS)
    
    Add also check of signal value (when signal strength = 100%) it is a TX packet and there is no FCS
    
    Bug:11204
    
    Reviewed-on: https://code.wireshark.org/review/8710
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 7e2e8ef04c301bffd67958ed3d11d751ebd3e04c)
    
    Conflicts:
    	epan/dissectors/packet-peekremote.c
    
    Change-Id: I435e0e3275bc0a03fa534e49e86251114f568040
    Reviewed-on: https://code.wireshark.org/review/9094
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  181e560   Aruba ERM: Fix FCS for Type 3
    adds  7035c8d   Aruba ERM: Fix FCS for Type 1 (PEEK)


Summary of changes:
 epan/dissectors/packet-aruba-erm.c  |    5 ++++-
 epan/dissectors/packet-peekremote.c |   24 ++++++++++++++++++------
 2 files changed, 22 insertions(+), 7 deletions(-)