Wireshark-commits: [Wireshark-commits] master 2d863b9: Add TapParameterDialog.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 8 Jun 2015 19:51:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d863b9782f19e0821cacfbf6c7ab17fa1183317
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d863b9 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add TapParameterDialog.
    
    Split StatsTreeDialog into StatsTreeDialog and TapParameterDialog (its
    base class). This more closely matches the GTK+ UI and paves the way for
    more statistics dialogs.
    
    Change-Id: I2630385534e829d99724673ade372fcb33200d07
    Reviewed-on: https://code.wireshark.org/review/8842
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  2533889   Revert "NFSv4: Fix for Bug 10483"
    adds  2d863b9   Add TapParameterDialog.


Summary of changes:
 epan/stat_groups.h                                 |    6 +
 epan/stats_tree_priv.h                             |    1 -
 ui/qt/CMakeLists.txt                               |    4 +-
 ui/qt/Makefile.am                                  |    2 +-
 ui/qt/Makefile.common                              |    6 +-
 ui/qt/Wireshark.pro                                |    4 +-
 ui/qt/qt_ui_utils.cpp                              |    7 +
 ui/qt/qt_ui_utils.h                                |    9 +
 ui/qt/stats_tree_dialog.cpp                        |  200 ++++--------------
 ui/qt/stats_tree_dialog.h                          |   24 +--
 ui/qt/tap_parameter_dialog.cpp                     |  218 ++++++++++++++++++++
 ...{stats_tree_dialog.h => tap_parameter_dialog.h} |   49 ++---
 ...tats_tree_dialog.ui => tap_parameter_dialog.ui} |   10 +-
 13 files changed, 329 insertions(+), 211 deletions(-)
 create mode 100644 ui/qt/tap_parameter_dialog.cpp
 copy ui/qt/{stats_tree_dialog.h => tap_parameter_dialog.h} (63%)
 rename ui/qt/{stats_tree_dialog.ui => tap_parameter_dialog.ui} (92%)