Wireshark-commits: [Wireshark-commits] master 8abe108: ieee80211: fix memleak
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Jun 2015 21:48:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8abe108a3c942a10b58d58a1974cda49e10b2a43
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8abe108 by Peter Wu (peter@xxxxxxxxxxxxx):

    ieee80211: fix memleak
    
    parse_key_string reads from rec->string and rec->key (without
    modifying those parameters), then returns a newly allocated
    decryption_key_t struct which is not used except for reading the
    type field. Release memory after copying that single field!
    
    Change-Id: Iac19bea23dedb73cab9dd1ea09f98cc83556e96c
    Reviewed-on: https://code.wireshark.org/review/9025
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  11803d4   Remove more tvb_length
    adds  8abe108   ieee80211: fix memleak


Summary of changes:
 epan/dissectors/packet-ieee80211.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)