Wireshark · Wireshark-commits: [Wireshark-commits] master 3f5d183: Stop using atof/strtod (fixes column sorting of float types)

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3f5d183a44cada18eea7969fd8cc60f8e8781b26
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3f5d183 by Peter Wu (peter@xxxxxxxxxxxxx):

    Stop using atof/strtod (fixes column sorting of float types)
    
    atof is locale-dependent. In locales such as Swedish, German and Dutch,
    the dot is a thousand separator, resulting in wrong conversions for
    floats.
    
    While at it, make the mate dissector also be independent of locale.
    Blacklist atof in checkAPIs. Lemon is still using strtod, but that is
    not our problem for now.
    
    Bug: 11297
    Bug: 8964
    Change-Id: I6fe3e45eb1d6d95d41aa4f3af1f81a6204a60c63
    Reviewed-on: https://code.wireshark.org/review/9116
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fe6ece9   afp: replace all calls to THROW() and do proper error handling
    adds  3f5d183   Stop using atof/strtod (fixes column sorting of float types)


Summary of changes:
 epan/asn1.c                               |    2 +-
 epan/dissectors/packet-catapult-dct2000.c |    2 +-
 plugins/mate/mate_grammar.lemon           |    4 ++--
 tools/checkAPIs.pl                        |    1 +
 ui/gtk/hostlist_table.c                   |    4 ++--
 ui/gtk/packet_list_store.c                |    4 ++--
 6 files changed, 9 insertions(+), 8 deletions(-)