Wireshark-commits: [Wireshark-commits] master-1.12 181e560: Aruba ERM: Fix FCS for Type 3
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Jun 2015 17:33:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=181e560067270efe91fe8122b471185db7872ee8
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

181e560 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Aruba ERM: Fix FCS for Type 3
    
    Add a check of signal value (when signal strength = 100%) it is a TX packet and there is no FCS
    Only work for Type3 (no signal information on Type 0)
    
    For type 0, Always display the FCS
    
    Bug:11204
    Reviewed-on: https://code.wireshark.org/review/8569
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 8d46c411e9b29569e806586b175b4764443374b4)
    
    Conflicts:
    	epan/dissectors/packet-aruba-erm.c
    
    Change-Id: I837f8c01c0d0284ecb218b6b03fa9ac025fac5f2
    Reviewed-on: https://code.wireshark.org/review/9093
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  c7f3ea0   CFM: fix CFM Type Test signal (TST) without CRC dissection
    adds  181e560   Aruba ERM: Fix FCS for Type 3


Summary of changes:
 epan/dissectors/packet-aruba-erm.c |   23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)