Wireshark-commits: [Wireshark-commits] master 2895d58: Call the "802.11 radio information" dissecto
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Jun 2015 23:02:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2895d58dc38321a72c82e1bf77d165ef4acbc73a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2895d58 by Guy Harris (guy@xxxxxxxxxxxx):

    Call the "802.11 radio information" dissector for radio headers.
    
    Have dissectors of various forms of radio information headers in the
    packets fill in a struct ieee_802_11_phdr with radio information as
    appropriate, and call the "802.11 radio information" dissector rather
    than the raw 802.11 dissector.
    
    This means that the radio information can be found in a
    protocol-independent and encapsulation-independent form when you're
    looking at the packet; that information can be presented in a form
    somewhat easier to read than the raw metadata header format.
    
    It also enables having a single "radio information" tap that allows
    statistics to handle all different sorts of radio information
    encapsulation.
    
    In addition, it lets us clean up some of the arguments passed to the
    common 802.11 dissector routine, by having it pull that information from
    the struct ieee_802_11_phdr.
    
    Ensure that the right structure gets passed to that routine, and that
    all the appropriate parts of that structure are filled in.
    
    Rename the 802.11 radio protocol to "wlan_radio", rather than just
    "radio", as it's 802.11-specific.  Give all its fields "wlan_radio."
    names rather than "wlan." names.
    
    Change-Id: I78d79afece0ce0cf5fc17293c1e29596413b31c8
    Reviewed-on: https://code.wireshark.org/review/8992
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  77ed038   (trivial) fix a spelling mistake in a comment
    adds  2895d58   Call the "802.11 radio information" dissector for radio headers.


Summary of changes:
 epan/dissectors/packet-aruba-erm.c          |   75 ++++++-----
 epan/dissectors/packet-cisco-wids.c         |   15 ++-
 epan/dissectors/packet-ieee80211-airopeek.c |   19 ++-
 epan/dissectors/packet-ieee80211-netmon.c   |  142 ++++++++++++---------
 epan/dissectors/packet-ieee80211-radio.c    |  183 ++++++++++++++-------------
 epan/dissectors/packet-ieee80211-radiotap.c |   97 +++++++++++---
 epan/dissectors/packet-ieee80211.c          |  126 +++++++++---------
 epan/dissectors/packet-ixveriwave.c         |   29 ++++-
 epan/dissectors/packet-peekremote.c         |   63 +++++++--
 epan/dissectors/packet-ppi.c                |  122 ++++++++++++++----
 wiretap/commview.c                          |    4 +-
 wiretap/netmon.c                            |    3 +-
 wiretap/network_instruments.c               |   37 +++---
 wiretap/netxray.c                           |    1 +
 wiretap/pcap-common.c                       |    3 +-
 wiretap/peekclassic.c                       |    3 +-
 wiretap/peektagged.c                        |    1 +
 wiretap/snoop.c                             |    4 +-
 wiretap/wtap.h                              |    5 +-
 19 files changed, 597 insertions(+), 335 deletions(-)