Wireshark · Wireshark-commits: [Wireshark-commits] master f1bc598: Clean up 802.11 radio information handling.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f1bc598d87aeba56f2bd4a1151543664388bb8c7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f1bc598 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up 802.11 radio information handling.
    
    Have a field that holds the PHY type but nothing else.  Have
    a union with structures holding PHY-type-specific information, as a
    bunch of attributes are PHY-specific.
    
    If we have a channel and band, but don't have the frequency, attempt to
    calculate the frequency, and add that to the radio information if we
    succeed.  If we have the frequency, but don't have the channel, attempt
    to calculate the channel, and add that to the radio information if we
    succeed.
    
    Handle FHSS information, 11a "half/quarter-clocked" and turbo
    information, 11g normal vs. Super G, additional 11n and 11ac
    information, and the "short preamble" flag for 11b and 11g.
    
    Add a PHY type for 11 legacy DSSS and detect it if possible.
    
    Clean up the AVS dissector - make all fields wlancap. fields (if you
    want generic fields, use the wlan_radio. fields).
    
    Set more fields when writing out Commview Wi-Fi files.
    
    Change-Id: I691ac59f5e9e1a23779b56a65124049914b72e69
    Reviewed-on: https://code.wireshark.org/review/9146
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8a89ebb   cigi: if the packet is not cigi, just return
    adds  f1bc598   Clean up 802.11 radio information handling.


Summary of changes:
 epan/dissectors/packet-aruba-erm.c          |    4 +-
 epan/dissectors/packet-cisco-wids.c         |    1 +
 epan/dissectors/packet-ieee80211-airopeek.c |    1 +
 epan/dissectors/packet-ieee80211-netmon.c   |   51 +++-
 epan/dissectors/packet-ieee80211-prism.c    |    1 +
 epan/dissectors/packet-ieee80211-radio.c    |  300 ++++++++++++++++-----
 epan/dissectors/packet-ieee80211-radiotap.c |  222 +++++++++-------
 epan/dissectors/packet-ieee80211-wlancap.c  |  375 +++++++++++++++++----------
 epan/dissectors/packet-ixveriwave.c         |   33 ++-
 epan/dissectors/packet-peekremote.c         |   24 +-
 epan/dissectors/packet-ppi.c                |   63 +++--
 wiretap/commview.c                          |  135 ++++++++--
 wiretap/netmon.c                            |    1 +
 wiretap/network_instruments.c               |    1 +
 wiretap/netxray.c                           |    1 +
 wiretap/peekclassic.c                       |    1 +
 wiretap/peektagged.c                        |  127 +++++----
 wiretap/snoop.c                             |    1 +
 wiretap/wtap.h                              |  185 +++++++++----
 19 files changed, 1053 insertions(+), 474 deletions(-)