Wireshark · Wireshark-commits: [Wireshark-commits] master d9b36c4: Pass the 802.11 pseudo-header as an argument.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d9b36c46d025519a309bf34c1255e1f9a2856a41
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d9b36c4 by Guy Harris (guy@xxxxxxxxxxxx):

    Pass the 802.11 pseudo-header as an argument.
    
    Rather than accessing it through pinfo->pseudo_header, have it passed as
    an argument.
    
    This means we no longer tweak the pseudo-header filled in by libwiretap,
    but instead construct our own pseudo-header, which is a bit cleaner.
    
    It also opens up the possibility of other dissectors passing radio
    information down to the 802.11 dissector, so it can display it in a
    better-organized format than the raw metadata headers for
    radiotap/PPI/Prism/AVS/etc., and having some of the options for 802.11
    dissection (Atheros padding, Centrino stuff, etc.) also passed in
    through that pseudo-header so we have fewer arguments to
    dissect_ieee80211_common().
    
    Change-Id: I470300a0407ebf029c542f7ca5878593563a70a9
    Reviewed-on: https://code.wireshark.org/review/8980
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f00e6fb   1.99.7 → 1.99.8
    adds  d9b36c4   Pass the 802.11 pseudo-header as an argument.


Summary of changes:
 epan/dissectors/packet-ieee80211-radio.c    |    8 +--
 epan/dissectors/packet-ieee80211-radiotap.c |   37 ++++++++-----
 epan/dissectors/packet-ieee80211.c          |   80 ++++++++++++++++-----------
 epan/dissectors/packet-ppi.c                |   40 +++++++++++---
 4 files changed, 106 insertions(+), 59 deletions(-)