Wireshark-commits: [Wireshark-commits] master 3059601: [RTPproxy] Simplify positive reply parsing a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 4 Jun 2015 06:26:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=305960174de658510c81877bed01323bdb0b9dc6
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3059601 by Peter Lemenkov (lemenkov@xxxxxxxxx):

    [RTPproxy] Simplify positive reply parsing and minor cleanups
    
    * Merge both 'positive reply' and 'version ack' processing into one block.
    * Also use realsize where possible instead of recalculating packet's size
    again.
    * Add a bit more comments.
    * Remove some 'magic' numbers. Use actual string sizes instead.
    * Skip trailing zeroes inserted by some old SIP-servers.
    
    Change-Id: Ie66aa4d6e807a1f351b62d36333301fdec1550fa
    Signed-off-by: Peter Lemenkov <lemenkov@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/8738
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8ccf65b   Eliminate proto_tree_add_text from a few dissectors.
    adds  3059601   [RTPproxy] Simplify positive reply parsing and minor cleanups


Summary of changes:
 epan/dissectors/packet-rtpproxy.c |   47 ++++++++++++++++++++++++++-----------
 1 file changed, 33 insertions(+), 14 deletions(-)