Wireshark-commits: [Wireshark-commits] master cb84022: Qt: fix crashes when Wireshark is closed whi
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 25 Jun 2015 15:55:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb840222963f4986a831d5d6f9eb28d1d45083f6
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cb84022 by Martin Kaiser (wireshark@xxxxxxxxx):

    Qt: fix crashes when Wireshark is closed while running a capture
    
    if we haven't captured any packets yet, don't display a warning about
    unsaved changes
    
    make sure that we're not running into a scenario where
    MainWindow::testCaptureFileClose() tries to close the capture file at
    the same time as the pipe handler who sees an eof on the pipe
    
    cf_has_unsaved_data() should return false if we have a temporary file
    that contains no packets
    
    Change-Id: I18d75bd658b85d45dd3313d49e2cd654c6300de5
    Reviewed-on: https://code.wireshark.org/review/9109
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1810112   Add minimize and maximize buttons to the TCP stream dialogs.
    adds  cb84022   Qt: fix crashes when Wireshark is closed while running a capture


Summary of changes:
 file.c                |    2 +-
 ui/qt/main_window.cpp |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)