Wireshark-commits: [Wireshark-commits] master 5ab4570: gtk, qt: Fix minor buffer underrun
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Jun 2015 22:54:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ab45709d6137175e1f16651f7474876d6d3e758
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5ab4570 by Peter Wu (peter@xxxxxxxxxxxxx):

    gtk,qt: Fix minor buffer underrun
    
    Avoid accessing the first byte before an empty dirname. No idea why this
    was not triggered before. Reproduced with an empty Wireshark profile and
    wireshark and wireshark-qt.
    
    Caught with ASAN.
    
    Change-Id: I44f8fdab03ad0f24e663df63a1c54567996a3dfc
    Reviewed-on: https://code.wireshark.org/review/9037
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  1504531   packet: write explicit type for destroy_heuristic_dissector_list
    adds  5ab4570   gtk,qt: Fix minor buffer underrun


Summary of changes:
 ui/gtk/file_dlg.c               |    2 +-
 ui/qt/wireshark_application.cpp |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)