Wireshark-commits: [Wireshark-commits] master 78adf17: Fix handling of 11ac radio metadata.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 26 Jun 2015 18:29:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=78adf178505295765111caf1107f5d8c9d6ce8ea
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

78adf17 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of 11ac radio metadata.
    
    Add more fields to the metadata to handle everything radiotap has, and
    show them.
    
    Call the FEC type field just "FEC", and have it be an integer field with
    0 meaning BCC and 1 meaning LDPC, rather than a Boolean.
    
    11ac doesn't have *an* MCS, it can have up to 4, one per user.
    
    Label the 11ac bandwidth values the same way we do in the radiotap
    dissector.
    
    Change-Id: I2c2415baff3e5d68d49dda497980e8271d26b1f6
    Reviewed-on: https://code.wireshark.org/review/9176
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  51d2eef   Added option in h245 preferences to print h245 messages content into Information column in typical fashion (append) instead of just in reversed order (prepand)
    adds  78adf17   Fix handling of 11ac radio metadata.


Summary of changes:
 epan/dissectors/packet-ieee80211-radio.c    |  450 +++++++++++++++++++++------
 epan/dissectors/packet-ieee80211-radiotap.c |   24 +-
 epan/dissectors/packet-ixveriwave.c         |    2 -
 epan/dissectors/packet-peekremote.c         |    2 -
 wiretap/peektagged.c                        |   11 +-
 wiretap/wtap.h                              |   29 +-
 6 files changed, 399 insertions(+), 119 deletions(-)