Wireshark-commits: [Wireshark-commits] master 8aa91b3: Provide PHY type and band information in the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Jun 2015 22:05:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8aa91b31b90e6ba2ab7391c0395548a3901df9d0
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8aa91b3 by Guy Harris (guy@xxxxxxxxxxxx):

    Provide PHY type and band information in the 802.11 pseudo-header.
    
    Provide that information so that the "802.11 radio information" protocol
    can indicate whether a packet was 802.11 legacy/11b/11a/11g/11n/11ac,
    and possibly whether it's 2.4 GHz or 5 GHz 11n.  (Sometimes the center
    frequency might not be supplied, so the band information can be useful.)
    
    Also, provide some 11ac information, now that we can distinguish between
    11n and 11ac.  Don't calculate the data rate from the MCS index unless
    it's 11n; we don't yet have code to calculate it for 11ac.
    
    For radiotap, only provide guard interval information for 11n and 11ac,
    not for earlier standards.
    
    Handle the 11ac flag in the Peek remote protocol.
    
    For Peek tagged files, the "extension flags" are 11n/11ac flags, so we
    don't have to check for the "MCS used" bit in order to decide that the
    packet is 11n or 11ac or to decide whether to provide the "bandwidth" or
    "short GI" information.
    
    Change-Id: Ia8a1a9b11a35243ed84eb4e72c384cc77512b098
    Reviewed-on: https://code.wireshark.org/review/9032
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8abe108   ieee80211: fix memleak
    adds  8aa91b3   Provide PHY type and band information in the 802.11 pseudo-header.


Summary of changes:
 epan/dissectors/packet-ieee80211-netmon.c        |   24 ++
 epan/dissectors/packet-ieee80211-radio.c         |  117 +++++++---
 epan/dissectors/packet-ieee80211-radiotap-defs.h |   38 +++-
 epan/dissectors/packet-ieee80211-radiotap.c      |  256 +++++++++++++++++-----
 epan/dissectors/packet-ixveriwave.c              |   14 +-
 epan/dissectors/packet-peekremote.c              |   53 ++++-
 epan/dissectors/packet-ppi.c                     |   70 +++++-
 wiretap/commview.c                               |   48 ++++
 wiretap/network_instruments.c                    |    1 +
 wiretap/netxray.c                                |    5 +
 wiretap/peektagged.c                             |  221 +++++++++----------
 wiretap/wtap.h                                   |   82 +++++--
 12 files changed, 664 insertions(+), 265 deletions(-)