Wireshark-commits: [Wireshark-commits] master 2533889: Revert "NFSv4: Fix for Bug 10483"
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 8 Jun 2015 19:33:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2533889f3c0116d64f374eab5677876c5366d134
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2533889 by Cal Turney (cturney@xxxxxxxxxxx):

    Revert "NFSv4: Fix for Bug 10483"
    
    This reverts commit da1766e9871ba1eb4156ebd05c819eee9d91c10f.
    
    I should have set CR-2 because I was working on the following update: According to RFC 5661, a zero attribute mask is acceptable if type FATTR4_BITMAP_ONLY is passed to dissect_nfs4_fattrs(). In addition I found guint8 vars  'num_bitmaps', and 'count' are declared as guint8 but being passed into 32-bit fields of proto_tree_add_uint() and tvb_ensure_bytes_exist().I will push a new patch for review.
    
    Change-Id: I95e55af7fef17d0554f9741aa426feeeb95e2c21
    Reviewed-on: https://code.wireshark.org/review/8843
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  0f36b1c   aeron: fix infinite loop
    adds  2533889   Revert "NFSv4: Fix for Bug 10483"


Summary of changes:
 epan/dissectors/packet-nfs.c |    2 --
 1 file changed, 2 deletions(-)