Wireshark-commits: [Wireshark-commits] master ec3f923: Add the Display Filter Expression dialog.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 3 Jun 2015 02:27:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec3f923e3e693a3ca469bb7073a8c9ce2c33cb7d
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ec3f923 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Add the Display Filter Expression dialog.
    
    Changes from the GTK+ UI:
    - The display filter is built on the fly with immediate syntax feedback.
    - Slightly different layout.
    - You can search for fields.
    
    Make the plain SyntaxLineEdit a bit more plain.
    
    Bug: 11128
    Change-Id: I06a48cd7b9ba7b9dc193b0199540aede4eb62fa7
    Reviewed-on: https://code.wireshark.org/review/8742
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  32177ce   [RTPproxy] Set column name to RTPProxy-ng
    adds  ec3f923   Add the Display Filter Expression dialog.


Summary of changes:
 docbook/wsug_src/WSUG_chapter_work.asciidoc |    6 +-
 epan/range.c                                |    2 +-
 epan/range.h                                |   10 +-
 epan/tfs.h                                  |   10 +-
 ui/gtk/dfilter_expr_dlg.c                   |    3 +-
 ui/help_url.c                               |    3 +
 ui/help_url.h                               |    1 +
 ui/qt/CMakeLists.txt                        |    3 +
 ui/qt/Makefile.am                           |    2 +
 ui/qt/Makefile.common                       |    4 +
 ui/qt/Wireshark.pro                         |    3 +
 ui/qt/display_filter_edit.cpp               |  136 +++++----
 ui/qt/display_filter_expression_dialog.cpp  |  427 +++++++++++++++++++++++++++
 ui/qt/display_filter_expression_dialog.h    |   86 ++++++
 ui/qt/display_filter_expression_dialog.ui   |  242 +++++++++++++++
 ui/qt/main_window.cpp                       |    2 +-
 ui/qt/main_window.h                         |    1 +
 ui/qt/main_window.ui                        |   12 +
 ui/qt/main_window_slots.cpp                 |   20 +-
 ui/qt/qt_ui_utils.cpp                       |   12 +
 ui/qt/qt_ui_utils.h                         |   32 +-
 ui/qt/syntax_line_edit.cpp                  |   18 ++
 ui/qt/syntax_line_edit.h                    |    2 +
 23 files changed, 946 insertions(+), 91 deletions(-)
 create mode 100644 ui/qt/display_filter_expression_dialog.cpp
 create mode 100644 ui/qt/display_filter_expression_dialog.h
 create mode 100644 ui/qt/display_filter_expression_dialog.ui