Wireshark-commits: [Wireshark-commits] master 8f390d4: Refactor RTD stats.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Jun 2015 15:13:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f390d497577937dee7311f345b77c840ba42e15
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8f390d4 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Refactor RTD stats.
    
    Very similar to the refactoring of SRT stats, it provides more commonality of the stats for all GUI interfaces.  Currently implemented for TShark and GTK.  Affected dissectors: MEGACO, MGCP, Radius
    
    Change-Id: Icb73a7e603dc3502b39bf696227fcaae37d4ed21
    Reviewed-on: https://code.wireshark.org/review/8998
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8b230ea   Fix make distcheck buildbot
    adds  8f390d4   Refactor RTD stats.


Summary of changes:
 CMakeLists.txt                                  |    4 +-
 epan/CMakeLists.txt                             |    1 +
 epan/Makefile.common                            |    2 +
 epan/dissectors/packet-megaco.c                 |  212 ++++++++++++
 epan/dissectors/packet-mgcp.c                   |   99 ++++++
 epan/dissectors/packet-radius.c                 |  147 +++++++++
 epan/rtd_table.c                                |  205 ++++++++++++
 epan/rtd_table.h                                |  183 +++++++++++
 tshark.c                                        |    2 +
 ui/CMakeLists.txt                               |    1 -
 ui/Makefile.common                              |    2 -
 ui/cli/Makefile.common                          |    4 +-
 ui/cli/tap-megacostat.c                         |  163 ----------
 ui/cli/tap-mgcpstat.c                           |  248 --------------
 ui/cli/tap-radiusstat.c                         |  261 ---------------
 ui/cli/tap-rtd.c                                |  170 ++++++++++
 ui/cli/tshark-tap.h                             |    1 +
 ui/gtk/CMakeLists.txt                           |    4 +-
 ui/gtk/Makefile.common                          |    5 +-
 ui/gtk/main.c                                   |    2 +
 ui/gtk/megaco_stat.c                            |  240 --------------
 ui/gtk/mgcp_stat.c                              |  328 -------------------
 ui/gtk/radius_stat.c                            |  396 -----------------------
 ui/gtk/response_time_delay_table.c              |  392 ++++++++++++++++++++++
 globals.h => ui/gtk/response_time_delay_table.h |   42 +--
 ui/tap-megaco-common.c                          |  198 ------------
 ui/tap-megaco-common.h                          |  106 ------
 27 files changed, 1437 insertions(+), 1981 deletions(-)
 create mode 100644 epan/rtd_table.c
 create mode 100644 epan/rtd_table.h
 delete mode 100644 ui/cli/tap-megacostat.c
 delete mode 100644 ui/cli/tap-mgcpstat.c
 delete mode 100644 ui/cli/tap-radiusstat.c
 create mode 100644 ui/cli/tap-rtd.c
 delete mode 100644 ui/gtk/megaco_stat.c
 delete mode 100644 ui/gtk/mgcp_stat.c
 delete mode 100644 ui/gtk/radius_stat.c
 create mode 100644 ui/gtk/response_time_delay_table.c
 copy globals.h => ui/gtk/response_time_delay_table.h (59%)
 delete mode 100644 ui/tap-megaco-common.c
 delete mode 100644 ui/tap-megaco-common.h