Wireshark-commits: [Wireshark-commits] master 149d0b7: tools/asn2wrs.py: handle windows-1252 encodi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 29 Jun 2015 09:36:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=149d0b7e910f99f72a74e0c1a441f4db213cf3c1
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

149d0b7 by Peter Wu (peter@xxxxxxxxxxxxx):

    tools/asn2wrs.py: handle windows-1252 encoding
    
    The RRC ASN.1 definitions resulted in a decode error in Python because
    the file is encoded as windows-1252 instead of UTF-8. This patch makes
    the tool more forgiving in handling windows-1252 encodings.
    
    Tested with Python 2.6.9, 2.7.10, 3.4.3.
    
    Change-Id: I9c9269e1065c98b8bcfb57ab4bfd21d5e183a656
    Reviewed-on: https://code.wireshark.org/review/9133
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  1141033   editcap: add new option (-a) to help
    adds  149d0b7   tools/asn2wrs.py: handle windows-1252 encoding


Summary of changes:
 tools/asn2wrs.py |   15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)