Wireshark-commits: [Wireshark-commits] master 1e511d8: ssl: test for file type before reading key f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 29 Jun 2015 22:58:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1e511d830eac041815db3287934b6b84370b8f16
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1e511d8 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: test for file type before reading key file
    
    ftell() is undefined for directories. In practice, it will report
    0x7fffffffffffffff on an ext4 filesystem. Ensure that the given key file
    is not a directory.
    
    By the way, this is the only user of ftell that is affected.
    
    Bug: 11268
    Change-Id: Iaecd42c9b60da9e7945703a794601773749f2d97
    Reviewed-on: https://code.wireshark.org/review/9213
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  a36db75   plugins/mate: fix some memleaks
    adds  1e511d8   ssl: test for file type before reading key file


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    7 +++++++
 1 file changed, 7 insertions(+)