Wireshark · Wireshark-commits: [Wireshark-commits] master 60f33b6: Qt: fix a crash when closing application under Windows

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=60f33b658190ea4d016f3cb535199d15e14d2d87
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

60f33b6 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix a crash when closing application under Windows
    
    QCoreApplication visits eldritch horrors upon argv on Windows. Keep a
    local copy for our own processing.
    
    ---
    [ Pascal's original comments ]
    g6c4ec4a introduced the use of arg_list_utf_16to8 that triggers a crash on my
    computer when freeing the g_allocated memory.
    Let's do a similar work but with a memory allocator that does not trigger an exception.
    
    Also fix a memory leak in arg_list_utf_16to8 while we are at it.
    
    Change-Id: I93d899af20b09c9a5d584a46297f715591502df9
    Reviewed-on: https://code.wireshark.org/review/8961
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d5f1ae7   Asterix dissector support for category 021 v2.3
    adds  60f33b6   Qt: fix a crash when closing application under Windows


Summary of changes:
 wireshark-qt.cpp       |   22 ++++++++++++++--------
 wsutil/unicode-utils.c |    1 +
 2 files changed, 15 insertions(+), 8 deletions(-)