Wireshark-commits, October 2014
- [Wireshark-commits] master 214b127: GIF: add a missing hf registration,
Wireshark code review
- [Wireshark-commits] master 41ef2b0: idl2wrs (DCERPC): fix some warning,
Wireshark code review
- [Wireshark-commits] master 39c51be: LLDP: TIA Network Policy Unknown Policy Flag Decode is not correct,
Wireshark code review
- [Wireshark-commits] master 0ac441b: Dissect ext_capab and alt_mac_addr subelements of wifi display IE.,
Wireshark code review
- [Wireshark-commits] master 9506909: cmake: use pkg-config for resolving dependencies,
Wireshark code review
- [Wireshark-commits] master fa1d0be: cmake: update FindGTK2 to v3.0.1-1824-g0b12815,
Wireshark code review
- [Wireshark-commits] wireshark-win32-libs rev 455: / /trunk/packages/: gnutls-3.2.15-2.7-win32ws.zip /trunk/: README.txt,
pascal
- [Wireshark-commits] wireshark-win64-libs rev 409: / /trunk/packages/: gnutls-3.2.15-2.9-win64ws.zip /trunk/: README.txt,
pascal
- [Wireshark-commits] wireshark-win32-libs rev 456: /tags/2014-10-01/,
pascal
- [Wireshark-commits] wireshark-win64-libs rev 410: /tags/2014-10-01/,
pascal
- [Wireshark-commits] master-1.12 71e46f4: cmake: update FindGTK2 to v3.0.1-1824-g0b12815,
Wireshark code review
- [Wireshark-commits] master-1.12 c3aabc3: cmake: use pkg-config for resolving dependencies,
Wireshark code review
- [Wireshark-commits] master d65b7d5: Eliminate proto_tree_add_text from GSM_SMS dissector.,
Wireshark code review
- [Wireshark-commits] master f351a58: Update the release notes.,
Wireshark code review
- [Wireshark-commits] master 1318d4c: http: ignore response body for HEAD requests,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] master 2a2d75e: GSM SMS: follow-up of gd65b7d5,
Wireshark code review
- [Wireshark-commits] master afa8c02: Qt: Try to fix a Visual C++ encoding warning.,
Wireshark code review
- [Wireshark-commits] master b5aa0d2: Qt: Try to reduce the initialization time.,
Wireshark code review
- [Wireshark-commits] master 58cde5c: Add tests for the Qt UI.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] master 67f1fa5: Temporarily disable the Qt tests added in g58cde5c.,
Wireshark code review
- [Wireshark-commits] master 0efa992: Extend X11 response parsing,
Wireshark code review
- [Wireshark-commits] master abfa091: Some Release Notes cleanup.,
Wireshark code review
- [Wireshark-commits] master-1.12 51457f7: Some Release Notes cleanup.,
Wireshark code review
- [Wireshark-commits] master c0cdf94: Qt: Keep dialogs from blocking tests.,
Wireshark code review
- [Wireshark-commits] master 3555c06: Add dissection of IS-IS Router CAPABILITY TLV. Bug 10520.,
Wireshark code review
- [Wireshark-commits] master 5c8457e: Create field filters for gsm_rr_csn_flag() usages.,
Wireshark code review
- [Wireshark-commits] master 617b826: Upgrade GnuTLS 3.2.15 / Gcrypt 1.6.2 package,
Wireshark code review
- [Wireshark-commits] master-1.12 7529953: Upgrade GnuTLS 3.2.15 / Gcrypt 1.6.2 package,
Wireshark code review
- [Wireshark-commits] master 5262591: epl: FIX PDO_Mapping,
Wireshark code review
- [Wireshark-commits] master 043e6f0: Fix the release notes.,
Wireshark code review
- [Wireshark-commits] master 0299aa3: packet-nfs.c: (trivial) Add dropped/missing newline; Adjust some whitespace.,
Wireshark code review
- [Wireshark-commits] master 70abd39: Reformat hf[] entries; Add editor modelines & adjust whitespace.,
Wireshark code review
- [Wireshark-commits] master 482e8e5: Add editor modelines & adjust indentation/whitespace as needed.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] master ff7b51f: Partially re-enable Wireshark tests.,
Wireshark code review
- [Wireshark-commits] master 242a1e5: CMake: Don't assume we have a "cat" command.,
Wireshark code review
- [Wireshark-commits] master bdfff4d: Re-enable the Wireshark test suite.,
Wireshark code review
- [Wireshark-commits] master 6621b1f: Create field filters for gsm_rr_csn_HL_flag() usages.,
Wireshark code review
- [Wireshark-commits] master 956cfa2: LocationNumber digits is off by one(to many). Bug 10522.,
Wireshark code review
- [Wireshark-commits] master b15914f: packet-dcerpc-fileexp.c: Add editor modelines; reformat various (including hf[] entries).,
Wireshark code review
- [Wireshark-commits] master 451de17: packet-aim-messaging.c: Add editor modelines; reformat various (including hf[] entries).,
Wireshark code review
- [Wireshark-commits] master bb5daa6: Add editor modelines; Adjust whitespace as needed.,
Wireshark code review
- [Wireshark-commits] master 8b7d27c: WSDG: Update the Windows Qt download text.,
Wireshark code review
- [Wireshark-commits] master a6988b4: Fix memory leak and heap corruption on Windows.,
Wireshark code review
- [Wireshark-commits] master a7d6321: Use some macros to clean up the Snifer decompression code.,
Wireshark code review
- [Wireshark-commits] lts-1.2.11 2af3111: Don't free the hash if another one exists,
Wireshark code review
- [Wireshark-commits] master 06926ae: Wait for extcap to connect to pipe on Windows.,
Wireshark code review
- [Wireshark-commits] lts-1.2.11 64a2c93: ses: initialize pres_ctx_id in session struct,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 3ceb8b5: Don't free the hash if another one exists,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 49633a2: Fix an infinite loop when the line has no length,
Wireshark code review
- [Wireshark-commits] master 2079592: Update capture_opts in extcap_cleanup().,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] master ebfe8f6: Add editor modelines; Reformat as appropriate.,
Wireshark code review
- [Wireshark-commits] master f1ba16a: CP2179: Fix warning: no previous prototype for proto_register_cp2179 [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master ab6f954: DCERPC (butc): fix warning: no previous prototype for ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master bedad69: CEPH: Fix comma at end of enumerator list [-Wpedantic],
Wireshark code review
- [Wireshark-commits] master acc19b7: extcap: warning: no previous prototype for ‘extcap_free_arglist’ [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 75727dc: Qt (manage interface): fix warning: comma at end of enumerator list [-Wpedantic],
Wireshark code review
- [Wireshark-commits] master 6d44552: GTK (hostlist_table) warning: comma at end of enumerator list [-Wpedantic],
Wireshark code review
- [Wireshark-commits] master fa5b76f: GTK (hostlist_table) fix indent (use 4 spaces) and modelines info,
Wireshark code review
- [Wireshark-commits] master 3d7e5a6: Eliminate proto_tree_add_text from packet-gsm_a_bssmap.c,
Wireshark code review
- [Wireshark-commits] master 4d62642: RSVP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 8e17277: Juniper: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 973e09c: GSM-SMS: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 249d075: EPL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 5377dee: LLDP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master a13a2e6: DSR: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master e7dcf1b: Improve comments, and add some #defines, to make it clearer what the code does.,
Wireshark code review
- [Wireshark-commits] master e731bc7: Fix a comment.,
Wireshark code review
- [Wireshark-commits] master dbcd94d: DLT User: add ability to export PDUs,
Wireshark code review
- [Wireshark-commits] master 66d9ca3: [Automatic manuf, services and enterprise-numbers update for 2014-10-05],
Wireshark code review
- [Wireshark-commits] master-1.12 bfd34a0: [Automatic manuf, services and enterprise-numbers update for 2014-10-05],
Wireshark code review
- [Wireshark-commits] master-1.10 9cfdfdf: [Automatic manuf, services and enterprise-numbers update for 2014-10-05],
Wireshark code review
- [Wireshark-commits] master 560e06d: Read the record length in common code.,
Wireshark code review
- [Wireshark-commits] master 1e1d1de: packet-igap.c: Reformat hf[] entries; Add editor modelines.,
Wireshark code review
- [Wireshark-commits] master e2bdfa1: Reformat hfi entries; Add editor modelines; Adjust whitespace.,
Wireshark code review
- [Wireshark-commits] master 0b18d6c: Add editor modelines; Adjust whitespace as needed.,
Wireshark code review
- [Wireshark-commits] master ad6134b: docsis: Add editor modelines; Adjust whitespace; Remove boilerplate comments.,
Wireshark code review
- [Wireshark-commits] master 9e776a1: mpeg-pes: don't modify source and destination address colums,
Wireshark code review
- [Wireshark-commits] master 0111e46: plugins: Add editor modelines; Adjust whitespace as needed.,
Wireshark code review
- [Wireshark-commits] master 07698d5: Adjust some whitespace to match editor modelines.,
Wireshark code review
- [Wireshark-commits] master 0784451: Adjust some whitespace to match editor modelines.,
Wireshark code review
- [Wireshark-commits] master 9c1225f: Modify multicheck to accept parent parameter.,
Wireshark code review
- [Wireshark-commits] master 47de5a1: Expand dissection of 8.108 Presence Reporting Area Action.,
Wireshark code review
- [Wireshark-commits] master 9128e43: tcp: default no-subdissector-on-error to TRUE,
Wireshark code review
- [Wireshark-commits] master 4d93072: Dissect 3GPP AVP Presence-Reporting-Area-Elements-List.,
Wireshark code review
- [Wireshark-commits] master 97e6c59: packet-q931.c: Reformat hf[] entries; Convert apparent "4-space tabs" to spaces. Adjust editor modelines.,
Wireshark code review
- [Wireshark-commits] master 3af9e33: packet-hclnfsd.c: Reformat hf[] entries; Adjust some whitespace.,
Wireshark code review
- [Wireshark-commits] master 3377eca: packet-g723.c: Remove some boilerplate comments.,
Wireshark code review
- [Wireshark-commits] master 2005fc6: Convert (what appear to be) "4 space tabs"; Adjust editor-modelines; Do some minor reformatting.,
Wireshark code review
- [Wireshark-commits] master 2d6621a: Adjust editor modelines to match actual format of the file; Adjust some whiotespace.,
Wireshark code review
- [Wireshark-commits] master c822eea: packet-rpcap.c: Don't use mixed space/tab indentation;,
Wireshark code review
- [Wireshark-commits] master 24d50bc: Adjust indentation to match editor modelines; Do other minor whitespace changes.,
Wireshark code review
- [Wireshark-commits] master 5051ae1: Convert "4 space tabs" to spaces; Adjust editor modelines.,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 441cf84: rtsp: parse the correct token for the status code,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 2bbbc56: Fix the uninitialized-read error reported in bug 10370.,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 833afe3: ses: initialize pres_ctx_id in session struct,
Wireshark code review
- [Wireshark-commits] lts-1.8.2 dbdff35: Add some additional checks in SnifferDecompress().,
Wireshark code review
- [Wireshark-commits] master-1.12 457c4f9: LLDP: TIA Network Policy Unknown Policy Flag Decode is not correct,
Wireshark code review
- [Wireshark-commits] master 798eb97: Qt: Packet list column sorting.,
Wireshark code review
- [Wireshark-commits] master cf201b0: UI (simple_dialog): fix warning: redundant redeclaration of .. [-Wredundant-decls],
Wireshark code review
- [Wireshark-commits] master 25683ca: Qt: QVector::length was added in Qt 5.2.,
Wireshark code review
- [Wireshark-commits] master 02e902f: From 竹下 恵 (Megumi Takeshita),
Wireshark code review
- [Wireshark-commits] master b80d330: lupdate for Japanese,
Wireshark code review
- [Wireshark-commits] master 0644b34: after an lupdate, I should also do an lrelease to keep the .ts file and the .qm file in sync,
Wireshark code review
- [Wireshark-commits] master a17067a: Qt: Rename the "check for updates" slot.,
Wireshark code review
- [Wireshark-commits] master 6397ad4: Revert "Qt: Try to fix a Visual C++ encoding warning.",
Wireshark code review
- [Wireshark-commits] master 670ebda: Add some higher-level file-read APIs and use them.,
Wireshark code review
- [Wireshark-commits] master de13887: idl2wrs (DCERPC DRSUAPI): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 683d657: PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang Analyzer,
Wireshark code review
- [Wireshark-commits] master ffd48ce: Whitespace cleanups.,
Wireshark code review
- [Wireshark-commits] master 04bca65: [bacnet] update vendor list,
Wireshark code review
- [Wireshark-commits] master 3f101f2: Fix a comment, clean up some whitespace.,
Wireshark code review
- [Wireshark-commits] master 05d34b3: Clean up white space.,
Wireshark code review
- [Wireshark-commits] master 8439fd5: - Handle strings that have an opening but no closing quote,
Wireshark code review
- [Wireshark-commits] master 4611b8d: Make the code a bit more like the pre-API change code.,
Wireshark code review
- [Wireshark-commits] master 15e89ec: Dissect an SVHDX Open Device Context that appears as an Extra Create Parameter in a CREATE request. This helps understand HyperV over SMB 3.x stuff.,
Wireshark code review
- [Wireshark-commits] master a87659c: Build 1.99.0.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.99.0 created (now b2534b1),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-1.99.0 created (now 0e613c5),
Wireshark code review
- [Wireshark-commits] master acc09c2: ASN1: Added support for using #.REGISTER_NEW,
Wireshark code review
- [Wireshark-commits] master 9033f13: Revert "ASN1: Added support for using #.REGISTER_NEW",
Wireshark code review
- [Wireshark-commits] master d98debe: 1.99.0 → 1.99.1.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.99.1rc0 created (now 812cf10),
Wireshark code review
- [Wireshark-commits] master 71550ba: Make the code a bit more like the pre-new-APIs code.,
Wireshark code review
- [Wireshark-commits] master 47a1735: Add proper decoding for type field in OBEX headers,
Wireshark code review
- [Wireshark-commits] master d89cc1c: ASN1: Added support for using #.REGISTER_NEW,
Wireshark code review
- [Wireshark-commits] master 6831652: asn2wrs: Added support for #.SYNTAX_NEW,
Wireshark code review
- [Wireshark-commits] master 1280015: [iSCSI] Fix incorrect heuristic.,
Wireshark code review
- [Wireshark-commits] master-1.10 d38f510: [iSCSI] Fix incorrect heuristic.,
Wireshark code review
- [Wireshark-commits] master-1.12 eaccf31: [iSCSI] Fix incorrect heuristic.,
Wireshark code review
- [Wireshark-commits] master a9e6c2c: Overhaul the filterability of packet-ansi_683.c,
Wireshark code review
- [Wireshark-commits] master 43dffab: GSM (bssmap): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master cf4fc57: ANSI683: Fix mobile country code base,
Wireshark code review
- [Wireshark-commits] master 515f09f: [tools] add script to automatically generate bacnet vendors,
Wireshark code review
- [Wireshark-commits] master d6f217f: Close some memory leaks for bad K12 RF5 files.,
Wireshark code review
- [Wireshark-commits] master 5e0e4fa: Replace another file_read() call with wtap_read_bytes().,
Wireshark code review
- [Wireshark-commits] master a566f61: No need for WTAP_ERR_CANT_READ.,
Wireshark code review
- [Wireshark-commits] master d3e3cb2: Provide an error message for WTAP_ERR_CANT_WRITE.,
Wireshark code review
- [Wireshark-commits] master 65321df: Add support for LISP over TCP control messages,
Wireshark code review
- [Wireshark-commits] master f31836d: [bacnet] update vendors list, fix whitespace issues, all generated via script,
Wireshark code review
- [Wireshark-commits] master 41b8c6b: DCERPC DFS: Remove from Dirty PIDL list,
Wireshark code review
- [Wireshark-commits] master e881036: Fix extcap boolean flag handling.,
Wireshark code review
- [Wireshark-commits] master ceda0f9: Remove #pragma warning (MSVC) for PIDL generate dissector,
Wireshark code review
- [Wireshark-commits] master 6c41f50: Qt capture interfaces dialogue string tweaks,
Wireshark code review
- [Wireshark-commits] master 439c0b8: [tools] Add missing GPL license to generate-bacnet-vendors.py,
Wireshark code review
- [Wireshark-commits] master 57a7aca: elmi: Fix bug in message type coding,
Wireshark code review
- [Wireshark-commits] master 7207d2f: SIP Enhance dissecion of PATH,
Wireshark code review
- [Wireshark-commits] master fb6e043: DCERPC (DRSUAPI) Fix typo found on idl file,
Wireshark code review
- [Wireshark-commits] master 5c0a3be: Remove redundant and erroneous debug log message.,
Wireshark code review
- [Wireshark-commits] master 70ba2f8: Set err_info to null for errors that don't have an informaton string.,
Wireshark code review
- [Wireshark-commits] master c55d697: Try to speed up ping-dependent capture tests.,
Wireshark code review
- [Wireshark-commits] master 97e462d: "long" does not necessary mean "64-bit". Use G_GINT64_MODIFIER.,
Wireshark code review
- [Wireshark-commits] master 23286b7: ANSI 683: Removed unused assignments.,
Wireshark code review
- [Wireshark-commits] master ea5587a: Fix a comment.,
Wireshark code review
- [Wireshark-commits] master c303a2e: Make sure we don't dereference a null pointer.,
Wireshark code review
- [Wireshark-commits] master 21e844b: Use WTAP_ERR_BAD_FILE for malformed compressed data in DOS Sniffer files.,
Wireshark code review
- [Wireshark-commits] master a307ed6: Robopatch and remove #MISSING comments.,
Wireshark code review
- [Wireshark-commits] master dbf8024: No need to set *err_info if there's no error.,
Wireshark code review
- [Wireshark-commits] master c83169f: Only set err_info on an error, and use g_strdup_printf().,
Wireshark code review
- [Wireshark-commits] master 0066776: Fix --extcap-dlts call in extcap_example.py.,
Wireshark code review
- [Wireshark-commits] master d1ec1e8: Use WTAP_ERR_DECOMPRESS for decompression errors.,
Wireshark code review
- [Wireshark-commits] master 3ee8efd: Be less lazy about disabling a Visual C++ warning.,
Wireshark code review
- [Wireshark-commits] master e7e2f9c: Make the OPEN_INFO_ values members of an enum.,
Wireshark code review
- [Wireshark-commits] master 4edda1b: Lua: Improved TreeItem:add documentation.,
Wireshark code review
- [Wireshark-commits] master 1c51075: [BACnet][trivial] change strings as per Bug 9640,
Wireshark code review
- [Wireshark-commits] master 39b2814: Eliminate proto_tree_add_text from packet-nbns.c,
Wireshark code review
- [Wireshark-commits] master 608207f: Add Dissection of MA packets over UDP,
Wireshark code review
- [Wireshark-commits] master 58cc452: Eliminate proto_tree_add_text from packet-lmp.c,
Wireshark code review
- [Wireshark-commits] master e00ac05: CMake: Build an application bundle (Wireshark.app) on OS X.,
Wireshark code review
- [Wireshark-commits] master 40e6d76: GTPv2: fix an infinite loop,
Wireshark code review
- [Wireshark-commits] master 7690afb: Kerberos: remove debug logs when loading a keytab,
Wireshark code review
- [Wireshark-commits] master 112c90a: Kerberos: fix decryption of DCERPC with Kerberos encryption,
Wireshark code review
- [Wireshark-commits] master-1.12 fd57a29: Kerberos: fix decryption of DCERPC with Kerberos encryption,
Wireshark code review
- [Wireshark-commits] master 45e4629: Use an enum for the open-routine return value, as per Evan Huus's suggestion.,
Wireshark code review
- [Wireshark-commits] master bea24cf: CMake: Bundle our plugins.,
Wireshark code review
- [Wireshark-commits] master 5947291: Fix declared types of open routines.,
Wireshark code review
- [Wireshark-commits] master 9754192: Cast size_t to to gulong as the length argument to g_snprintf().,
Wireshark code review
- [Wireshark-commits] master 4f4e01b: Don't treat int return values as valid wtap_open_return_val values.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis,
buildbot-no-reply
- [Wireshark-commits] master 45f2afc: Oops, missed one.,
Wireshark code review
- [Wireshark-commits] master 33d20c6: Add back a value_string conversion lost in g58cc452.,
Wireshark code review
- [Wireshark-commits] master 3a4cab7: CMake: Bundle our libraries.,
Wireshark code review
- [Wireshark-commits] master f5b06c5: Fix some more int-to-enum conversion complaint.,
Wireshark code review
- [Wireshark-commits] master 7e49f06: wtap_file_read_till_separator() can return values other than 1 on success.,
Wireshark code review
- [Wireshark-commits] master bdbc8e3: GTPv2: Presence-Reporting-Area-Elements-List do full dissection of ECGI and TAI.,
Wireshark code review
- [Wireshark-commits] master 23e78cd: Add editor modelines; Adjust whitespace as needed.,
Wireshark code review
- [Wireshark-commits] master 98d77e2: CMake: Bundle the "share" directory files and directories.,
Wireshark code review
- [Wireshark-commits] master 6463d2a: GSM MAP: fix detection of SMS direction when application context version is < 3,
Wireshark code review
- [Wireshark-commits] master 685d303: Version 3 has only absolute timestamps; don't set nsg_creltime.,
Wireshark code review
- [Wireshark-commits] master a193302: NCP: switch to wmem memory and ensure that all fields are initialized,
Wireshark code review
- [Wireshark-commits] master a168c44: Remove (almost all) proto_tree_add_text calls in ISUP dissector.,
Wireshark code review
- [Wireshark-commits] master f7588ea: [ELMI] Add missing information elements, add support for sub-information elements. Bug 10532,
Wireshark code review
- [Wireshark-commits] master d330cd4: DNP3 Protocol Bugfix / Enhancement,
Wireshark code review
- [Wireshark-commits] master ffa377b: Use names more like the other names in open_info.,
Wireshark code review
- [Wireshark-commits] master-1.12 34d1616: Use names more like the other names in open_info.,
Wireshark code review
- [Wireshark-commits] master 5c5bf3b: Update READMEs to reflect recent CMake environment changes.,
Wireshark code review
- [Wireshark-commits] master 6e42a72: Dissection of sid28 needs null check.,
Wireshark code review
- [Wireshark-commits] master 81f9976: CMake: Don't add Custom.make to the bundle.,
Wireshark code review
- [Wireshark-commits] master e331083: Add dissection of MIDL_NDRHEADERBLOB used in drsuapi and some other protocols,
Wireshark code review
- [Wireshark-commits] master-1.12 a2b6e3c: Dissection of sid28 needs null check.,
Wireshark code review
- [Wireshark-commits] master 8eefa4d: Use the count-of-records fields to figure out how many records to read.,
Wireshark code review
- [Wireshark-commits] master eb72d2a: Use variable name 'len' when handling length.,
Wireshark code review
- [Wireshark-commits] master b3490c2: Use the wtap_read_bytes{_or_eof}() routines.,
Wireshark code review
- [Wireshark-commits] master 29afac2: Add support for NTTIME_hyper and NTTIME_1sec,
Wireshark code review
- [Wireshark-commits] master ed0b19b: Make boolean bitmask type 64-bit wide,
Wireshark code review
- [Wireshark-commits] master f7c5e3a: E-LMI: add what seems to be a missing break (Coverity CID 1245648),
Wireshark code review
- [Wireshark-commits] master 6e3a2b4: [Automatic manuf, services and enterprise-numbers update for 2014-10-12],
Wireshark code review
- [Wireshark-commits] master-1.12 5627936: [Automatic manuf, services and enterprise-numbers update for 2014-10-12],
Wireshark code review
- [Wireshark-commits] master-1.10 1d85e52: [Automatic manuf, services and enterprise-numbers update for 2014-10-12],
Wireshark code review
- [Wireshark-commits] master 1b65cb6: Add back get_uinteger for boolean_type.,
Wireshark code review
- [Wireshark-commits] master 44208b9: LMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 148136c: ISUP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master d62b323: PIDL (DCERPC misc): enhance dissector,
Wireshark code review
- [Wireshark-commits] master 4e328e4: DCERPC: Remove DIRTY_PIDL_DISSECTOR_SRC,
Wireshark code review
- [Wireshark-commits] master 1b8b2a8: Add editor modelines; Adjust whitespace as needed.,
Wireshark code review
- [Wireshark-commits] master fc2f318: Fix handling of extcap boolflags which defaults to true.,
Wireshark code review
- [Wireshark-commits] master eed22ac: Fix double free.,
Wireshark code review
- [Wireshark-commits] master 38c9ac8: GlusterFS: fix OSX compilation failure,
Wireshark code review
- [Wireshark-commits] master 73613d4: Remove DIRTY_DISSECTOR_SRC,
Wireshark code review
- [Wireshark-commits] master 5518513: IPv6 RPL: Display RPL flag on HEX,
Wireshark code review
- [Wireshark-commits] master b563a84: Eliminate proto_tree_add_text from IP dissectors,
Wireshark code review
- [Wireshark-commits] master 8d0becd: Aliging PIM hello message type to IANA in order to fix BUG 10231,
Wireshark code review
- [Wireshark-commits] master 8cc7b0d: Fixed missing padding. Fixed ENC_NA/ENC_BIG_ENDIAN errors.,
Wireshark code review
- [Wireshark-commits] wireshark-win64-libs rev 411: / /trunk/packages/: gtk+-bundle_2.24.23-1.1_win64ws.zip gtk+-bundle_2.24.23-3.39_win64ws.zip /trunk/: README.txt,
pascal
- [Wireshark-commits] master 749832a: USB Mass Storage: Display target number for SCM USB-SCSI converters,
Wireshark code review
- [Wireshark-commits] master 94d3548: SPDY: Fix typo about length for Control bit,
Wireshark code review
- [Wireshark-commits] master 4e1b5ea: ASN1: Register PDU-dissectors as NEW,
Wireshark code review
- [Wireshark-commits] master 313c400: P1: Added ORAddress and ORName syntax.,
Wireshark code review
- [Wireshark-commits] master 71ae57e: IPv6: Fix typo for Fragment nxt (Next Header),
Wireshark code review
- [Wireshark-commits] master ebbe70b: ASN1: Register BER syntaxes as NEW,
Wireshark code review
- [Wireshark-commits] master 2c23c7e: SPDY: Fix the display of COL_INFO...,
Wireshark code review
- [Wireshark-commits] master 017fc82: SPDY: Fix bitmask for priority bit,
Wireshark code review
- [Wireshark-commits] master-1.12 dc84ff1: SPDY: Fix the display of COL_INFO...,
Wireshark code review
- [Wireshark-commits] master-1.12 1ddbdf4: SPDY: Fix typo about length for Control bit,
Wireshark code review
- [Wireshark-commits] master-1.12 fafe1f3: SPDY: Fix bitmask for priority bit,
Wireshark code review
- [Wireshark-commits] master e8a63a5: SPDY: Add Slot field for SYN_STREAM (and also unused field...),
Wireshark code review
- [Wireshark-commits] master b3ad51d: Follow-up of ged0b19b (Make boolean bitmask type 64-bit wide),
Wireshark code review
- [Wireshark-commits] master c4acc4b: extcap (GTK): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master a9497be: RoCE and CM dissector fixes,
Wireshark code review
- [Wireshark-commits] master 24b6a11: IPv6 RPL option is read as less bytes than it is,
Wireshark code review
- [Wireshark-commits] master 748e522: ROS: Return dissected length from call_ros_oid_callback,
Wireshark code review
- [Wireshark-commits] master 4f37f55: RTSE: Return dissected length from call_rtse_oid_callback,
Wireshark code review
- [Wireshark-commits] master 8fb74b4: extcap: remove use of g_list_free_full,
Wireshark code review
- [Wireshark-commits] master b9988e2: ncp2222: don't overflow buffer constructing string,
Wireshark code review
- [Wireshark-commits] master-1.12 6fa8338: ncp2222: don't overflow buffer constructing string,
Wireshark code review
- [Wireshark-commits] master-1.10 146cff5: ncp2222: don't overflow buffer constructing string,
Wireshark code review
- [Wireshark-commits] master 631834f: IPv6: use proto_tree_add_item for IPv6 Routing Header Next and Length,
Wireshark code review
- [Wireshark-commits] wireshark-win64-libs rev 412: / /trunk/packages/: kfw-3-2-2-x64-ws.zip /trunk/: README.txt,
pascal
- [Wireshark-commits] wireshark-win64-libs rev 413: /tags/2014-10-13/,
pascal
- [Wireshark-commits] master 9ce5ca5: extcap: Catch unknown arguments to fix spaces,
Wireshark code review
- [Wireshark-commits] master b653564: Lua: luaL_checkstring does not return NULL,
Wireshark code review
- [Wireshark-commits] master 63faad6: NCP: add a missing cast following g6ca40c5,
Wireshark code review
- [Wireshark-commits] master-1.12 4607945: NCP: add a missing cast following g6ca40c5,
Wireshark code review
- [Wireshark-commits] master-1.10 f8abafe: NCP: add a missing cast following g6ca40c5,
Wireshark code review
- [Wireshark-commits] master 6a9479e: Add editor modelines and/or adjust whilespace.,
Wireshark code review
- [Wireshark-commits] master ab7f9aa: BER: Code cleanup in call functions,
Wireshark code review
- [Wireshark-commits] master 74c4358: Split ws80211_get_phys callback handler,
Wireshark code review
- [Wireshark-commits] master 05a6615: extcap: Remove single-space argument for boolflags,
Wireshark code review
- [Wireshark-commits] master 1f48125: Upgrade Win64 GTK2 package to 2.24.23-3.39,
Wireshark code review
- [Wireshark-commits] master 89a95f2: Add Kerberos 3.2.2 package for Win64,
Wireshark code review
- [Wireshark-commits] master 15f23c7: smartcard descriptor: the lcd layout is two bytes long,
Wireshark code review
- [Wireshark-commits] master-1.12 0b34b42: smartcard descriptor: the lcd layout is two bytes long,
Wireshark code review
- [Wireshark-commits] master 9dd515c: smartcard descriptor: dissect number of lines, characters per line in the lcd layout,
Wireshark code review
- [Wireshark-commits] master 8342eb8: smartcard descriptor: bitmask for pin support field,
Wireshark code review
- [Wireshark-commits] master fb27a68: NCP: cast to guint instead of gulong,
Wireshark code review
- [Wireshark-commits] master 03bc68c: fix forward declarations in opcua_serviceparser.h,
Wireshark code review
- [Wireshark-commits] master ea11378: Adding GigEVision GVSP dissector,
Wireshark code review
- [Wireshark-commits] master 96a1bf0: NSIS: Wireshark GTK is Wireshark legacy (and no Wireshark 1...) !,
Wireshark code review
- [Wireshark-commits] master-1.12 df932b4: NCP: cast to guint instead of gulong,
Wireshark code review
- [Wireshark-commits] master-1.10 7954467: NCP: cast to guint instead of gulong,
Wireshark code review
- [Wireshark-commits] master 0149015: packet-gvsp.c: Fix license; Remove unneeded code from proto_reg_handoff..(); adjust whitespace.,
Wireshark code review
- [Wireshark-commits] master fa6e907: Initial version of support for Colasoft Capsa files.,
Wireshark code review
- [Wireshark-commits] master 4495753: Get rid of out-of-date comment.,
Wireshark code review
- [Wireshark-commits] master a5d35a2: Clean up comment.,
Wireshark code review
- [Wireshark-commits] master 7d28a56: Squelch a compiler warning.,
Wireshark code review
- [Wireshark-commits] master abd657f: Squelch another warning.,
Wireshark code review
- [Wireshark-commits] master e70db8e: And another warning.,
Wireshark code review
- [Wireshark-commits] master 9cba3b6: packet-gvsp.c: sort pixeltypenames[] for extended value-string use.,
Wireshark code review
- [Wireshark-commits] master 0cbaae4: Fix return values.,
Wireshark code review
- [Wireshark-commits] master 0e2f128: Add new Event-Trigger values.,
Wireshark code review
- [Wireshark-commits] master 3ec9ddc: PIM: Disable unused pimbdirdfvals.,
Wireshark code review
- [Wireshark-commits] master 2359e67: GTPv2 Dissect more bits in IE Indication.,
Wireshark code review
- [Wireshark-commits] master 10b83e6: Add editor-modelines; adjust whitespace.,
Wireshark code review
- [Wireshark-commits] master 87ea03b: packet-gvsp.c: removed an unused #define,
Wireshark code review
- [Wireshark-commits] master a18c9c5: Don't supply time stamps for Capsa packets for now.,
Wireshark code review
- [Wireshark-commits] master 74a8ad7: Get rid of no-longer-used #define.,
Wireshark code review
- [Wireshark-commits] master 0ce5b8c: Add RakNet protocol dissector,
Wireshark code review
- [Wireshark-commits] master 71c5ac0: packet-assa_r3.c: Use editor modelines from http://www.wireshark.org/tools/modelines.html,
Wireshark code review
- [Wireshark-commits] master bfe3706: Always put editor-modelines at the end of the file ...,
Wireshark code review
- [Wireshark-commits] master 4a6e313: Don't log warnings if no block-type handlers are registered.,
Wireshark code review
- [Wireshark-commits] master-1.12 d5af678: Don't log warnings if no block-type handlers are registered.,
Wireshark code review
- [Wireshark-commits] master 4420461: Don't assume pcap_read_block() returns the number of bytes read.,
Wireshark code review
- [Wireshark-commits] master 0ac9449: We can't check the length of an SHB until we determine the byte order.,
Wireshark code review
- [Wireshark-commits] master-1.12 9697999: We can't check the length of an SHB until we determine the byte order.,
Wireshark code review
- [Wireshark-commits] master 60e738c: packet-raknet.c: value_string array (created at runtime) must be terminated with {0, NULL}.,
Wireshark code review
- [Wireshark-commits] master 6206fa5: raknet: fix two checkfiltername errors; mcpe,raknet: minor cleanup;,
Wireshark code review
- [Wireshark-commits] master bf5b872: CMake: When creating a bundle add convenience symlinks.,
Wireshark code review
- [Wireshark-commits] master a25ae55: LDAP: Improved a if-check to avoid a analyzis warning.,
Wireshark code review
- [Wireshark-commits] master 1a652bd: GTPv2: Fully dissect Presence Reporting Area Action.,
Wireshark code review
- [Wireshark-commits] [wireshark] reference refs/changes/56/2956 created (now 24d600b),
Wireshark code review
- [Wireshark-commits] master 38ffca5: WSUG: Fixed some typos.,
Wireshark code review
- [Wireshark-commits] master 5cdb032: smb2: fully initialize dummy session,
Wireshark code review
- [Wireshark-commits] master-1.12 d07c65d: smb2: fully initialize dummy session,
Wireshark code review
- [Wireshark-commits] master 0444c47: IPv6: Calipso option length is not used properly,
Wireshark code review
- [Wireshark-commits] master 9b7ee18: Typos in source code and in README.qt,
Wireshark code review
- [Wireshark-commits] master 371e4ae: Eliminate some proto_tree_add_text from GSM dissectors (so now there are no dissectors with 100+ proto_tree_add_text calls).,
Wireshark code review
- [Wireshark-commits] master-1.12 e7862f4: IPv6: Calipso option length is not used properly,
Wireshark code review
- [Wireshark-commits] master f518089: Clean up the read routines.,
Wireshark code review
- [Wireshark-commits] master 7bca912: Don't allocate the interfaces array until we've read the SHB.,
Wireshark code review
- [Wireshark-commits] master-1.12 be26f8e: Don't allocate the interfaces array until we've read the SHB.,
Wireshark code review
- [Wireshark-commits] master-1.10 1a7884e: Don't allocate the interfaces array until we've read the SHB.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] master-1.10 7605675: It was called "interface_data" in 1.10.,
Wireshark code review
- [Wireshark-commits] master fa8d236: Get rid of another unused variable.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] master 9cfab55: The record offset block begins with a 1-byte(!) header.,
Wireshark code review
- [Wireshark-commits] master df83895: Make sure *err and *err_info are set when returning PCAPNG_BLOCK_NOT_SHB.,
Wireshark code review
- [Wireshark-commits] master 377a486: Get rid of some set-but-no-longer-used variables.,
Wireshark code review
- [Wireshark-commits] master c74cefb: Fix a debugging printout.,
Wireshark code review
- [Wireshark-commits] master d347b72: Don't try to compute time stamps for files from Packet Builder.,
Wireshark code review
- [Wireshark-commits] master a34b252: Replace proto_tree_add_text with proto_tree_add_subtree(_format) in generated files,
Wireshark code review
- [Wireshark-commits] master 14b75d8: ETSI CAT: fix a typo and remove deprecated API call,
Wireshark code review
- [Wireshark-commits] master 381966b: Replace proto_tree_add_text in non-generated files,
Wireshark code review
- [Wireshark-commits] master 353f625: Fix issues in some ARM compilers, due to char being unsigned?,
Wireshark code review
- [Wireshark-commits] master-1.12 f773e82: Fix issues in some ARM compilers, due to char being unsigned?,
Wireshark code review
- [Wireshark-commits] master-1.10 18c5a32: Fix issues in some ARM compilers, due to char being unsigned?,
Wireshark code review
- [Wireshark-commits] master 50add40: Fix some more "char is unsigned" issues, and a possible "char is signed" one.,
Wireshark code review
- [Wireshark-commits] master-1.12 2a8216a: Fix some more "char is unsigned" issues, and a possible "char is signed" one.,
Wireshark code review
- [Wireshark-commits] master 0db468e: gchar is not guaranteed to be signed; use gint8.,
Wireshark code review
- [Wireshark-commits] master-1.12 1e09b78: gchar is not guaranteed to be signed; use gint8.,
Wireshark code review
- [Wireshark-commits] master-1.10 6596e08: gchar is not guaranteed to be signed; use gint8.,
Wireshark code review
- [Wireshark-commits] master 7f74471: Added italian translation to qt.,
Wireshark code review
- [Wireshark-commits] master f6bc6f9: Better fix - just check that the upper and lower nibbles are >= 0xA.,
Wireshark code review
- [Wireshark-commits] master-1.12 23b92bb: Better fix - just check that the upper and lower nibbles are >= 0xA.,
Wireshark code review
- [Wireshark-commits] master-1.10 e511ed4: Better fix - just check that the upper and lower nibbles are >= 0xA.,
Wireshark code review
- [Wireshark-commits] master 71a42e0: Oops, I missed one "cast a char to int and use it as a subscript" case.,
Wireshark code review
- [Wireshark-commits] master-1.12 b8bb518: Oops, I missed one "cast a char to int and use it as a subscript" case.,
Wireshark code review
- [Wireshark-commits] master b641832: GTPv2 in Complete Request Message call the NAS dissector with a tvb only containing the IE not the rest of the tvb.,
Wireshark code review
- [Wireshark-commits] master ee56b72: smartcard descriptor: start a bitfield for the features,
Wireshark code review
- [Wireshark-commits] master aa1f2c5: use supported/unsupported for the bitfield elements order them from MSB to LSB,
Wireshark code review
- [Wireshark-commits] master a517d50: Make sort_alphabet() not fail too badly with characters in [128, 255].,
Wireshark code review
- [Wireshark-commits] master-1.12 d956cd2: Make sort_alphabet() not fail too badly with characters in [128, 255].,
Wireshark code review
- [Wireshark-commits] master-1.10 1916b57: Make sort_alphabet() not fail too badly with characters in [128, 255].,
Wireshark code review
- [Wireshark-commits] master f249589: Just have get_mac_lte_rapid_description() return the description string.,
Wireshark code review
- [Wireshark-commits] master e6fcff1: Use g_ascii_isalnum() rather than isalnum().,
Wireshark code review
- [Wireshark-commits] master-1.12 f2859a5: Use g_ascii_isalnum() rather than isalnum().,
Wireshark code review
- [Wireshark-commits] master-1.10 9aed0cf: Use g_ascii_isalnum() rather than isalnum().,
Wireshark code review
- [Wireshark-commits] master 359a32f: No need for our own wrappers around tolower() and toupper().,
Wireshark code review
- [Wireshark-commits] master 0d9b449: Don't use <ctype.h> macros.,
Wireshark code review
- [Wireshark-commits] master 762b8d7: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.12 50c1519: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master 25d9a7b: Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master-1.12 b274370: Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master-1.10 6e40d58: Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master 44d4339: Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master-1.12 ccae7e4: Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master 23b233d: Remove unnecessary include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master 63ab36b: Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master-1.12 24fa893: Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master-1.10 2b6e946: Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master f90d8dc: Use g_ascii_isspace() instead of isascii() && isspace().,
Wireshark code review
- [Wireshark-commits] master 87545f3: Remove unnecessary includes of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master 4416988: Eliminate include of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master 9d1afef: isdigit -> g_ascii_isdigit to make the build work.,
Wireshark code review
- [Wireshark-commits] master 0ceedde: Dissect CDMA2000 PDU if GCSNA dissector exists.,
Wireshark code review
- [Wireshark-commits] master-1.12 080f11f: GSM MAP: fix detection of SMS direction when application context version is < 3,
Wireshark code review
- [Wireshark-commits] master-1.10 9ffacc6: GSM MAP: fix detection of SMS direction when application context version is < 3,
Wireshark code review
- [Wireshark-commits] master e5bbfa0: Add argument 'packet_info *pinfo' to all dissecting functions,
Wireshark code review
- [Wireshark-commits] master 17a1a0d: SGsAP Update to V12.6.0 except for IE TMSI based NRI container.,
Wireshark code review
- [Wireshark-commits] master 35a9b98: Use proto_tree_add_bitmask for ExpandedNodeId EncodingMask,
Wireshark code review
- [Wireshark-commits] master-1.12 d23160a: isdigit -> g_ascii_isdigit to handle 8-bit bytes correctly.,
Wireshark code review
- [Wireshark-commits] master-1.10 612491b: isdigit -> g_ascii_isdigit to handle 8-bit bytes correctly.,
Wireshark code review
- [Wireshark-commits] master 5bfde7c: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.12 2f585cf: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.10 988cb32: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.10 e638689: Some replacement of ctype.h routines missed by the previous commit.,
Wireshark code review
- [Wireshark-commits] master-1.10 12738a5: Fix potential invalid-reads in catapult files,
Wireshark code review
- [Wireshark-commits] master 36e4e6f: Get rid of unused includes of <ctype.h>.,
Wireshark code review
- [Wireshark-commits] master 5fc398c: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.12 65f8104: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.10 5dbd5cf: isprint() -> g_ascii_isprint(),
Wireshark code review
- [Wireshark-commits] master e304f6d: Get rid of unnecessary includes of ctype.h.,
Wireshark code review
- [Wireshark-commits] master-1.10 91b016e: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master 214a78c: Get rid of unnecessary include of ctype.h.,
Wireshark code review
- [Wireshark-commits] master 344c2bb: strptime.c needs ctype.h.,
Wireshark code review
- [Wireshark-commits] master 033f096: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.12 4723d80: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.10 1b608a5: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master 19b7819: Get rid of unnecessary includes of ctype.h.,
Wireshark code review
- [Wireshark-commits] master a91799e: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.12 a82c849: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.10 0757e61: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master e3477bd: Get rid of some no-longer-necessary casts.,
Wireshark code review
- [Wireshark-commits] master-1.12 a635986: Get rid of some no-longer-necessary casts.,
Wireshark code review
- [Wireshark-commits] master-1.10 f54a230: Get rid of some no-longer-necessary casts.,
Wireshark code review
- [Wireshark-commits] master 9f2a878: Get rid of unnecessary includes of ctype.h.,
Wireshark code review
- [Wireshark-commits] master 1de3a5b: Check for printable ASCII in an ENBName.,
Wireshark code review
- [Wireshark-commits] master-1.12 c734c57: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.10 61c4acc: Don't use ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master 77acaa1: Get rid of unnecessary includes of ctype.h.,
Wireshark code review
- [Wireshark-commits] master-1.10 810ed9b: More replacement of ctype.h functions.,
Wireshark code review
- [Wireshark-commits] master ed676ca: Commit 54b733ce9a0d1cd4ab9b142479368a5e696360be broke compilation of echld by removing TS_PREC_AUTO_USEC. Replace its use by TS_PREC_AUTO. No idea whether that's correct but it compiles again. Trying to commit this brought complaints by checkapi, so fixed them as well.,
Wireshark code review
- [Wireshark-commits] master 01cf7fe: Add URL to a description of the attributes Add comments about additional attributes,
Wireshark code review
- [Wireshark-commits] master 975b02f: Converted numerous proto_tree_add_none_format() calls for bitmask/flag items to proto_tree_add_bitmask(). Correctly set the length of LBT-RM and LBT-RU header blocks. Various other cosmetic cleanups.,
Wireshark code review
- [Wireshark-commits] master 85e7c15: Use proto_tree_add_expert_format instead of proto_tree_add_text,
Wireshark code review
- [Wireshark-commits] master 27e4ac8: Add support for split wiphy dump to Wireless Toolbar,
Wireshark code review
- [Wireshark-commits] master 8d6fd8d: GSM(_a_rr): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 31c119f: MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field,
Wireshark code review
- [Wireshark-commits] master 8a10f77: MIPv6: Mobility Option Binding Authorization Data for FMIPv6 Authenticator field is read beyond the option data,
Wireshark code review
- [Wireshark-commits] master 51f4962: MIPv6: Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data,
Wireshark code review
- [Wireshark-commits] master e7b07ae: IPv6: QuickStart option Nonce is read incorrectly,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test,
buildbot-no-reply
- [Wireshark-commits] master 147e7fe: Lua: Added ProtoField.none,
Wireshark code review
- [Wireshark-commits] master 283f478: Eliminate proto_tree_add_text from packet-igrp.c,
Wireshark code review
- [Wireshark-commits] master c347eb9: Eliminate proto_tree_add_text from packet-ipx.c,
Wireshark code review
- [Wireshark-commits] master e0e03ee: Eliminate proto_tree_add_text from packet-arp.c,
Wireshark code review
- [Wireshark-commits] master 6720c80: Eliminate proto_tree_add_text from packet-ismp.c,
Wireshark code review
- [Wireshark-commits] master 7f53986: Eliminate proto_tree_add_text from packet-nhrp.c,
Wireshark code review
- [Wireshark-commits] master 54dfe3b: Eliminate proto_tree_add_text from packet-smpp.c,
Wireshark code review
- [Wireshark-commits] master-1.12 182aba9: MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field,
Wireshark code review
- [Wireshark-commits] master-1.10 82828ed: MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field,
Wireshark code review
- [Wireshark-commits] master-1.12 5d75a6b: MIPv6: Mobility Option Binding Authorization Data for FMIPv6 Authenticator field is read beyond the option data,
Wireshark code review
- [Wireshark-commits] master-1.12 ee233b7: MIPv6: Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data,
Wireshark code review
- [Wireshark-commits] master ec5159b: PCAPNG (wiretap): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master-1.10 19141fe: MIPv6: Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data,
Wireshark code review
- [Wireshark-commits] master-1.10 a2ace6b: MIPv6: Mobility Option Binding Authorization Data for FMIPv6 Authenticator field is read beyond the option data,
Wireshark code review
- [Wireshark-commits] master-1.12 04ab605: IPv6: QuickStart option Nonce is read incorrectly,
Wireshark code review
- [Wireshark-commits] master 8842e2e: Eliminate proto_tree_add_text from packet-tds.c,
Wireshark code review
- [Wireshark-commits] master 8def8ef: packet-amqp.c: Temporary/preliminary fix for Bug #10582 (crash),
Wireshark code review
- [Wireshark-commits] master db316c9: TDS: Make buildbot happy,
Wireshark code review
- [Wireshark-commits] master-1.12 4655270: packet-amqp.c: Temporary/preliminary fix for Bug #10582 (crash),
Wireshark code review
- [Wireshark-commits] master-1.10 531d294: packet-amqp.c: Temporary/preliminary fix for Bug #10582 (crash),
Wireshark code review
- [Wireshark-commits] master 1427a8e: [Automatic manuf, services and enterprise-numbers update for 2014-10-19],
Wireshark code review
- [Wireshark-commits] master-1.12 71bd75e: [Automatic manuf, services and enterprise-numbers update for 2014-10-19],
Wireshark code review
- [Wireshark-commits] master-1.10 771a617: [Automatic manuf, services and enterprise-numbers update for 2014-10-19],
Wireshark code review
- [Wireshark-commits] master 5e4e17c: Remove unnecessary tvb_ensure_bytes_exist calls.,
Wireshark code review
- [Wireshark-commits] master ac55a6d: Get rid of unnecessary include of ctype.h.,
Wireshark code review
- [Wireshark-commits] master 2b6c267: Eliminate use of ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master-1.12 cf271b9: Eliminate use of ctype.h routines.,
Wireshark code review
- [Wireshark-commits] master 4d6b3db: Eliminate a use of a ctype.h function.,
Wireshark code review
- [Wireshark-commits] master-1.12 493d22c: Eliminate a use of a ctype.h function.,
Wireshark code review
- [Wireshark-commits] master-1.10 c72b3c3: Eliminate a use of a ctype.h function.,
Wireshark code review
- [Wireshark-commits] master c9b84a5: This appears to be clean with my build; see if it needs work with others.,
Wireshark code review
- [Wireshark-commits] master 4963d99: Eliminate proto_tree_add_text from packet-cdp.c,
Wireshark code review
- [Wireshark-commits] master 39c3a79: Check if mask_greatest_bit_offset is within limits.,
Wireshark code review
- [Wireshark-commits] master 0b9eb9f: Get rid of unnecessary includes of ctype.h.,
Wireshark code review
- [Wireshark-commits] master 80e6f62: Get rid of calls to ctype.h functions.,
Wireshark code review
- [Wireshark-commits] master-1.12 393759d: Get rid of calls to ctype.h functions.,
Wireshark code review
- [Wireshark-commits] master-1.10 3e9482f: Get rid of calls to ctype.h functions.,
Wireshark code review
- [Wireshark-commits] master-1.10 f3a98eb: Clean up comments.,
Wireshark code review
- [Wireshark-commits] master-1.12 86a6642: Clean up a comment.,
Wireshark code review
- [Wireshark-commits] master 9ffb72b: Clean up some comments.,
Wireshark code review
- [Wireshark-commits] master 700bfdc: More comment cleanup.,
Wireshark code review
- [Wireshark-commits] master 091aea8: And some more comment cleanup.,
Wireshark code review
- [Wireshark-commits] master-1.12 204069d: Clean up comments.,
Wireshark code review
- [Wireshark-commits] master-1.10 6b99232: Clean up comments.,
Wireshark code review
- [Wireshark-commits] master 9eb0080: Sign, Flex strikes again; it generates code that produces warnings.,
Wireshark code review
- [Wireshark-commits] master-1.10 c5fe6bf: Fix previous merge.,
Wireshark code review
- [Wireshark-commits] master-1.12 20ca1fb: Remove the ctype.h function call.,
Wireshark code review
- [Wireshark-commits] master-1.12 bcf9508: Get rid of one more isalpha() call in favor of g_ascii_isalpha().,
Wireshark code review
- [Wireshark-commits] master 991743b: Get rid of another toupper() call in favor of g_ascii_toupper().,
Wireshark code review
- [Wireshark-commits] master-1.12 0a01c2d: Get rid of another toupper() call in favor of g_ascii_toupper().,
Wireshark code review
- [Wireshark-commits] master-1.10 68ff8fb: Get rid of another toupper() call in favor of g_ascii_toupper().,
Wireshark code review
- [Wireshark-commits] master-1.12 794502d: Don't use <ctype.h> macros.,
Wireshark code review
- [Wireshark-commits] master-1.10 fc8132c: Don't use <ctype.h> macros.,
Wireshark code review
- [Wireshark-commits] master c3f14ab: Don't use toupper() in the test program.,
Wireshark code review
- [Wireshark-commits] master-1.12 5db9ef7: Eliminate some more ctype.h calls.,
Wireshark code review
- [Wireshark-commits] master d86b308: kafka: compression codec is unsigned,
Wireshark code review
- [Wireshark-commits] master a2508bd: OS X: Add retina / hidpi support to Info.plist.,
Wireshark code review
- [Wireshark-commits] master bc27265: tn5250: fix an endless loop, exit when offset is not incremented,
Wireshark code review
- [Wireshark-commits] master 0bbe483: Proto: Fixed proto_unregister_field(),
Wireshark code review
- [Wireshark-commits] master-1.12 e922efd: Proto: Fixed proto_unregister_field(),
Wireshark code review
- [Wireshark-commits] master 77f9699: Fix support for writing out edited records.,
Wireshark code review
- [Wireshark-commits] master 43a21c8: kafka: summarize number of messages in a set,
Wireshark code review
- [Wireshark-commits] master-1.12 fad4ecc: tn5250: fix an endless loop, exit when offset is not incremented,
Wireshark code review
- [Wireshark-commits] master-1.10 d7174c0: tn5250: fix an endless loop, exit when offset is not incremented,
Wireshark code review
- [Wireshark-commits] master f66e45b: Export cf_set_frame_edited().,
Wireshark code review
- [Wireshark-commits] master a19825b: CMake: Use WIRESHARK_LIB_DIR. Fix GThread check on Windows.,
Wireshark code review
- [Wireshark-commits] master 29ab967: Fix a number of what appear to be errors.,
Wireshark code review
- [Wireshark-commits] master 8868cf1: Fix the earlier checkin.,
Wireshark code review
- [Wireshark-commits] master 8dd032e: file.c isn't in a DLL, so what it exports shouldn't be WS_DLL_PUBLIC.,
Wireshark code review
- [Wireshark-commits] master 7522497: With CMake, define WANT_PACKET_EDITOR in config.h.,
Wireshark code review
- [Wireshark-commits] master c4dc9ed: Handle an hfindex of -1.,
Wireshark code review
- [Wireshark-commits] master 750d377: Add OID dissector table for PER based dissection.,
Wireshark code review
- [Wireshark-commits] master 39b631d: Add OID callback for private IEs making it possible to call a dissector for the private OID.,
Wireshark code review
- [Wireshark-commits] master 8638624: Make the "-qt" option the default in the OS X packaging scripts.,
Wireshark code review
- [Wireshark-commits] master 5f6be84: no need for continue at the end of a while loop, we loop anyway,
Wireshark code review
- [Wireshark-commits] master b757038: no need for if(tree),
Wireshark code review
- [Wireshark-commits] master 1463db3: tn5220: prevent another potential endless loop exit the loop if dissect_unknown_data() returns 0,
Wireshark code review
- [Wireshark-commits] master 4664ac6: fix wrong offset for ID Capability Flags 1 reported by Jean-Marc Lamond,
Wireshark code review
- [Wireshark-commits] master-1.12 770aad0: fix wrong offset for ID Capability Flags 1 reported by Jean-Marc Lamond,
Wireshark code review
- [Wireshark-commits] master 24f0888: Fix the condition for an expert info,
Wireshark code review
- [Wireshark-commits] master e5d967b: osx-app.sh: Add verbosity.,
Wireshark code review
- [Wireshark-commits] master 9ddbc8d: Qt: Fill in time display menu items. Other fixes and updates.,
Wireshark code review
- [Wireshark-commits] master fc75085: libnghttp2: Update to 0.6.4,
Wireshark code review
- [Wireshark-commits] master 0c444f3: OS X: Fix osx-dmg.sh bundle binary path.,
Wireshark code review
- [Wireshark-commits] master 527796b: Refactor pinfo->circuit_id behavior for ISUP dissector,
Wireshark code review
- [Wireshark-commits] master 0ce3640: Replace pinfo->circuit_id will passing data through functions.,
Wireshark code review
- [Wireshark-commits] [wireshark] reference refs/changes/56/2956 created (now 25dcacc),
Wireshark code review
- [Wireshark-commits] master c2f58d3: Android: Add ADB dissector,
Wireshark code review
- [Wireshark-commits] master fc4471f: Bluetooth: A2DP: APT-X does not use RTP while there is no content protection,
Wireshark code review
- [Wireshark-commits] master 2dbc852: Add packet-adb_service.h to epan/dissectors/Makefile.common,
Wireshark code review
- [Wireshark-commits] master 589db1c: Add Couchbase dissector (binary protocol),
Wireshark code review
- [Wireshark-commits] master 58304b9: S1AP: Add an S1AP context to be able to determine which message and message type an IE was sent in. Needed to dissect proprietarry data.,
Wireshark code review
- [Wireshark-commits] master c5a8876: Couchbase: fix FSF address and reorder opcode_vals array,
Wireshark code review
- [Wireshark-commits] master e2bece7: Qt: Show / hide main widgets.,
Wireshark code review
- [Wireshark-commits] master e6750fe: Couchbase: fix some warnings found by the pre-commit hook,
Wireshark code review
- [Wireshark-commits] master a0d5ef8: Lua: Added support for FT_EUI64.,
Wireshark code review
- [Wireshark-commits] master-1.12 f0b11db: NSIS: Start winding down the Wireshark 2 Preview.,
Wireshark code review
- [Wireshark-commits] master 97a920c: Don't free global_capture_opts.ifaces_err_info.,
Wireshark code review
- [Wireshark-commits] master d2bb61a: OS X: Integrate CMake and osx-app.sh,
Wireshark code review
- [Wireshark-commits] master 48da429: Add a "placeholder protocol" for H.223 to avoid confusion when using Decode As.,
Wireshark code review
- [Wireshark-commits] master 001dbaf: ESP: honor enable_null_encryption_decode_heuristic preference when the ESP packet does not match any known SA,
Wireshark code review
- [Wireshark-commits] master ceff4ed: Qt: Refactor ByteViewText.,
Wireshark code review
- [Wireshark-commits] master 88d1bba: Italian translation fixes,
Wireshark code review
- [Wireshark-commits] master 41f6923: ncp2222: initialize buffer in build_expert_data,
Wireshark code review
- [Wireshark-commits] master-1.12 b726d17: ncp2222: initialize buffer in build_expert_data,
Wireshark code review
- [Wireshark-commits] master-1.10 8f61ce9: ncp2222: initialize buffer in build_expert_data,
Wireshark code review
- [Wireshark-commits] master 3d2ec16: Qt: ByteViewText fixups.,
Wireshark code review
- [Wireshark-commits] master 1a45f18: More offset color adjustments.,
Wireshark code review
- [Wireshark-commits] master f36bbff: Update a comment.,
Wireshark code review
- [Wireshark-commits] master 6ebb50c: Get rid of a trailing blank.,
Wireshark code review
- [Wireshark-commits] master 30742dd: Expand comments.,
Wireshark code review
- [Wireshark-commits] master 6e5784d: Added support for AllJoyn Reliable Datagram Protocol.,
Wireshark code review
- [Wireshark-commits] master 155c939: Use better theme-derived colors. Switch back to AlternateBase for protocol-level highlighting.,
Wireshark code review
- [Wireshark-commits] master 3ffd8c5: Use Wifi Alliance OUI for MA USB packets over SNAP,
Wireshark code review
- [Wireshark-commits] master 803a2f9: Various Mobile IPv6 bugfixes,
Wireshark code review
- [Wireshark-commits] master-1.12 c9c1b3c: Various Mobile IPv6 bugfixes,
Wireshark code review
- [Wireshark-commits] master 079a017: [Automatic manuf, services and enterprise-numbers update for 2014-10-26],
Wireshark code review
- [Wireshark-commits] master-1.12 e8bc84e: [Automatic manuf, services and enterprise-numbers update for 2014-10-26],
Wireshark code review
- [Wireshark-commits] master-1.10 0d63d81: [Automatic manuf, services and enterprise-numbers update for 2014-10-26],
Wireshark code review
- [Wireshark-commits] master-1.10 a478316: Various Mobile IPv6 bugfixes,
Wireshark code review
- [Wireshark-commits] master 3ac46ed: add TLS_FALLBACK_SCSV,
Wireshark code review
- [Wireshark-commits] master c33deaa: SSL 3.0 and TLS ciphersuite values are two bytes long,
Wireshark code review
- [Wireshark-commits] master-1.12 4011a54: Add a "placeholder protocol" for H.223 to avoid confusion when using Decode As.,
Wireshark code review
- [Wireshark-commits] master-1.10 3cac251: Add a "placeholder protocol" for H.223 to avoid confusion when using Decode As.,
Wireshark code review
- [Wireshark-commits] master 1c15981: Qt: ByteViewText hover information.,
Wireshark code review
- [Wireshark-commits] master ee72432: Add enumerated value 639 to vals_parm_PID.,
Wireshark code review
- [Wireshark-commits] master-1.12 c1bccd1: Add enumerated value 639 to vals_parm_PID.,
Wireshark code review
- [Wireshark-commits] master-1.10 1b956b7: Add enumerated value 639 to vals_parm_PID.,
Wireshark code review
- [Wireshark-commits] master 84f0ce4: Qt: Add bits display support to the byte view.,
Wireshark code review
- [Wireshark-commits] master c5e66b1: Qt: Add a set of 2x 24-pixel toolbar icons.,
Wireshark code review
- [Wireshark-commits] master 60172fa: ADB_cs: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 309840f: TN5250: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 2418d06: AllJoyn: fix warning: no previous prototype for 'add_padding_item' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 55cc577: Couchbase: fix no previous prototype for ... [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master f62d60b: Infiniband: fix warning: C++ style comments are not allowed in ISO C90,
Wireshark code review
- [Wireshark-commits] master 7ff0860: Knxnetip: fix warning: ISO C does not allow extra '; ' outside of a function,
Wireshark code review
- [Wireshark-commits] master 5bed338: HPSW: Fix soft-deprecated APIs warning,
Wireshark code review
- [Wireshark-commits] master 6055f35: The "data rate" field in the 11n version of the header is an MCS index.,
Wireshark code review
- [Wireshark-commits] master 6369b8e: Try to fix dist.,
Wireshark code review
- [Wireshark-commits] master 0a5d6a1: MAUSB: fix warning: no previous prototype for 'proto_register_wfa_oui' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master-1.12 bba3b55: packet-amqp.c: 2nd try: Temporary/preliminary fix for Bug #10582 (crash),
Wireshark code review
- [Wireshark-commits] master 7e6b029: Bug 9586 says bit 0x00000100 in the "802.11n flags" means "802.11ac".,
Wireshark code review
- [Wireshark-commits] master a2b9b90: Some additional information from bug 10637.,
Wireshark code review
- [Wireshark-commits] master 960ddb0: HPSW: Fix display of wrong length,
Wireshark code review
- [Wireshark-commits] master 25448b0: ISIS: Display code/type and length for unknown code/type,
Wireshark code review
- [Wireshark-commits] master 09957ca: DNS NXT RR is parsed incorrectly,
Wireshark code review
- [Wireshark-commits] master 3d359da: Refactor pinfo->circuit_id from H.223 dissector.,
Wireshark code review
- [Wireshark-commits] master 422e1d9: Add a comment showing mapping to radiotap.,
Wireshark code review
- [Wireshark-commits] master 9056eb9: Patch for KNXnet/IP dissector,
Wireshark code review
- [Wireshark-commits] master e8d2ba9: Pref: Remove unsued function,
Wireshark code review
- [Wireshark-commits] master 0011fc4: Add GPLv2+ license header to keep license-check happy.,
Wireshark code review
- [Wireshark-commits] master bab44ad: Add some new features to the list and regenerate NEWS.,
Wireshark code review
- [Wireshark-commits] master 8ea4df9: Use g_ascii_isalnum() rather than isalnum().,
Wireshark code review
- [Wireshark-commits] master-1.12 0bc5c2c: Use g_ascii_isalnum() rather than isalnum().,
Wireshark code review
- [Wireshark-commits] master-1.10 d939342: Use g_ascii_isalnum() rather than isalnum().,
Wireshark code review
- [Wireshark-commits] master 417c181: Use guint8 for 8-bit unsigned numeric values.,
Wireshark code review
- [Wireshark-commits] master e86553e: Get rid of unnecessary include of <wsutil/strnatcmp.h>.,
Wireshark code review
- [Wireshark-commits] master 0b03183: Qt: Add a set of 2x 16-pixel toolbar icons.,
Wireshark code review
- [Wireshark-commits] master 451f7f0: Qt: Better protocol highlight colors.,
Wireshark code review
- [Wireshark-commits] master b8df934: Add missing stuff for custom plugins.,
Wireshark code review
- [Wireshark-commits] master 79f878f: VXLAN: Fix flag bitmasks,
Wireshark code review
- [Wireshark-commits] master 065d5c8: Don't include ctype.h and replace isascii() with _ascii_isprint(). Remove deprecated APIs while at it.,
Wireshark code review
- [Wireshark-commits] master d2f4b6f: Replace isalpha() with g_ascii_isprint().,
Wireshark code review
- [Wireshark-commits] master 4acf495: Rename the strnatcmp.c routines and make them use the g_ascii_XXX() routines.,
Wireshark code review
- [Wireshark-commits] master-1.10 00204d0: Convert a couple remaining isalpha() and isprint() calls that were left after the merges to this branch.,
Wireshark code review
- [Wireshark-commits] master 8165448: Expand the 802.11 pseudo-header and support new radio metadata.,
Wireshark code review
- [Wireshark-commits] master aff087a: Handle the MCS index in Peek tagged files.,
Wireshark code review
- [Wireshark-commits] master ec33c3d: Support the bandwidth and "short GI" fields from Peek tagged files.,
Wireshark code review
- [Wireshark-commits] master d2ee010a: Extract the center frequency from Peek tagged files.,
Wireshark code review
- [Wireshark-commits] master aac8daa: Use correct variable.,
Wireshark code review
- [Wireshark-commits] master fdb3ea5: Squelch some used-but-not-set warnings (one legitimate, others not).,
Wireshark code review
- [Wireshark-commits] master c0a4a91: Dataflow analysis is hard, let's go shopping!,
Wireshark code review
- [Wireshark-commits] master 79c977c: Remove the optional strncasecmp.{h, c} target (for systems that don't have that API).,
Wireshark code review
- [Wireshark-commits] master f8c7a5b: Add an RFC reference and fix deprecated API.,
Wireshark code review
- [Wireshark-commits] master fea733e: Add logic to determine if a "tvb get" call is used as a parameter to a proto_tree_add_text call. convert_proto_tree_add_text.pl has an easier time determining hf_ field values with a "tvb get" call present, so it's more likely those dissectors will be picked first in eliminating their proto_tree_add_text calls.,
Wireshark code review
- [Wireshark-commits] master cda985d: Create the compress module for compression functions.,
Wireshark code review
- [Wireshark-commits] master 62831ba: convert_proto_tree_add_text.pl - missed adding an else statement to logic.,
Wireshark code review
- [Wireshark-commits] master e0a3526: Tell the user which file __func__ was found in.,
Wireshark code review
- [Wireshark-commits] master 066a334: Add casts to try to please the OSX buildbot.,
Wireshark code review
- [Wireshark-commits] master 4210a8c: Replace one more isprint() with g_ascii_isprint().,
Wireshark code review
- [Wireshark-commits] master cc640f0: Prohibit ctype APIs (except toupper() which is still used by file.c - make that deprecated).,
Wireshark code review
- [Wireshark-commits] master a683dd3: Make the data rate field float, and calculate it for 802.11n.,
Wireshark code review
- [Wireshark-commits] master 3d9b35f: Fix a typo: Unidirected -> Undirected,
Wireshark code review
- [Wireshark-commits] master-1.12 3bc7a29: Fix a typo: Unidirected -> Undirected,
Wireshark code review
- [Wireshark-commits] master f5ed47d: Eliminate proto_tree_add_text from packet-q933.c,
Wireshark code review
- [Wireshark-commits] master 7665ac5: OS X: Don't add libtool control files to the app bundle.,
Wireshark code review
- [Wireshark-commits] master 2e31475: Add a missing backslash.,
Wireshark code review
- [Wireshark-commits] master 93d5bb3: temporary workaround to stop the fuzz failures,
Wireshark code review
- [Wireshark-commits] master 618560a: Eliminate proto_tree_add_text from packet-fcels.c,
Wireshark code review
- [Wireshark-commits] master 2787a93: HTTP2: Update to draft-15,
Wireshark code review
- [Wireshark-commits] master 47ff5bb: Sync debian symbol files to current API.,
Wireshark code review
- [Wireshark-commits] master 2717766: Use tcp_dissect_pdus in DCE/RPC dissector when running atop TCP.,
Wireshark code review
- [Wireshark-commits] master d93bf88: The C-Ares "done" file should have a name beginning with cares-.,
Wireshark code review
- [Wireshark-commits] master-1.12 f8bd205: The C-Ares "done" file should have a name beginning with cares-.,
Wireshark code review
- [Wireshark-commits] master 31e3fc0: Fix name of C-Ares source directory & make the name of the -done file match it.,
Wireshark code review
- [Wireshark-commits] master-1.12 c6a492d: Fix name of C-Ares source directory & make the name of the -done file match it.,
Wireshark code review
- [Wireshark-commits] master c427839: Fix: - packet-dcerpc.c:4664:51: error: unused parameter 'pinfo' [-Werror=unused-parameter] - packet-dcerpc.c:5083:83: error: unused parameter 'offset' [-Werror=unused-parameter] - Replace some deprecated APIs,
Wireshark code review
- [Wireshark-commits] master 0c97281: BER: tvb_length... -> tvb_reported_length...,
Wireshark code review
- [Wireshark-commits] master 96aa60a: CAMEL: tvb_length... -> tvb_reported_length...,
Wireshark code review
- [Wireshark-commits] master 0347ff9: Remove unused RA_PYTHON_REGISTER and RA_PYTHON_HANDOFF.,
Wireshark code review
- [Wireshark-commits] master c6feecf: Lua: Only register postdissectors once.,
Wireshark code review
- [Wireshark-commits] master-1.12 6c59070: Lua: Only register postdissectors once.,
Wireshark code review
- [Wireshark-commits] master 54efe5d: Improve the "guessing" of the hf_ field and encoding values.,
Wireshark code review
- [Wireshark-commits] master d821440: Eliminate proto_tree_add_text from packet-gtpv2.c,
Wireshark code review
- [Wireshark-commits] master d93be95: Clean up handling of BDC coded numbers a bit.,
Wireshark code review
- [Wireshark-commits] master 3426ffa: For OS X, don't rigidly tie the SDK version to the minimum target version.,
Wireshark code review
- [Wireshark-commits] master 29fda99: Undo my personal disabling of the Qt download/build/install.,
Wireshark code review
- [Wireshark-commits] master 065d2b7: Don't force a verbose build.,
Wireshark code review
- [Wireshark-commits] master 5a71cfd: Qt: Disable our widgets while tapping.,
Wireshark code review
- [Wireshark-commits] master 2bd1d46: Qt: Better Follow Stream hints.,
Wireshark code review
Mail converted by MHonArc
