Wireshark · Wireshark-commits: [Wireshark-commits] master-1.10 12738a5: Fix potential invalid-reads in catapult files

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=12738a56748dd828acb974edb41e7680a9b93005
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

12738a5 by Evan Huus (eapache@xxxxxxxxx):

    Fix potential invalid-reads in catapult files
    
    As caught by CppCheck, the conditions checking that n is in bounds should
    occur *before* the conditions using n as an index so that if n is out of bounds
    we don't try and use it anyways.
    
    (cherry picked from commit 72fc075e9a6b3ba79e49668e74a8dd187fc04f8a)
    
    Change-Id: I23de43d52984cb441fa08f5f7384c486c9de817c
    Reviewed-on: https://code.wireshark.org/review/4785
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e638689   Some replacement of ctype.h routines missed by the previous commit.
    adds  12738a5   Fix potential invalid-reads in catapult files


Summary of changes:
 wiretap/catapult_dct2000.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)