Wireshark-commits: [Wireshark-commits] master 63ab36b: Don't use <ctype.h> macros, and eliminate an
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2014 06:42:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63ab36be9266f79d92ac37e632299c8f0e2244f1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

63ab36b by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.
    
    This avoids locale-dependent tests, and fixes cases where we passed
    signed char values to those macros (which is not safe with char being
    signed, as it is on most, but not all, platforms).
    
    Change-Id: Iea962cd7e4dfaf33c3c873ba43814cc6ed298d94
    Reviewed-on: https://code.wireshark.org/review/4764
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  23b233d   Remove unnecessary include of <ctype.h>.
    adds  63ab36b   Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.


Summary of changes:
 ui/gtk/dfilter_expr_dlg.c |    5 ++---
 ui/persfilepath_opt.c     |    3 +--
 ui/recent.c               |    3 +--
 ui/time_shift.c           |    3 +--
 4 files changed, 5 insertions(+), 9 deletions(-)