Wireshark-commits: [Wireshark-commits] master 31c119f: MIPv6: Mobility Option IPv6 Address/Prefix m
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 18 Oct 2014 17:07:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31c119fa789782190cea2608decaa114318bb5d8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

31c119f by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field
    
    One of the mobility options is the IPv6 Address/Prefix.
    The prefix length of this option is 52.
    Note that according to RFC 5568, the prefix length is in bits and not in bytes.
    The IPv6 Address/Prefix field of this option marks 52 bytes.
    
    In addition, I'm not sure that the IPv6 Address/Prefix field is a variable size field.
    RFC 5568 section 6.4.2 has a diagram of this options that shows this field as if it always takes 128 bits, and the prefix length field just says the length of the prefix (not the length of the field).
    
    Found by boaz
    
    Bug:10576
    Change-Id: I2a9a35cb7c537ec3b91c9a089f14fa31f41d8c80
    Reviewed-on: https://code.wireshark.org/review/4816
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8d6fd8d   GSM(_a_rr): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  31c119f   MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field


Summary of changes:
 epan/dissectors/packet-mip6.c |   20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)