Wireshark-commits: [Wireshark-commits] master-1.12 eaccf31: [iSCSI] Fix incorrect heuristic.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Oct 2014 20:56:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eaccf31847a36d6025987d19700843d8eded339b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

eaccf31 by Anish Bhatt (anish@xxxxxxxxxxx):

    [iSCSI] Fix incorrect heuristic.
    
    The only valid check for Expected Data Transfer Length is :
    R and W	     MUST  NOT both be 0 when the Expected Data Transfer Length and/or
    Bidirectional Read Expected Data Transfer Length are not 0
    
    Backported with manual intervention from I5503a5ad524c4e237b143696fc8eda895bcb9172
    with change to reflect v1.12 version of packet-isci.c code.
    
    Ping-Bug: 10469
    
    Change-Id: I4b3ed968a092ff3a6704f94f4517d45793a599cf
    Reviewed-on: https://code.wireshark.org/review/4530
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  457c4f9   LLDP: TIA Network Policy Unknown Policy Flag Decode is not correct
    adds  eaccf31   [iSCSI] Fix incorrect heuristic.


Summary of changes:
 epan/dissectors/packet-iscsi.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)