Wireshark-commits: [Wireshark-commits] master-1.12 24fa893: Don't use <ctype.h> macros, and elimina
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2014 06:45:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24fa893a2f35d121b19de66bb8f060ebd1eb6e94
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

24fa893 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.
    
    This avoids locale-dependent tests, and fixes cases where we passed
    signed char values to those macros (which is not safe with char being
    signed, as it is on most, but not all, platforms).
    
    (cherry picked from commit 63ab36be9266f79d92ac37e632299c8f0e2244f1)
    
    Change-Id: I67a838946fc9637cfc826a830f6a64b3f8fa64b9
    Reviewed-on: https://code.wireshark.org/review/4765
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ccae7e4   Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.
    adds  24fa893   Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.


Summary of changes:
 ui/gtk/dfilter_expr_dlg.c |    5 ++---
 ui/persfilepath_opt.c     |    3 +--
 ui/recent.c               |    3 +--
 ui/time_shift.c           |    3 +--
 4 files changed, 5 insertions(+), 9 deletions(-)