Wireshark-commits: [Wireshark-commits] master 3d2ec16: Qt: ByteViewText fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Oct 2014 19:39:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d2ec1613b826faf6d10702147cea96286e44516
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3d2ec16 by Gerald Combs (gerald@xxxxxxxx):

    Qt: ByteViewText fixups.
    
    Calculate our X coordinate using floating point arithmetic. This should
    hopefully fix the wierd subpixel text shifting for some font sizes.
    
    Add alpha blending convenience routines to ColorUtils. Use them to
    create the offset colors. The button color palette wasn't working very
    well under Ubuntu.
    
    Use QFontMetricsF::lineSpacing for our line height.
    
    Note that we don't support the BOLD gui.hex_dump_highlight_style
    preference. Leave a hint for anyone wishing to do so. Comment out
    related code for now.
    
    Change-Id: Ief77c9c8d00e05560cae6ecd781bd309027f6f5a
    Reviewed-on: https://code.wireshark.org/review/4927
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  41f6923   ncp2222: initialize buffer in build_expert_data
    adds  3d2ec16   Qt: ByteViewText fixups.


Summary of changes:
 ui/qt/byte_view_text.cpp |   61 ++++++++++++++++++++++++++++------------------
 ui/qt/byte_view_text.h   |   12 ++++++---
 ui/qt/color_utils.cpp    |   20 +++++++++++++++
 ui/qt/color_utils.h      |    5 +++-
 4 files changed, 70 insertions(+), 28 deletions(-)