Wireshark-commits: [Wireshark-commits] master-1.10 a478316: Various Mobile IPv6 bugfixes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Oct 2014 21:54:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a4783169aa6211a5ae442bf4bbdcd202045c002b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

a478316 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Various Mobile IPv6 bugfixes
    
    Most of this was found by Boaz Brickner, but to prevent a few more bug reports, I tried to find any remaining MIPv6 options that used -1 to read until "end of packet" instead of "end of option"
    
    1. Option-Code and Reserved fields should be 1 byte, not 2 in Local Mobility Anchor Address mobility option
    2. IPv6 AUTH mobility option parses Mobility SPI
    3. IPv6 MESG-ID (should just be a timestamp field)
    4. IPv6 Redirect Mobility Option K and N bits are parsed incorrectly
    
    5. The following options had a field that read until the end of the packet instead of the end of the option:
    DNS-UPDATE-TYPE
    AUTH Authentication Data
    Care Of Test
    Permanent Home Keygen Token
    CGA Parameters
    Signature
    Experimental Mobility Option
    
    Bug: 10630
    Bug: 10629
    Bug: 10626
    Bug: 10625
    Bug: 10624
    Bug: 10622
    Bug: 10619
    
    Reviewed-on: https://code.wireshark.org/review/4932
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 803a2f9518b9d207094dabfc01ad462e46588ef3)
    
    Conflicts:
    	epan/dissectors/packet-mip6.c
    
    Change-Id: I1bd4eeb4ed11d64d99c833ebde985515d9ffb6f5
    Reviewed-on: https://code.wireshark.org/review/4936
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0d63d81   [Automatic manuf, services and enterprise-numbers update for 2014-10-26]
    adds  a478316   Various Mobile IPv6 bugfixes


Summary of changes:
 epan/dissectors/packet-mip6.c |   71 +++++++++++++++++++++++++++--------------
 1 file changed, 47 insertions(+), 24 deletions(-)