Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 182aba9: MIPv6: Mobility Option IPv6 Address/Prefix marks too many b

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=182aba9a61a8604a960d023b0b66f1c6df7444c5
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

182aba9 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field
    
    One of the mobility options is the IPv6 Address/Prefix.
    The prefix length of this option is 52.
    Note that according to RFC 5568, the prefix length is in bits and not in bytes.
    The IPv6 Address/Prefix field of this option marks 52 bytes.
    
    In addition, I'm not sure that the IPv6 Address/Prefix field is a variable size field.
    RFC 5568 section 6.4.2 has a diagram of this options that shows this field as if it always takes 128 bits, and the prefix length field just says the length of the prefix (not the length of the field).
    
    Found by boaz
    
    Bug:10576
    Change-Id: I2a9a35cb7c537ec3b91c9a089f14fa31f41d8c80
    Reviewed-on: https://code.wireshark.org/review/4816
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 31c119fa789782190cea2608decaa114318bb5d8)
    Change-Id: I2a9a35cb7c537ec3b91c9a089f14fa31f41d8c80
    Reviewed-on: https://code.wireshark.org/review/4819
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  c734c57   Don't use ctype.h routines.
    adds  182aba9   MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field


Summary of changes:
 epan/dissectors/packet-mip6.c |   20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)