Wireshark · Wireshark-commits: [Wireshark-commits] master 29ab967: Fix a number of what appear to be errors.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29ab9673f9e9590335e40a17e1339fb7893e8230
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

29ab967 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix a number of what appear to be errors.
    
    Add checks for too-short length fields.
    
    Increment the offset after some proto_tree_add_item() calls to skip past
    the item.
    
    Make some other length calculations use the start of the item to which
    the length applies, not the start of the *list* of items.
    
    Fix a double-digit field to be 2 bytes long (as the documentation says
    it is).
    
    Add a comment about a field that isn't always present but that's
    specified in a tn5250_add_hf_items() list.
    
    Fix DEFINE PITCH TABLE to match what the documentation appears to say it
    is.
    
    Change-Id: Ibcdc580045c68e8d0d8f35011dfe72b9c245e157
    Reviewed-on: https://code.wireshark.org/review/4888
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a19825b   CMake: Use WIRESHARK_LIB_DIR. Fix GThread check on Windows.
    adds  29ab967   Fix a number of what appear to be errors.


Summary of changes:
 epan/dissectors/packet-tn5250.c |   71 ++++++++++++++++++++++++++++++++++-----
 1 file changed, 63 insertions(+), 8 deletions(-)