Wireshark · Wireshark-commits: [Wireshark-commits] master a9e6c2c: Overhaul the filterability of packet-ansi_683.c

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9e6c2c917559c5083d9f5ff256233792566d3dc
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a9e6c2c by Michael Mann (mmann78@xxxxxxxxxxxx):

    Overhaul the filterability of packet-ansi_683.c
    
    It's (ab)use of proto_tree_add_text was "hidden" behind a single FT_NONE hf item, that effectively had the same behavior of proto_tree_add_text, but wouldn't show up in checkAPIs.pl.  Replaced the (over 200+) proto_tree_add_none_format calls with proto_tree_add_text and then ran convert_proto_tree_add_text.pl on the dissector.  That started the cleanup, and I did more while in the neighborhood.
    
    Change-Id: I89e09cf23e8998bcc9197f9a4043e1fc2850fc8c
    Reviewed-on: https://code.wireshark.org/review/4521
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  1280015   [iSCSI] Fix incorrect heuristic.
    adds  a9e6c2c   Overhaul the filterability of packet-ansi_683.c


Summary of changes:
 epan/dissectors/packet-3g-a11.c     |    2 -
 epan/dissectors/packet-ansi_683.c   | 3370 +++++++++++------------------------
 epan/dissectors/packet-gsm_a_dtap.c |    1 -
 epan/tfs.c                          |    1 +
 epan/tfs.h                          |    1 +
 5 files changed, 1068 insertions(+), 2307 deletions(-)