Wireshark-commits: [Wireshark-commits] master 1c15981: Qt: ByteViewText hover information.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Oct 2014 02:05:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c159818fd9a1cbc667d7aa675ed776e3c202523
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1c15981 by Gerald Combs (gerald@xxxxxxxx):

    Qt: ByteViewText hover information.
    
    When the user hovers over a byte view field, highlight it and show a
    description in the status bar.
    
    Add a "byte" status bar context and fix a label stack pop bug.
    
    Keep proto_find_field_from_offset from matching generated items.
    Otherwise hovering and selecting finds things like GeoIP entries and
    checksum validation information. This affects the GTK+ UI as well.
    
    Change-Id: Ic81c0d8159510a72d30c41f961807d8a48d05e16
    Reviewed-on: https://code.wireshark.org/review/4943
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  c33deaa   SSL 3.0 and TLS ciphersuite values are two bytes long
    adds  1c15981   Qt: ByteViewText hover information.


Summary of changes:
 epan/proto.c              |    2 +-
 ui/qt/byte_view_tab.cpp   |    1 +
 ui/qt/byte_view_tab.h     |    1 +
 ui/qt/byte_view_text.cpp  |  115 ++++++++++++++++++++++++++++++++-------------
 ui/qt/byte_view_text.h    |   22 ++++++---
 ui/qt/label_stack.cpp     |   18 +++----
 ui/qt/label_stack.h       |    2 +-
 ui/qt/main_status_bar.cpp |   15 ++++++
 ui/qt/main_status_bar.h   |    2 +
 ui/qt/main_window.cpp     |    4 +-
 10 files changed, 131 insertions(+), 51 deletions(-)