Wireshark-commits: [Wireshark-commits] master 798eb97: Qt: Packet list column sorting.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Oct 2014 21:10:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=798eb9705341bdf330e8e238b6f0f2fb278a64c8
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

798eb97 by Gerald Combs (gerald@xxxxxxxx):

    Qt: Packet list column sorting.
    
    Sorting behavior should be identical to GTK+.
    
    Pass the correct position to beginInsertRows. Add a list of to-do items
    to packet_list.cpp.
    
    Change-Id: Ie6ab4b9f2d780a2af430d0f90529edca5485dada
    Reviewed-on: https://code.wireshark.org/review/4481
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  5051ae1   Convert "4 space tabs" to spaces; Adjust editor modelines.
    adds  798eb97   Qt: Packet list column sorting.


Summary of changes:
 epan/frame_data.h                 |    8 +++
 ui/qt/main_window.cpp             |    2 +-
 ui/qt/packet_list.cpp             |   27 ++++++----
 ui/qt/packet_list_model.cpp       |  103 +++++++++++++++++++++++++++++++++++--
 ui/qt/packet_list_model.h         |    8 +++
 ui/qt/packet_list_record.cpp      |    8 +--
 ui/qt/packet_list_record.h        |    8 ++-
 ui/qt/related_packet_delegate.cpp |    2 +-
 ui/ui_util.h                      |    2 +-
 9 files changed, 144 insertions(+), 24 deletions(-)