Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 f2859a5: Use g_ascii_isalnum() rather than isalnum().

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2859a533da4a67ea9b706aa3d12dc4342747984
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f2859a5 by Guy Harris (guy@xxxxxxxxxxxx):

    Use g_ascii_isalnum() rather than isalnum().
    
    That way, we don't have to worry about casting the argument (which, in
    one place, was done wrong - casting to int preserves the sign-extension
    done with signed chars), and don't have to worry about a locale in which
    particular 8-bit byte values are considered alphanumeric characters.
    
    Change-Id: I129b4bfdad70ade4ab6e0a1d2c13d59ae9e6f524
    Reviewed-on: https://code.wireshark.org/review/4751
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit e6fcff1eb62b581eb7fb3d7af1d2e38612a00b30)
    Reviewed-on: https://code.wireshark.org/review/4752
    

Actions performed:

    from  d956cd2   Make sort_alphabet() not fail too badly with characters in [128,255].
    adds  f2859a5   Use g_ascii_isalnum() rather than isalnum().


Summary of changes:
 epan/dfilter/dfilter-macro.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)